aboutsummaryrefslogtreecommitdiffstats
path: root/Source
diff options
context:
space:
mode:
authorMax <dmoagx@users.noreply.github.com>2018-05-13 20:01:14 +0200
committerMax <dmoagx@users.noreply.github.com>2018-05-13 20:01:14 +0200
commitc2fe67ba840a5f4eaa2aed786da3e559b3a8b150 (patch)
tree82aa3750540dc147dd70054a2543c96a424f2419 /Source
parente49d33edfb80f7de00b9971240a428cc72829421 (diff)
downloadsequelpro-c2fe67ba840a5f4eaa2aed786da3e559b3a8b150.tar.gz
sequelpro-c2fe67ba840a5f4eaa2aed786da3e559b3a8b150.tar.bz2
sequelpro-c2fe67ba840a5f4eaa2aed786da3e559b3a8b150.zip
#63: Rename class SPTableContentFilterController to SPRuleFilterController to reduce confusion
Diffstat (limited to 'Source')
-rw-r--r--Source/SPRuleFilterController.h (renamed from Source/SPTableContentFilterController.h)6
-rw-r--r--Source/SPRuleFilterController.m (renamed from Source/SPTableContentFilterController.m)12
-rw-r--r--Source/SPTableContent.h4
-rw-r--r--Source/SPTableContent.m54
4 files changed, 38 insertions, 38 deletions
diff --git a/Source/SPTableContentFilterController.h b/Source/SPRuleFilterController.h
index 3fe5e8ea..45c28fce 100644
--- a/Source/SPTableContentFilterController.h
+++ b/Source/SPRuleFilterController.h
@@ -1,5 +1,5 @@
//
-// SPTableContentFilterController.h
+// SPRuleFilterController.h
// sequel-pro
//
// Created by Max Lohrmann on 04.05.18.
@@ -33,9 +33,9 @@
@class SPTablesList;
@class SPContentFilterManager;
-NSString * const SPTableContentFilterHeightChangedNotification;
+NSString * const SPRuleFilterHeightChangedNotification;
-@interface SPTableContentFilterController : NSObject {
+@interface SPRuleFilterController : NSObject {
IBOutlet NSRuleEditor *filterRuleEditor;
IBOutlet SPTableData *tableDataInstance;
IBOutlet SPDatabaseDocument *tableDocumentInstance;
diff --git a/Source/SPTableContentFilterController.m b/Source/SPRuleFilterController.m
index a2d6b2d2..baba3eb7 100644
--- a/Source/SPTableContentFilterController.m
+++ b/Source/SPRuleFilterController.m
@@ -1,5 +1,5 @@
//
-// SPTableContentFilterController.m
+// SPRuleFilterController.m
// sequel-pro
//
// Created by Max Lohrmann on 04.05.18.
@@ -28,7 +28,7 @@
//
// More info at <https://github.com/sequelpro/sequelpro>
-#import "SPTableContentFilterController.h"
+#import "SPRuleFilterController.h"
#import "SPQueryController.h"
#import "SPDatabaseDocument.h"
#import "RegexKitLite.h"
@@ -44,7 +44,7 @@ typedef NS_ENUM(NSInteger, RuleNodeType) {
RuleNodeTypeConnector,
};
-NSString * const SPTableContentFilterHeightChangedNotification = @"SPTableContentFilterHeightChanged";
+NSString * const SPRuleFilterHeightChangedNotification = @"SPRuleFilterHeightChanged";
/**
* The type of filter rule that the current item represents.
@@ -164,7 +164,7 @@ const NSString * const SerFilterExprDefinition = @"_filterDefinition";
#pragma mark -
-@interface SPTableContentFilterController () <NSRuleEditorDelegate>
+@interface SPRuleFilterController () <NSRuleEditorDelegate>
@property (readwrite, assign, nonatomic) CGFloat preferredHeight;
@@ -190,7 +190,7 @@ static void _addIfNotNil(NSMutableArray *array, id toAdd);
@end
-@implementation SPTableContentFilterController
+@implementation SPRuleFilterController
@synthesize model = model;
@synthesize preferredHeight = preferredHeight;
@@ -505,7 +505,7 @@ static void _addIfNotNil(NSMutableArray *array, id toAdd);
}
if(wantsHeight != preferredHeight) {
[self setPreferredHeight:wantsHeight];
- [[NSNotificationCenter defaultCenter] postNotificationName:SPTableContentFilterHeightChangedNotification object:self];
+ [[NSNotificationCenter defaultCenter] postNotificationName:SPRuleFilterHeightChangedNotification object:self];
}
}
diff --git a/Source/SPTableContent.h b/Source/SPTableContent.h
index 1d5390bb..30b4c587 100644
--- a/Source/SPTableContent.h
+++ b/Source/SPTableContent.h
@@ -43,7 +43,7 @@
@class SPDatabaseDocument;
@class SPTablesList;
@class SPTableStructure;
-@class SPTableContentFilterController;
+@class SPRuleFilterController;
@class SPFilterTableController;
typedef NS_ENUM(NSInteger, SPTableContentFilterSource) {
@@ -96,7 +96,7 @@ typedef NS_ENUM(NSInteger, SPTableContentFilterSource) {
#ifndef SP_CODA
IBOutlet NSStepper *paginationPageStepper;
- IBOutlet SPTableContentFilterController *filterControllerInstance;
+ IBOutlet SPRuleFilterController *ruleFilterController;
IBOutlet SPFilterTableController *filterTableController;
BOOL scrollViewHasRubberbandScrolling;
#endif
diff --git a/Source/SPTableContent.m b/Source/SPTableContent.m
index b27200c0..750a4a52 100644
--- a/Source/SPTableContent.m
+++ b/Source/SPTableContent.m
@@ -56,7 +56,7 @@
#import "SPThreadAdditions.h"
#import "SPTableFilterParser.h"
#import "SPFunctions.h"
-#import "SPTableContentFilterController.h"
+#import "SPRuleFilterController.h"
#import "SPFilterTableController.h"
#import <pthread.h>
@@ -235,20 +235,20 @@ static void *TableContentKVOContext = &TableContentKVOContext;
// Add observer to change view sizes with filter rule editor
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(filterRuleEditorPreferredSizeChanged:)
- name:SPTableContentFilterHeightChangedNotification
- object:filterControllerInstance];
+ name:SPRuleFilterHeightChangedNotification
+ object:ruleFilterController];
[contentAreaContainer setPostsFrameChangedNotifications:YES];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(contentViewSizeChanged:)
name:NSViewFrameDidChangeNotification
object:contentAreaContainer];
- [filterControllerInstance setTarget:self];
- [filterControllerInstance setAction:@selector(filterTable:)];
+ [ruleFilterController setTarget:self];
+ [ruleFilterController setAction:@selector(filterTable:)];
[filterTableController setTarget:self];
[filterTableController setAction:@selector(filterTable:)];
//TODO This is only needed for 10.6 compatibility
- scrollViewHasRubberbandScrolling = [[[filterControllerInstance view] enclosingScrollView] respondsToSelector:@selector(setVerticalScrollElasticity:)];
+ scrollViewHasRubberbandScrolling = [[[ruleFilterController view] enclosingScrollView] respondsToSelector:@selector(setVerticalScrollElasticity:)];
// Add observers for document task activity
[[NSNotificationCenter defaultCenter] addObserver:self
@@ -362,7 +362,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
[self setRuleEditorVisible:NO animate:NO];
[toggleRuleFilterButton setEnabled:NO];
[toggleRuleFilterButton setState:NSOffState];
- [filterControllerInstance setColumns:nil];
+ [ruleFilterController setColumns:nil];
// Disable pagination
[paginationPreviousButton setEnabled:NO];
@@ -634,9 +634,9 @@ static void *TableContentKVOContext = &TableContentKVOContext;
[filterTableController setColumns:dataColumns];
// Enable and initialize filter fields (with tags for position of menu item and field position)
- [filterControllerInstance setColumns:dataColumns];
+ [ruleFilterController setColumns:dataColumns];
// Restore preserved filter settings if appropriate and valid
- [filterControllerInstance restoreSerializedFilters:filtersToRestore];
+ [ruleFilterController restoreSerializedFilters:filtersToRestore];
// hide/show the rule filter editor, based on its previous state (so that it says visible when switching tables, if someone has enabled it and vice versa)
if(showFilterRuleEditor) {
[self setRuleEditorVisible:YES animate:NO];
@@ -646,7 +646,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
[self setRuleEditorVisible:NO animate:NO];
[toggleRuleFilterButton setState:NSOffState];
}
- [filterControllerInstance setEnabled:enableInteraction];
+ [ruleFilterController setEnabled:enableInteraction];
[toggleRuleFilterButton setEnabled:enableInteraction];
// restore the filter to the previously choosen one for the table
activeFilter = activeFilterToRestore;
@@ -1014,7 +1014,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
BOOL caseSensitive = (([[NSApp currentEvent] modifierFlags] & NSShiftKeyMask) > 0);
NSError *err = nil;
- NSString *filter = [filterControllerInstance sqlWhereExpressionWithBinary:caseSensitive error:&err];
+ NSString *filter = [ruleFilterController sqlWhereExpressionWithBinary:caseSensitive error:&err];
if(err) {
SPOnewayAlertSheet(
NSLocalizedString(@"Invalid Filter", @"table content : apply filter : invalid filter message title"),
@@ -1256,7 +1256,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
}
// If a button other than the pagination buttons was used, set the active filter type to
// the standard filter field.
- else if (sender == filterControllerInstance) {
+ else if (sender == ruleFilterController) {
activeFilter = SPTableContentFilterSourceRuleFilter;
resetPaging = YES;
}
@@ -1349,12 +1349,12 @@ static void *TableContentKVOContext = &TableContentKVOContext;
{
// we can't change the state of the button here, because the mouse click already changed it
if(show) {
- if([filterControllerInstance isEmpty]) {
- [filterControllerInstance addFilterExpression];
+ if([ruleFilterController isEmpty]) {
+ [ruleFilterController addFilterExpression];
// the sizing will be updated automatically by adding a row
}
else {
- [self updateFilterRuleEditorSize:[filterControllerInstance preferredHeight] animate:animate];
+ [self updateFilterRuleEditorSize:[ruleFilterController preferredHeight] animate:animate];
}
}
else {
@@ -2388,14 +2388,14 @@ static void *TableContentKVOContext = &TableContentKVOContext;
else if(navigateAsHex) filterComparison = @"= (Hex String)";
// Store the filter details to use when loading the target table
- NSDictionary *filterSettings = [SPTableContentFilterController makeSerializedFilterForColumn:[refDictionary objectForKey:@"column"]
+ NSDictionary *filterSettings = [SPRuleFilterController makeSerializedFilterForColumn:[refDictionary objectForKey:@"column"]
operator:filterComparison
values:@[targetFilterValue]];
// If the link is within the current table, apply filter settings manually
if ([[refDictionary objectForKey:@"table"] isEqualToString:selectedTable]) {
SPMainQSync(^{
- [filterControllerInstance restoreSerializedFilters:filterSettings];
+ [ruleFilterController restoreSerializedFilters:filterSettings];
[self setRuleEditorVisible:YES animate:YES];
activeFilter = SPTableContentFilterSourceRuleFilter;
});
@@ -3337,7 +3337,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
*/
- (NSDictionary *) filterSettings
{
- return [filterControllerInstance serializedFilter];
+ return [ruleFilterController serializedFilter];
}
/**
@@ -3445,7 +3445,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
NSRect contentAreaRect = [contentAreaContainer frame];
CGFloat availableHeight = contentAreaRect.size.height;
- NSRect ruleEditorRect = [[[filterControllerInstance view] enclosingScrollView] frame];
+ NSRect ruleEditorRect = [[[ruleFilterController view] enclosingScrollView] frame];
//adjust for the UI elements below the rule editor, but only if the view height should not be 0 (ie. hidden)
CGFloat containerRequestedHeight = requestedHeight ? requestedHeight + ruleEditorRect.origin.y : 0;
@@ -3472,18 +3472,18 @@ static void *TableContentKVOContext = &TableContentKVOContext;
[NSAnimationContext beginGrouping];
[[tableContentContainer animator] setFrame:bottomContainerRect];
[[filterRuleEditorContainer animator] setFrame:topContainerRect];
- [[[[filterControllerInstance view] enclosingScrollView] animator] setFrame:ruleEditorRect];
+ [[[[ruleFilterController view] enclosingScrollView] animator] setFrame:ruleEditorRect];
[NSAnimationContext endGrouping];
}
else {
[tableContentContainer setFrameSize:bottomContainerRect.size];
[filterRuleEditorContainer setFrame:topContainerRect];
- [[[filterControllerInstance view] enclosingScrollView] setFrame:ruleEditorRect];
+ [[[ruleFilterController view] enclosingScrollView] setFrame:ruleEditorRect];
}
//disable rubberband scrolling as long as there is nothing to scroll
if(scrollViewHasRubberbandScrolling) {
- NSScrollView *filterControllerScroller = [[filterControllerInstance view] enclosingScrollView];
+ NSScrollView *filterControllerScroller = [[ruleFilterController view] enclosingScrollView];
if (ruleEditorRect.size.height >= requestedHeight) {
[filterControllerScroller setVerticalScrollElasticity:NSScrollElasticityNone];
} else {
@@ -3495,14 +3495,14 @@ static void *TableContentKVOContext = &TableContentKVOContext;
- (void)filterRuleEditorPreferredSizeChanged:(NSNotification *)notification
{
if(showFilterRuleEditor) {
- [self updateFilterRuleEditorSize:[filterControllerInstance preferredHeight] animate:YES];
+ [self updateFilterRuleEditorSize:[ruleFilterController preferredHeight] animate:YES];
}
}
- (void)contentViewSizeChanged:(NSNotification *)notification
{
if(showFilterRuleEditor) {
- [self updateFilterRuleEditorSize:[filterControllerInstance preferredHeight] animate:NO];
+ [self updateFilterRuleEditorSize:[ruleFilterController preferredHeight] animate:NO];
}
}
@@ -3627,7 +3627,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
[removeButton setEnabled:NO];
[duplicateButton setEnabled:NO];
[reloadButton setEnabled:NO];
- [filterControllerInstance setEnabled:NO];
+ [ruleFilterController setEnabled:NO];
[toggleRuleFilterButton setEnabled:NO];
tableRowsSelectable = NO;
[paginationPreviousButton setEnabled:NO];
@@ -3663,7 +3663,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
}
}
- [filterControllerInstance setEnabled:(!![selectedTable length])];
+ [ruleFilterController setEnabled:(!![selectedTable length])];
[toggleRuleFilterButton setEnabled:(!![selectedTable length])];
tableRowsSelectable = YES;
}
@@ -3931,7 +3931,7 @@ static void *TableContentKVOContext = &TableContentKVOContext;
{
[self setRuleEditorVisible:YES animate:YES];
[toggleRuleFilterButton setState:NSOnState];
- [filterControllerInstance focusFirstInputField];
+ [ruleFilterController focusFirstInputField];
}
#endif