diff options
| author | Max <post@wickenrode.com> | 2015-10-05 02:27:32 +0200 |
|---|---|---|
| committer | Max <post@wickenrode.com> | 2015-10-05 02:27:32 +0200 |
| commit | d4641ec90fe1b50fca0256e26338d955290fd8b7 (patch) | |
| tree | 78a44e25eadd6a3bbc5590d8f4831c8a621a9368 /Source/SPWindowController.h | |
| parent | 80f8cae8ea9db39c1d4d4dee0bd7ae3f756ad62f (diff) | |
| download | sequelpro-d4641ec90fe1b50fca0256e26338d955290fd8b7.tar.gz sequelpro-d4641ec90fe1b50fca0256e26338d955290fd8b7.tar.bz2 sequelpro-d4641ec90fe1b50fca0256e26338d955290fd8b7.zip | |
Trying to fix a range of crashes when closing a connection window
Caused by a use-after-free of an unretained ivar
Diffstat (limited to 'Source/SPWindowController.h')
| -rw-r--r-- | Source/SPWindowController.h | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/Source/SPWindowController.h b/Source/SPWindowController.h index c99a2ff2..a86a85f9 100644 --- a/Source/SPWindowController.h +++ b/Source/SPWindowController.h @@ -49,7 +49,17 @@ // Database connection management - (IBAction)addNewConnection:(id)sender; - (IBAction)moveSelectedTabInNewWindow:(id)sender; + +/** + * @danger THIS IS NOT RETAINED!!! + * + * Ever only directly use it on the main thread! + * Do not cache it without retaining first! + * For background threads get it and retain it via the main thread! + * Release it on the main thread again. + */ - (SPDatabaseDocument *)selectedTableDocument; + - (void)updateSelectedTableDocument; - (void)updateAllTabTitles:(id)sender; - (IBAction)closeTab:(id)sender; |