Various improvements to server capability/version checking, including:

- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811

Other changes include:

- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.

1 files changed, 7 insertions, 1 deletions

diff --git a/Source/SPUserManager.h b/Source/SPUserManager.h
index 97ed03a4..db13fa93 100644
--- a/Source/SPUserManager.h
+++ b/Source/SPUserManager.h
@@ -25,7 +25,7 @@
 #import <Cocoa/Cocoa.h>
 #import <MCPKit/MCPKit.h>
 
-@class BWAnchoredButtonBar;
+@class SPServerSupport, BWAnchoredButtonBar;
 
 @interface SPUserManager : NSWindowController
 {	
@@ -37,6 +37,7 @@
 	BOOL isInitializing;
 	
 	MCPConnection *mySqlConnection;
+	SPServerSupport *serverSupport;
 	
 	IBOutlet NSOutlineView *outlineView;
 	IBOutlet NSTabView *tabView;
@@ -53,6 +54,10 @@
 	IBOutlet NSButton *addSchemaPrivButton;
 	IBOutlet NSButton *removeSchemaPrivButton;
 	
+	IBOutlet NSTextField *maxUpdatesTextField;
+	IBOutlet NSTextField *maxConnectionsTextField;
+	IBOutlet NSTextField *maxQuestionsTextField;
+	
     IBOutlet NSTextField *userNameTextField;
 
 	IBOutlet BWAnchoredButtonBar *splitViewButtonBar;
@@ -66,6 +71,7 @@
 }
 
 @property (nonatomic, retain) MCPConnection *mySqlConnection;
+@property (nonatomic, retain) SPServerSupport *serverSupport;
 @property (nonatomic, retain) NSPersistentStoreCoordinator *persistentStoreCoordinator;
 @property (nonatomic, retain, readonly) NSManagedObjectModel *managedObjectModel;
 @property (nonatomic, retain) NSManagedObjectContext *managedObjectContext;