diff options
| author | rowanbeentje <rowan@beent.je> | 2009-07-13 21:05:51 +0000 |
|---|---|---|
| committer | rowanbeentje <rowan@beent.je> | 2009-07-13 21:05:51 +0000 |
| commit | 778d7280bae1fe413e0b2db799495454ac165c35 (patch) | |
| tree | ca520b830274ee08aaefe2db02d903caa329ac70 /Source/SPTableData.m | |
| parent | 27db10fe504117dd8b4a166dcfc94881528c44c3 (diff) | |
| download | sequelpro-778d7280bae1fe413e0b2db799495454ac165c35.tar.gz sequelpro-778d7280bae1fe413e0b2db799495454ac165c35.tar.bz2 sequelpro-778d7280bae1fe413e0b2db799495454ac165c35.zip | |
Rework data storage and retrieval in TableContent and CustomQuery backing arrays, and make some editable CustomQuery improvements:
- Switch to using arrays for row storage rather than dictionaries. Use the data column index for table column identifiers.
- This fixes Issue #316 and also allows sorting by all custom query result columns using a column index rather than the name
- Offers significant speed and memory advantages: result building is now 2x-3x faster, memory used for results storage is 30-40% lower, and result access is slightly faster. (Note full 2x-3x speed results won't be seen - result fetching and mysql binary work isn't included in the timing)
- No longer need to fetch the first column of data for tables containing only blob types
- Correctly escape strings when editing CustomQuery results
- Rewrite NSArrayObjectAtIndex to use the native CFArrayGetValueAtIndex rather than cached selectors - neater code and I think slightly faster
Diffstat (limited to 'Source/SPTableData.m')
| -rw-r--r-- | Source/SPTableData.m | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/Source/SPTableData.m b/Source/SPTableData.m index fee2e85e..bcd0c2f6 100644 --- a/Source/SPTableData.m +++ b/Source/SPTableData.m @@ -389,6 +389,7 @@ ]; } + [tableColumn setObject:[NSNumber numberWithInt:[tableColumns count]] forKey:@"datacolumnindex"]; [tableColumn setObject:fieldName forKey:@"name"]; // Split the remaining field definition string by spaces and process |