• some improvements for sequelpro://process_id/command/param1/param2 url scheme support

- introduced an unique process ID for each called bash command which will be set for the current SPDatabaseDocument and passed as environment shell variable SP_PROCESS_ID to ensure that such a scheme command will be executed by the correct SPDatabaseDocument, to avoid security issues ie one can authenticate such a sheme command, to enable url scheme process communication based on file shake-hands etc.

1 files changed, 10 insertions, 1 deletions

diff --git a/Source/SPStringAdditions.m b/Source/SPStringAdditions.m
index 9d9d1779..c57ccacb 100644
--- a/Source/SPStringAdditions.m
+++ b/Source/SPStringAdditions.m
@@ -419,8 +419,17 @@
 	NSTask *bashTask = [[NSTask alloc] init];
 	[bashTask setLaunchPath: @"/bin/bash"];
 
+	NSMutableDictionary *theEnv = [NSMutableDictionary dictionary];
+	[theEnv setDictionary:shellEnvironment];
+
+	// Create and set an unique process ID for each SPDatabaseDocument which has to passed
+	// for each sequelpro:// scheme command as user to be able to identify the url scheme command.
+	// Furthermore this id is used to communicate with the called command as file name.
+	NSString *processID = [NSString stringWithNewUUID];
+	[theEnv setObject:processID forKey:@"SP_PROCESS_ID"];
+	[[[[NSApp mainWindow] delegate] selectedTableDocument] setProcessID:processID];
 	if(shellEnvironment != nil && [shellEnvironment isKindOfClass:[NSDictionary class]] && [shellEnvironment count])
-		[bashTask setEnvironment:shellEnvironment];
+		[bashTask setEnvironment:theEnv];
 
 	if(path != nil)
 		[bashTask setCurrentDirectoryPath:path];