Merge outline view branch into trunk.

Adds support for managing and grouping favorites into folders in the connection view and removes the associated favorites management from the preferences window.

NOTE: On first launch your connection favorites will be migrated from Sequel Pro's preference file to a new file in ~/Application Support/Sequel Pro/Data. Your old favorites will remain in the preference file until removed in a future version.

Outstanding known issues:

- Removing a group node with no child favorites presents a warning about also removing the non-existent favorites.
- Starting the application with no favorites, creating a group node then selecting, hides the connection details input. Doesn't support emoty selection.
- Setting the name of a connection, adding it to the favorites and then swicthing to a different connection type, screws with the favorite name.
- The preservation between launches of whether group nodes are collapsed or not is currently not supported.

1 files changed, 0 insertions, 13 deletions

diff --git a/Source/SPSSHTunnel.m b/Source/SPSSHTunnel.m
index aae71891..4839c886 100644
--- a/Source/SPSSHTunnel.m
+++ b/Source/SPSSHTunnel.m
@@ -356,19 +356,6 @@
 	// Launch and run the tunnel
 	[task launch];
 
-	// TODO: The below code doesn't actually appear to work.  We will probably have to switch to system()/exec() for grouped children...
-	// Apply the process group to the child task to ensure it quits with the parent process.
-	// Note that if run from within Xcode, Xcode is the parent process!
-/*	pid_t group = setsid();
-	if (group == -1) group = getpgrp();
-	if(setpgid([task processIdentifier], group) == -1) {
-		connectionState = SPSSH_STATE_IDLE;
-		[task terminate];
-		if (lastError) [lastError release];
-		lastError = [[NSString alloc] initWithFormat:NSLocalizedString(@"The SSH Tunnel could not safely be marked as belonging to Sequel Pro, and so has been shut down for security reasons.  Please try again.\n\n(Error %i)", @"SSH tunnel could not be security marked by Sequel Pro"), errno];
-		if (delegate) [delegate performSelectorOnMainThread:stateChangeSelector withObject:self waitUntilDone:NO];
-	}*/
-
 	// Listen for output
 	[task waitUntilExit];