- With the improved row count support and behaviour, replace the old "Fetch correct row count" preference with a new Table row counts query level (never, only for small tables, always), defaulting to only for small tables - boundary currently set to 5MB. This addresses Issue #500

1 files changed, 6 insertions, 1 deletions

diff --git a/Source/SPPreferenceController.m b/Source/SPPreferenceController.m
index 5d2f7575..1a2fdf41 100644
--- a/Source/SPPreferenceController.m
+++ b/Source/SPPreferenceController.m
@@ -166,7 +166,7 @@
 			@"reloadAfterEditing", SPReloadAfterEditingRow,
 			@"reloadAfterRemoving", SPReloadAfterRemovingRow,
 			@"dontShowBlob", SPLoadBlobsAsNeeded,
-			@"fetchRowCount", SPFetchCorrectRowCount,
+			@"fetchRowCount", @"FetchCorrectRowCount",
 			@"limitRows", SPLimitResults,
 			@"limitRowsValue", SPLimitResultsValue,
 			@"nullValue", SPNullValue,
@@ -288,6 +288,11 @@
 		[prefs setObject:queryFavoritesArray forKey:SPQueryFavorites];
 	}
 
+	// For versions prior to r1636 (<0.9.8), remove the old "Fetch correct row count" pref
+	if (recordedVersionNumber < 1636 && [prefs objectForKey:@"FetchCorrectRowCount"]) {
+		[prefs removeObjectForKey:@"FetchCorrectRowCount"];
+	}
+
 	// Update the prefs revision
 	[prefs setObject:[NSNumber numberWithInt:currentVersionNumber] forKey:SPLastUsedVersion];	
 }