aboutsummaryrefslogtreecommitdiffstats
path: root/config
diff options
context:
space:
mode:
authordoktornotor <notordoktor@gmail.com>2015-09-09 11:14:00 +0200
committerdoktornotor <notordoktor@gmail.com>2015-09-09 11:14:00 +0200
commitf2a93f5c0e2b160882607e4a4b646a64faf5def4 (patch)
tree340fe7a1d72f6da7e29dc8f47409d3d17e9779f4 /config
parenta10decb034a9860173709071cab8cba78c8c5ca6 (diff)
downloadpfsense-packages-f2a93f5c0e2b160882607e4a4b646a64faf5def4.tar.gz
pfsense-packages-f2a93f5c0e2b160882607e4a4b646a64faf5def4.tar.bz2
pfsense-packages-f2a93f5c0e2b160882607e4a4b646a64faf5def4.zip
Squid3 - squid pinger helper needs to be suid root (Bug #5114)
Diffstat (limited to 'config')
-rwxr-xr-xconfig/squid3/34/squid.inc11
1 files changed, 6 insertions, 5 deletions
diff --git a/config/squid3/34/squid.inc b/config/squid3/34/squid.inc
index 57527876..f0eea327 100755
--- a/config/squid3/34/squid.inc
+++ b/config/squid3/34/squid.inc
@@ -306,9 +306,10 @@ function squid_install_command() {
update_status("Creating squid cache pools... One moment please...");
squid_dash_z();
- /* make sure pinger is executable */
+ /* make sure pinger is executable and suid root */
+ // XXX: Bug #5114
if (file_exists(SQUID_LOCALBASE. "/libexec/squid/pinger"))
- @chmod(SQUID_LOCALBASE. "/libexec/squid/pinger", 0755);
+ @chmod(SQUID_LOCALBASE. "/libexec/squid/pinger", 4755);
// XXX: Is it really necessary?
if (file_exists("/usr/local/etc/rc.d/squid"))
@@ -1876,10 +1877,10 @@ function squid_resync($via_rpc="no") {
// write config file
file_put_contents(SQUID_CONFFILE, $conf);
- /* make sure pinger is executable */
- // XXX: Is it really necessary? Who could change its permission?
+ /* make sure pinger is executable and suid root */
+ // XXX: Bug #5114
if (file_exists(SQUID_LOCALBASE . "/libexec/squid/pinger"))
- @chmod(SQUID_LOCALBASE. "/libexec/squid/pinger", 0755);
+ @chmod(SQUID_LOCALBASE. "/libexec/squid/pinger", 4755);
$log_dir="";
// check if squid is enabled