fix XMLRPC sync, cleanup useless junk

1 files changed, 9 insertions, 27 deletions

diff --git a/config/tinydns/tinydns.xml b/config/tinydns/tinydns.xml
index 55ee3269..fef6e949 100644
--- a/config/tinydns/tinydns.xml
+++ b/config/tinydns/tinydns.xml
@@ -44,7 +44,7 @@
 	]]>
 	</copyright>
 	<name>tinydns</name>
-	<version>1.0</version>
+	<version>1.0.6.24</version>
 	<title>DNS Server: Settings</title>
 	<aftersaveredirect>/pkg_edit.php?xml=tinydns.xml&amp;id=0</aftersaveredirect>
 	<include_file>/usr/local/pkg/tinydns.inc</include_file>
@@ -59,13 +59,13 @@
 		<rcfile>svscan.sh</rcfile>
 		<executable>svscan</executable>
 		<description>Daemontools service directory watcher</description>
-	</service>	
+	</service>
 	<service>
 		<name>DNS Server</name>
 		<rcfile>tinydns.sh</rcfile>
 		<executable>tinydns</executable>
 		<description>TinyDNS DNS Server</description>
-	</service>	
+	</service>
 	<tabs>
 		<tab>
 			<text>Settings</text>
@@ -99,10 +99,6 @@
 		<item>https://packages.pfsense.org/packages/config/tinydns/tinydns.inc</item>
 	</additional_files_needed>
 	<additional_files_needed>
-		<prefix>/usr/local/pkg/pf/</prefix>
-		<item>https://packages.pfsense.org/packages/config/tinydns/tinydns_xmlrpc_sync.php</item>
-	</additional_files_needed>
-	<additional_files_needed>
 		<prefix>/usr/local/pkg/</prefix>
 		<item>https://packages.pfsense.org/packages/config/tinydns/tinydns_domains.xml</item>
 	</additional_files_needed>
@@ -149,8 +145,7 @@
 		<field>
 			<type>listtopic</type>
 			<name>Binding IP Address</name>
-			<fieldname>temp</fieldname>			
-		</field>		
+		</field>
 		<field>
 			<fielddescr>IP Address</fielddescr>
 			<fieldname>ipaddress</fieldname>
@@ -160,8 +155,7 @@
 		<field>
 			<type>listtopic</type>
 			<name>Recursive DNS Resolver</name>
-			<fieldname>temp</fieldname>						
-		</field>		
+		</field>
 		<field>
 		 	<fielddescr>Enable recursive DNS responder</fielddescr>
 			<fieldname>enableforwarding</fieldname>
@@ -197,7 +191,6 @@
 		<field>
 			<type>listtopic</type>
 			<name>IP Monitoring</name>
-			<fieldname>temp</fieldname>
 		</field>
 		<field>
 			<fielddescr>Enable IP monitoring</fielddescr>
@@ -214,18 +207,10 @@
 		<field>
 			<type>listtopic</type>
 			<name>Sync TinyDNS settings via XMLRPC</name>
-			<fieldname>temp</fieldname>
-		</field>
-		<field>
-			<fielddescr>XMLRPC Sync</fielddescr>
-			<fieldname>syncxmlrpc</fieldname>
-			<description>Sync TinyDNS configuration to backup firewalls</description>
-			<type>checkbox</type>
 		</field>
 		<field>
 			<type>listtopic</type>
 			<name>Zone transfers</name>
-			<fieldname>temp</fieldname>
 		</field>
 		<field>
 			<fielddescr>Hosts allowed to perform DNS Zone Transfers - Note: this requires TCP port 53 firewall permit rule!</fielddescr>
@@ -245,7 +230,7 @@
 					<description>Enter the DNS zone that this IP address is allowed to transfer (ex: domain.com)</description>
 					<type>input</type>
 					<size>20</size>
-				</rowhelperfield>			
+				</rowhelperfield>
 			</rowhelper>
 		</field>
 	</fields>
@@ -254,7 +239,7 @@
 		tinydns_custom_php_install_command();
 		tinydns_create_zone_file();
 		tinydns_setup_ping_items();
-		tinydns_sync_on_changes();		
+		tinydns_sync_on_changes();
 	</custom_delete_php_command>
 	<custom_php_validation_command>
 		tinydns_validate();
@@ -264,26 +249,23 @@
 		tinydns_custom_php_install_command();
 		tinydns_create_zone_file();
 		tinydns_setup_ping_items();
-		tinydns_sync_on_changes();		
+		tinydns_sync_on_changes();
 	</custom_add_php_command>
 	<custom_php_resync_config_command>
 		tinydns_custom_php_changeip_command();
 		tinydns_custom_php_install_command();
 		tinydns_create_zone_file();
 		tinydns_setup_ping_items();
-		tinydns_sync_on_changes();		
+		tinydns_sync_on_changes();
 	</custom_php_resync_config_command>
 	<custom_php_install_command>
 		tinydns_custom_php_install_command();
-		tinydns_sync_on_changes();		
 	</custom_php_install_command>
 	<custom_php_deinstall_command>
 		tinydns_custom_php_deinstall_command();
-		tinydns_sync_on_changes();		
 	</custom_php_deinstall_command>
 	<custom_php_command_before_form>
 		<![CDATA[
-		unset($_POST['temp']);
 		if (!is_process_running("svscan")) {
 			$savemsg = "NOTE: svscan is not running. Please <a href='/status_services.php?mode=restartservice&service=svscan'>start svscan</a> to bring up the DNS Server";
 		}