From 465ebcfd614ff0623c67983fb960d334fb0c2ccc Mon Sep 17 00:00:00 2001 From: Bibiko Date: Fri, 15 Jan 2010 09:36:16 +0000 Subject: =?UTF-8?q?=E2=80=A2=20removed=20from=20each=20open=20panel:=20[pa?= =?UTF-8?q?nel=20setResolvesAliases:YES]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For some reasons it could happen that the panel didn't response to dragging files into it correctly and sometimes SP crashed after selecting a directory in its sidebar. By removing "resolve aliases" the panel seems to work properly. This has to be verified by further tests. --- Source/SPAppController.m | 5 ++++- Source/SPContentFilterManager.m | 2 +- Source/SPQueryFavoriteManager.m | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) (limited to 'Source') diff --git a/Source/SPAppController.m b/Source/SPAppController.m index 4421f624..490edac3 100644 --- a/Source/SPAppController.m +++ b/Source/SPAppController.m @@ -134,7 +134,10 @@ [panel setDelegate:self]; [panel setCanChooseDirectories:NO]; [panel setAllowsMultipleSelection:YES]; - [panel setResolvesAliases:YES]; + // TODO: it seems that setting setResolvesAliases to YES causes some + // problems in dragging files to the panel and changing to directory could crash SP + // ask Hans for details + // [panel setResolvesAliases:YES]; // If no lastSqlFileEncoding in prefs set it to UTF-8 if(![[NSUserDefaults standardUserDefaults] integerForKey:SPLastSQLFileEncoding]) { diff --git a/Source/SPContentFilterManager.m b/Source/SPContentFilterManager.m index e1d7e389..34a3b214 100644 --- a/Source/SPContentFilterManager.m +++ b/Source/SPContentFilterManager.m @@ -318,7 +318,7 @@ [panel setDelegate:self]; [panel setCanChooseDirectories:NO]; [panel setAllowsMultipleSelection:NO]; - [panel setResolvesAliases:YES]; + // [panel setResolvesAliases:YES]; [panel beginSheetForDirectory:nil file:@"" diff --git a/Source/SPQueryFavoriteManager.m b/Source/SPQueryFavoriteManager.m index ef458c87..2745f83c 100644 --- a/Source/SPQueryFavoriteManager.m +++ b/Source/SPQueryFavoriteManager.m @@ -322,7 +322,7 @@ [panel setDelegate:self]; [panel setCanChooseDirectories:NO]; [panel setAllowsMultipleSelection:NO]; - [panel setResolvesAliases:YES]; + // [panel setResolvesAliases:YES]; [panel beginSheetForDirectory:nil file:@"" -- cgit v1.2.3