From 10316c1a2e8448e5dd93a1d10c7e039115864925 Mon Sep 17 00:00:00 2001 From: Bibiko Date: Fri, 19 Feb 2010 14:43:01 +0000 Subject: =?UTF-8?q?=E2=80=A2=20added=20the=20chance=20to=20the=20user-defi?= =?UTF-8?q?ned=20Content=20Filter=20Editor=20to=20specify=20whether=20the?= =?UTF-8?q?=20leading=20=20placeholder=20should=20be=20suppressed?= =?UTF-8?q?=20or=20not=20in=20order=20to=20be=20able=20to=20write=20a=20fi?= =?UTF-8?q?lter=20like=20"LENGTH($CURRENT=5FFIELD)>${}"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Source/SPContentFilterManager.h | 2 ++ Source/SPContentFilterManager.m | 7 +++++- Source/TableContent.m | 55 ++++++++++++++++++++++++++++------------- 3 files changed, 46 insertions(+), 18 deletions(-) (limited to 'Source') diff --git a/Source/SPContentFilterManager.h b/Source/SPContentFilterManager.h index f8ffe16e..7c6525ba 100644 --- a/Source/SPContentFilterManager.h +++ b/Source/SPContentFilterManager.h @@ -49,6 +49,7 @@ IBOutlet id resultingClauseLabel; IBOutlet id resultingClauseContentLabel; IBOutlet id insertPlaceholderButton; + IBOutlet id suppressLeadingFiledPlaceholderCheckbox; IBOutlet BWAnchoredButtonBar *splitViewButtonBar; @@ -75,5 +76,6 @@ - (IBAction)exportContentFilter:(id)sender; - (IBAction)importContentFilterByAdding:(id)sender; - (IBAction)closeContentFilterManagerSheet:(id)sender; +- (IBAction)suppressLeadingFiledPlaceholderWasChanged:(id)sender; @end diff --git a/Source/SPContentFilterManager.m b/Source/SPContentFilterManager.m index 8e3fa5fe..8e79cc8e 100644 --- a/Source/SPContentFilterManager.m +++ b/Source/SPContentFilterManager.m @@ -533,6 +533,11 @@ } +- (IBAction)suppressLeadingFiledPlaceholderWasChanged:(id)sender +{ + [contentFilterTextView insertText:@""]; +} + /* * Parse clause and update labels accordingly */ @@ -568,7 +573,7 @@ [c flushCachedRegexData]; [c replaceOccurrencesOfRegex:@"(?"]; [c flushCachedRegexData]; - [resultingClauseContentLabel setStringValue:[NSString stringWithFormat:@" %@", c]]; + [resultingClauseContentLabel setStringValue:[NSString stringWithFormat:@"%@%@", ([suppressLeadingFiledPlaceholderCheckbox state] == NSOnState) ? @"" : @" ", c]]; [c release]; } diff --git a/Source/TableContent.m b/Source/TableContent.m index 50bcfd9f..da6577cb 100644 --- a/Source/TableContent.m +++ b/Source/TableContent.m @@ -809,6 +809,10 @@ NSUInteger numberOfArguments = [[filter objectForKey:@"NumberOfArguments"] integerValue]; + BOOL suppressLeadingTablePlaceholder = NO; + if([filter objectForKey:@"SuppressLeadingFieldPlaceholder"]) + suppressLeadingTablePlaceholder = YES; + // argument if Filter requires only one argument NSMutableString *argument = [[NSMutableString alloc] initWithString:[argumentField stringValue]]; @@ -870,24 +874,41 @@ } // Construct the filter string according the required number of arguments - if (numberOfArguments == 2) { - filterString = [NSString stringWithFormat:@"%@ %@", - [[fieldField titleOfSelectedItem] backtickQuotedString], - [NSString stringWithFormat:clause, - [self escapeFilterArgument:firstBetweenArgument againstClause:clause], - [self escapeFilterArgument:secondBetweenArgument againstClause:clause]]]; - } else if (numberOfArguments == 1) { - filterString = [NSString stringWithFormat:@"%@ %@", - [[fieldField titleOfSelectedItem] backtickQuotedString], - [NSString stringWithFormat:clause, [self escapeFilterArgument:argument againstClause:clause]]]; + + if(suppressLeadingTablePlaceholder) { + if (numberOfArguments == 2) { + filterString = [NSString stringWithFormat:clause, + [self escapeFilterArgument:firstBetweenArgument againstClause:clause], + [self escapeFilterArgument:secondBetweenArgument againstClause:clause]]; + } else if (numberOfArguments == 1) { + filterString = [NSString stringWithFormat:clause, [self escapeFilterArgument:argument againstClause:clause]]; + } else { + filterString = [NSString stringWithString:[filter objectForKey:@"Clause"]]; + if(numberOfArguments > 2) { + NSLog(@"Filter with more than 2 arguments is not yet supported."); + NSBeep(); + } + } } else { - filterString = [NSString stringWithFormat:@"%@ %@", - [[fieldField titleOfSelectedItem] backtickQuotedString], - [filter objectForKey:@"Clause"]]; - if(numberOfArguments > 2) { - NSLog(@"Filter with more than 2 arguments is not yet supported."); - NSBeep(); - } + if (numberOfArguments == 2) { + filterString = [NSString stringWithFormat:@"%@ %@", + [[fieldField titleOfSelectedItem] backtickQuotedString], + [NSString stringWithFormat:clause, + [self escapeFilterArgument:firstBetweenArgument againstClause:clause], + [self escapeFilterArgument:secondBetweenArgument againstClause:clause]]]; + } else if (numberOfArguments == 1) { + filterString = [NSString stringWithFormat:@"%@ %@", + [[fieldField titleOfSelectedItem] backtickQuotedString], + [NSString stringWithFormat:clause, [self escapeFilterArgument:argument againstClause:clause]]]; + } else { + filterString = [NSString stringWithFormat:@"%@ %@", + [[fieldField titleOfSelectedItem] backtickQuotedString], + [filter objectForKey:@"Clause"]]; + if(numberOfArguments > 2) { + NSLog(@"Filter with more than 2 arguments is not yet supported."); + NSBeep(); + } + } } [argument release]; -- cgit v1.2.3