From c7362cc8c6d3c02d8e9b5f5a31735bb3fbbf0b02 Mon Sep 17 00:00:00 2001 From: Max Date: Fri, 26 Dec 2014 20:37:39 +0100 Subject: ************** IMPORTANT: SEE BELOW ************** MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change should fix the "slow CSV import dialog" issue on 10.10 (details below). To accomplish that, some major changes had to be made to the CSV import code. PLEASE VERIFY THE CORRECTNESS OF THE NEXT FEW CSV IMPORTS YOU DO! * Renamed some variables for better search visibility * Changed some instances where NSNumbers were being compared using "==" instead of "isEqual…" (does not work with object literals!) * The CSV import dialog would recreate the popup menus on *every* call to "tableView:objectValueFor…". However Instruments suggests that [NSMenu removeAllItems] and [NSMenu addItemsWithTitles:] are **really** expensive, esp. when called multiple times per second (e.g. when scrolling in the table view). This commit moves the popup menu setup into its own method and only calls it when the data actually changes. * The 'destination table column' was for some reason a NSPopupButtonCell which only ever had one item and sometimes got changed to a NSTextFieldCell in code. I didn't see any need to keep the popup cell and replaced it with a simple text cell. --- Interfaces/English.lproj/DataMigrationDialog.xib | 220 ++++++++++++++--------- 1 file changed, 137 insertions(+), 83 deletions(-) (limited to 'Interfaces/English.lproj/DataMigrationDialog.xib') diff --git a/Interfaces/English.lproj/DataMigrationDialog.xib b/Interfaces/English.lproj/DataMigrationDialog.xib index c6afb178..740dedcb 100644 --- a/Interfaces/English.lproj/DataMigrationDialog.xib +++ b/Interfaces/English.lproj/DataMigrationDialog.xib @@ -78,11 +78,13 @@ {{1, 1}, {656, 0}} + {{-12, 53}, {658, 2}} + {0, 0} 67108864 @@ -131,6 +133,7 @@ {{14, 12}, {604, 17}} + YES 68157504 @@ -170,6 +173,7 @@ {{512, 51}, {226, 32}} + YES 67108864 @@ -192,6 +196,7 @@ {{664, 1}, {226, 32}} + YES 67108864 @@ -214,6 +219,7 @@ {{668, 1}, {226, 32}} + YES 67108864 @@ -234,11 +240,13 @@ {{1, 1}, {634, 39}} + {{-1, 308}, {636, 41}} + {0, 0} 67108864 @@ -275,6 +283,7 @@ {634, 126} + YES NO YES @@ -284,6 +293,7 @@ {634, 17} + @@ -292,6 +302,7 @@ {{-22, 0}, {12, 17}} + @@ -326,32 +337,32 @@ 400 75 - - - Pop Up - - 1048576 - 2147483647 - 1 - - NSImage - NSMenuCheckmark - - - NSImage - NSMenuMixedState - - _popUpItemAction: - - + YES OtherViews - + + + Pop Up + + 1048576 + 2147483647 + + NSImage + NSMenuCheckmark + + + NSImage + NSMenuMixedState + + _popUpItemAction: + + + -1 3 YES YES @@ -429,42 +440,15 @@ - - -2076180416 - 133120 + + 337641537 + 272762880 + Text + _NS:9 - 100679680 - 129 - - - 400 - 75 - - - YES - Pop Up - - 1048576 - 2147483647 - 1 - - - _popUpItemAction: - - - YES - - OtherViews - - - - - - YES - 3 - YES - YES + + 3 YES @@ -570,6 +554,7 @@ {{413, 18}, {11, 140}} + NO 256 @@ -582,6 +567,7 @@ {{-100, -100}, {227, 11}} + NO 257 @@ -594,7 +580,7 @@ {{-1, 129}, {636, 144}} - + 133650 @@ -612,6 +598,7 @@ {{415, 12}, {102, 32}} + YES 67108864 @@ -664,6 +651,7 @@ {{20, 19}, {32, 24}} + YES 603979776 @@ -690,6 +678,7 @@ {{51, 19}, {32, 24}} + 1 YES @@ -718,6 +707,7 @@ {{88, 23}, {195, 14}} + YES 67108928 @@ -737,6 +727,7 @@ {{361, 278}, {200, 22}} + YES -2076180416 @@ -769,6 +760,7 @@ {{484, 97}, {133, 22}} + YES -2076180416 @@ -834,6 +826,7 @@ {{302, 102}, {180, 14}} + YES 68157504 @@ -857,6 +850,7 @@ {{5, 280}, {316, 20}} + YES 69206081 @@ -879,6 +873,7 @@ {{17, 100}, {275, 18}} + YES -2080374784 @@ -908,6 +903,7 @@ {{484, 73}, {133, 22}} + YES -2076180416 @@ -991,6 +987,7 @@ {{302, 79}, {180, 14}} + YES 68157504 @@ -1010,6 +1007,7 @@ {{326, 12}, {82, 32}} + YES 67108864 @@ -1032,6 +1030,7 @@ {{11, 56}, {29, 26}} + YES 67108864 @@ -1059,6 +1058,7 @@ {{17, 8}, {100, 18}} + YES 67108864 @@ -1083,6 +1083,7 @@ {{132, 8}, {80, 18}} + 1 YES @@ -1106,6 +1107,7 @@ {{200, 20}, {230, 44}} + NSView @@ -1118,6 +1120,7 @@ {{227, 62}, {335, 18}} + YES -2080374784 @@ -1169,6 +1172,7 @@ {400, 37} + @@ -1257,6 +1261,7 @@ {{386, 1}, {15, 37}} + NO 512 @@ -1270,6 +1275,7 @@ {{-100, -100}, {87, 15}} + NO 513 @@ -1281,7 +1287,7 @@ {{20, 20}, {402, 39}} - + 133650 @@ -1296,6 +1302,7 @@ {{227, 85}, {104, 18}} + YES 67108864 @@ -1320,6 +1327,7 @@ {{17, 85}, {100, 18}} + YES 67108864 @@ -1344,6 +1352,7 @@ {{17, 62}, {181, 18}} + 2 YES @@ -1369,6 +1378,7 @@ {{137, 85}, {80, 18}} + 1 YES @@ -1394,6 +1404,7 @@ {{354, 85}, {70, 18}} + YES 67108864 @@ -1416,6 +1427,7 @@ {{93, -57}, {442, 121}} + NSView @@ -1428,6 +1440,7 @@ {{212, 8}, {335, 18}} + YES 67108864 @@ -1452,6 +1465,7 @@ {{17, 8}, {100, 18}} + YES 67108864 @@ -1476,6 +1490,7 @@ {{132, 8}, {70, 18}} + YES 67108864 @@ -1498,6 +1513,7 @@ {{110, 20}, {390, 44}} + NSView @@ -1506,6 +1522,7 @@ {{34, 58}, {58, 23}} + YES -2080374784 @@ -1528,6 +1545,7 @@ {{487, 280}, {106, 19}} + YES -1804599231 @@ -1553,6 +1571,7 @@ {{402, 283}, {80, 14}} + YES 68157504 @@ -1572,6 +1591,7 @@ {{599, 280}, {20, 20}} + YES 67108864 @@ -1598,6 +1618,7 @@ {{566, 281}, {61, 17}} + YES -2080374784 @@ -1618,8 +1639,9 @@ {634, 348} + - {{0, 0}, {1440, 878}} + {{0, 0}, {1920, 1178}} {634, 370} {10000000000000, 10000000000000} SPCSVFieldMappingSheet @@ -2031,7 +2053,7 @@ {311, 210} - {{0, 0}, {1440, 878}} + {{0, 0}, {1920, 1178}} {311, 208} {10000000000000, 10000000000000} @@ -2339,7 +2361,7 @@ {269, 120} - {{0, 0}, {1440, 878}} + {{0, 0}, {1920, 1178}} {269, 142} {269, 142} YES @@ -3068,6 +3090,14 @@ 427 + + + delegate + + + + 9Jp-DU-vql + delegate @@ -4156,7 +4186,7 @@ 48 - + @@ -4173,27 +4203,6 @@ - - 92 - - - - - - - - 93 - - - - - - - - 94 - - - 89 @@ -4290,6 +4299,11 @@ + + 1SY-mK-knt + + + @@ -4405,6 +4419,7 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin ToolTip @@ -4600,9 +4615,6 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -7445,6 +7457,7 @@ id NSPopUpButton id + SPTableContentFilterController NSButton NSButton NSButton @@ -7524,6 +7537,10 @@ filterButton id + + filterControllerInstance + SPTableContentFilterController + filterTableClearButton NSButton @@ -7774,6 +7791,43 @@ ../Source/SPTableContent.m + + SPTableContentFilterController + NSObject + + SPSplitView + NSRuleEditor + SPTableData + SPDatabaseDocument + SPTablesList + + + + contentSplitView + SPSplitView + + + filterRuleEditor + NSRuleEditor + + + tableDataInstance + SPTableData + + + tableDocumentInstance + SPDatabaseDocument + + + tablesListInstance + SPTablesList + + + + IBProjectSource + ../Source/SPTableContentFilterController.h + + SPTableData NSObject -- cgit v1.2.3