From fd3b64dfbbc445d52961784176eec8572f2c7880 Mon Sep 17 00:00:00 2001 From: rowanbeentje Date: Sat, 21 Jan 2012 18:46:25 +0000 Subject: - Make SPConnectionController a NSConnectionView subclass so that retain cycles caused by manually loading libs with bindings to File's Owner are automatically handled, fixing leaks of SPConnectionController and items it retain including any MCPConnection; this will fix issues with MCPConnections attempting to reconnect but no longer having an associated SPDatabaseDocument --- Frameworks/MCPKit/MCPFoundationKit/MCPConnection.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Frameworks') diff --git a/Frameworks/MCPKit/MCPFoundationKit/MCPConnection.m b/Frameworks/MCPKit/MCPFoundationKit/MCPConnection.m index 2c4f424d..04dcf50d 100644 --- a/Frameworks/MCPKit/MCPFoundationKit/MCPConnection.m +++ b/Frameworks/MCPKit/MCPFoundationKit/MCPConnection.m @@ -3255,7 +3255,7 @@ void pingThreadCleanup(void *pingDetails) delegate = nil; // Ensure the query lock is unlocked, thereafter setting to nil in case of pending calls - [self unlockConnection]; + if ([connectionLock condition] != MCPConnectionIdle) [self unlockConnection]; [connectionLock release], connectionLock = nil; // Clean up connections if necessary -- cgit v1.2.3