From d8373245efdb63f4f8a27bdc646053f7b939f2f2 Mon Sep 17 00:00:00 2001 From: rowanbeentje Date: Fri, 2 Apr 2010 15:22:26 +0000 Subject: - Initialise prefs controller before setting Sparkle delegate - Move sparkle prefs reset from 2056 to 2057 - Tweak prefs key binding to the user preference stats enabled key rather than the overall Sparkle stats enabled key --- Interfaces/English.lproj/Preferences.xib | 23 ++++++++++++----------- Source/SPAppController.m | 10 ++++++---- Source/SPPreferenceController.m | 4 ++-- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/Interfaces/English.lproj/Preferences.xib b/Interfaces/English.lproj/Preferences.xib index 4c1f5013..93d00394 100644 --- a/Interfaces/English.lproj/Preferences.xib +++ b/Interfaces/English.lproj/Preferences.xib @@ -16,7 +16,7 @@ YES 740 - 1.2.2 + 1.2.5 @@ -25,8 +25,8 @@ YES - com.brandonwalkin.BWToolkit com.apple.InterfaceBuilder.CocoaPlugin + com.brandonwalkin.BWToolkit YES @@ -56,7 +56,7 @@ Preferences NSWindow - {3.40282e+38, 3.40282e+38} + {1.79769e+308, 1.79769e+308} {500, 0} @@ -65,7 +65,7 @@ {{0, 0}, {1920, 1178}} {500, 22} - {3.40282e+38, 3.40282e+38} + {1.79769e+308, 1.79769e+308} @@ -454,7 +454,7 @@ controlColor 3 - MC42NjY2NjY2ODY1AA + MC42NjY2NjY2NjY3AA @@ -4204,6 +4204,7 @@ AQAAAAA YES + SUSendProfileInfo SUEnableAutomaticChecks YES @@ -6550,19 +6551,19 @@ AQAAAAA - value: values.SUEnableSystemProfiling + value: values.SUSendProfileInfo - value: values.SUEnableSystemProfiling + value: values.SUSendProfileInfo value - values.SUEnableSystemProfiling + values.SUSendProfileInfo 2 - 1619 + 1624 @@ -6578,7 +6579,7 @@ AQAAAAA 2 - 1622 + 1625 @@ -10476,7 +10477,7 @@ AQAAAAA - 1622 + 1625 diff --git a/Source/SPAppController.m b/Source/SPAppController.m index 9fc4b7b1..f0d4c9bf 100644 --- a/Source/SPAppController.m +++ b/Source/SPAppController.m @@ -62,12 +62,14 @@ */ - (void)awakeFromNib { - // Set Sparkle delegate - [[SUUpdater sharedUpdater] setDelegate:self]; - + + // Set up the prefs controller prefsController = [[SPPreferenceController alloc] init]; aboutController = nil; - + + // Set Sparkle delegate + [[SUUpdater sharedUpdater] setDelegate:self]; + // Register SPAppController as services provider [NSApp setServicesProvider:self]; diff --git a/Source/SPPreferenceController.m b/Source/SPPreferenceController.m index 3bbc42a2..20173b32 100644 --- a/Source/SPPreferenceController.m +++ b/Source/SPPreferenceController.m @@ -303,8 +303,8 @@ [prefs removeObjectForKey:@"FetchCorrectRowCount"]; } - // For versions prior to r2056 (~0.9.8), reset the Sparkle prefs so the user is prompted about submitting information - if (recordedVersionNumber < 2056 && [prefs objectForKey:@"SUEnableAutomaticChecks"]) { + // For versions prior to r2057 (~0.9.8), reset the Sparkle prefs so the user is prompted about submitting information + if (recordedVersionNumber < 2057 && [prefs objectForKey:@"SUEnableAutomaticChecks"]) { [prefs removeObjectForKey:@"SUEnableAutomaticChecks"]; [prefs removeObjectForKey:@"SUSendProfileInfo"]; } -- cgit v1.2.3