From 6af633648d5d145393e39af9a62d3582d5fa543f Mon Sep 17 00:00:00 2001 From: stuconnolly Date: Tue, 20 Apr 2010 12:04:53 +0000 Subject: Fix an issue whereby choosing to edit the selected favourite in the connection view would select the wrong favourite in the preferences because sorting has been applied to the table view. --- Source/SPConnectionController.m | 3 ++- Source/SPPreferenceController.h | 1 - Source/SPPreferenceController.m | 11 ----------- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/Source/SPConnectionController.m b/Source/SPConnectionController.m index ecfd6bc4..9d646278 100644 --- a/Source/SPConnectionController.m +++ b/Source/SPConnectionController.m @@ -521,7 +521,8 @@ [prefsController showWindow:self]; [prefsController displayFavoritePreferences:self]; - if ([favoritesTable numberOfSelectedRows]) [prefsController selectFavoriteAtIndex:([favoritesTable selectedRow] - 1)]; + + if ([favoritesTable numberOfSelectedRows]) [prefsController selectFavorites:[NSArray arrayWithObject:[self valueForKeyPath:@"selectedFavorite"]]]; } /** diff --git a/Source/SPPreferenceController.h b/Source/SPPreferenceController.h index 9a6b3101..6d72fc1d 100644 --- a/Source/SPPreferenceController.h +++ b/Source/SPPreferenceController.h @@ -113,7 +113,6 @@ // Other - (void)updateDefaultFavoritePopup; - (void)selectFavorites:(NSArray *)favorite; -- (void)selectFavoriteAtIndex:(NSUInteger)theIndex; - (void)changeFont:(id)sender; - (IBAction)favoriteTypeDidChange:(id)sender; - (void)updateFavoritePasswordsFromField:(NSControl *)passwordControl; diff --git a/Source/SPPreferenceController.m b/Source/SPPreferenceController.m index 2826b0e8..d068064a 100644 --- a/Source/SPPreferenceController.m +++ b/Source/SPPreferenceController.m @@ -1106,17 +1106,6 @@ [favoritesTableView scrollRowToVisible:[favoritesController selectionIndex]]; } -// ------------------------------------------------------------------------------- -// selectFavoriteAtIndex: -// -// Selects the favorite at the specified index in the favorites list -// ------------------------------------------------------------------------------- -- (void)selectFavoriteAtIndex:(NSUInteger)theIndex -{ - [favoritesController setSelectionIndex:theIndex]; - [favoritesTableView scrollRowToVisible:theIndex]; -} - // ------------------------------------------------------------------------------- // global table font selection // ------------------------------------------------------------------------------- -- cgit v1.2.3