| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
| |
the damage caused by r333, making views viewable again, and extends support by preventing errors in the info pane, by drawing views with a different icon to easily differentiate them, by making all source/index information non-editable to match GUI to behaviour, and to tweak the interface slightly to match.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appropriately - offering to retry, reconnect, or disconnect. This fixes Issue #93, Issue #69, and Issue #77.
The gory details:
Previously, MCPKit was correctly running mysql_ping to ensure a connection still existed before running a query, and aborted the query if the connection was no longer active.However the code very rarely checked the response of this, so if a query failed subsequent queries would continue to be run and the program would end up checking non-existent results, throwing Cocoa exceptions and generally breaking. However, mysql_ping would also use the default timeout (30 seconds) for each check - when running the (previous to r333) 14 queries to switch tables, this resulted in a long hang before the program even broke.
To exacerbate the issue, certain situations triggered a bug present in mysql_ping in the old client binaries we're using (http://bugs.mysql.com/bug.php?id=9678), causing mysql_ping to never return despite the presence of a timeout, and so causing an indefinite hang.
This issue has been fixed by:
- Setting a new 10 second connection timeout for both new connections (Issue #69) and for mysql_pings. Once preferences have been redesigned we'll probably make this value editable.
- Enforce the 10 second timeout even if mysql_ping hangs by using interrupts.
- Wrap mysql_ping in a new method to do the above and also catch re-established connections without reporting false failures.
- When a connection has failed, prompt the user to Retry, Reconnect, or Disconnect. Reconnect uses the original details for the old connection to establish a new connection, also attempting to preserve the current encoding.
- Do not return control to the main loop until a connection has been reestablished (or disconnected) - this ensures the program is never in a broken state without having to rewrite all query usage.
Much of the above patches the MCPKit connection methods as necessary.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Significantly reduce the queries that have to be performed, improving lag - especially over slow connections (Issue #118; see new controller info under headline code changes).
- Fix Issue #117 properly (export numeric quoting - we now have access to column types and so can quote appropriately).
- Fix Issue #145 (loss of unsigned/null/default attributes when reordering columns).
- Fixes Issue #90 (support for filtering DECIMAL column types)
- Improve table scrolling speed when the table contains long items. (Added a NSFormatter to automatically truncate strings > 150 chars for display purposes only)
- Improved SQL compatibility - for example /* C style comments */ are now correctly ignored in imports and custom queries.
- Add text and symbols emphasising that the table info pane / status view row count is an approximation (partially addresses Issue #141)
- Fixes a major memory leak whenever opening or scrolling tables containing text/blob data.
- SQL import is now faster (SQL parsing part is 3x faster).
- Speed up SQL export (1.5x faster for numeric data; 1.1x faster for string data) and slightly speed up CSV export (~1.1x faster).
- Display sizes on the status view using the byte size formatter, as per table info pane.
Headline code changes:
- Add a new NSMutableString subclass, SPSQLParser. See the header file for documentation and overview, but in short it's a centralised place for SQL parsing. Centralises and improves parsing, improves comment support, improves quoting support. Despite the improved featureset this is also faster than the previous distributed implementations - for example, when used to replace the old splitQueries:, > 3x speedup.
- Implement a new controller which handles a structure and status cache for the current table, and provides structure parsing for specified tables. This cache is now used throughout the code, reducing the queries that have to be performed and providing additional information about the table structure for use; I think it also improves column type format slightly.
- The table info pane and the status view now draw all their data from the cache.
Tweaks:
- Table encoding is now detected directly instead of being derived from the collation - increased accuracy and cope with the DEFAULT encoding.
- Comments and formatting cleaned up in bits I was working on, obviously.
- A couple of methods - particularly [tablesListInstance table] and [tableDocument encoding] - have been renamed to avoid conflicts and fix code warnings.
Future improvements now possible:
- As we now have access to column types and other information, we can provide per-type behaviour where desired.
- The table parsing doesn't currently pull out comments or table indices, together with one or two other attributes. Some of this would be useful for display; some, such as indices, could be used to draw the table structure view as long as we're happy discarding a couple of columns (ie cardinality!)
|
| | |
|
| |
|
|
| |
whole meg on current build.
|
| |
|
|
| |
bytes into a category class method of NSString so we can potentially use it in other places.
|
| |
|
|
| |
looged in Subversion if we ever need it again. Resolves issue #147.
|
| | |
|
| |
|
|
| |
being recopied whenever one was changed and not compiled.
|
| | |
|
| | |
|
| |
|
|
| |
structure.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
- Refreshing or reloading a table view will now attempt to preserve sorting and filters.
Other changes:
- Initial cleanup of TableContent loadTable:
- Replacing project-distributed column sort arrows with the OS-provided images
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
• Connected
• Disconnected
• Import Finished
• Export Finished
• Query Finished
• Table Syntax Copied
|
| |
|
|
|
|
|
|
| |
• Added grabber images
• Removed small icon of table and replaced with new one
• Added "Checksum Table" to MainMenu
• Added extra splitter grab handles
• Few other bits cleaned up
|
| |
|
|
|
|
| |
- Added Sparkle.Framework to Project.
- Added SUFeedURL key in Info.plist (set to http://sequelpro.com/appcast/app-releases.xml)
- Updated "Check for Updates..." menu item in MainMenu.xib to now point to SparkleFramework updater
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
table information (commented out until bug resolved)
|
| |
|
|
|
| |
fixed some bugs with the database select toolbar item when customizing the toolbar
|
| |
|
|
|
| |
added a 48px version of the logo for the connect sheet
|
| | |
|
| |
|
|
|
|
| |
change header comment in TableDocument.h/m to reflect change in author
re-group files in xcode
|
| | |
|
| | |
|
| |
|
|
|
| |
fix CocoaMySQL reference in credits
|
| |
|
|
|
|
|
|
| |
remove references to CocoaMySQL
fix broken link to FAQ page
apply new icon to documentation
update credits rtf
|
| |
|
|
| |
crystal database icon
|
| | |
|
| | |
|
| |
|
