aboutsummaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* Move some duplicate code into it's own fileMax2015-01-274-110/+132
|
* Merge pull request #2053 from chn42/masterMax Lohrmann2015-01-131-3/+3
|\ | | | | Fix an issue with ssh -L forwarding (OpenSSL 6.7 onwards only supports ":" as separator to "-L")
| * Fix an issue with ssh -L forwarding (: is the correct separator)Christoph Neukirch2015-01-131-3/+3
| |
* | Change the way the NSOpenPanel is handled when selecting an SSH key to ↵Max Lohrmann2015-01-131-6/+14
|/ | | | address #2042
* Fix an issue where a KV Observer was not removed on dealloc resulting in KVO ↵Max2015-01-111-0/+1
| | | | messaging a Zombie and crashing
* Fix a compiler warningMax2015-01-101-3/+3
|
* Somehow a "}" got dropped in 56949ac7Max2015-01-101-0/+1
|
* Unescape escaped mirrored snippets in query fav.Max2015-01-091-14/+16
| | | | fixes #2049
* Fix some warningsMax2015-01-073-7/+12
|
* Addition to previous commit. Attention:Max2015-01-061-122/+123
| | | | Depening on your diff tool (Kaleidoscope and Tower are pretty bad, AppCode works well) this change might look big, but all I did was remove two levels of else { } by using return; instead.
* Change some code formattingMax2015-01-063-98/+108
|
* Minor internal changesMax2015-01-066-17/+20
|
* Addition to commit 2735e15bMax2015-01-0435-249/+223
|
* Replace some "magic numbers" with constantsMax2015-01-043-8/+16
|
* Formalize [x release], x = nil; conventionMax2015-01-0461-322/+333
| | | | | Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it. Feel free to revert this commit if you see issues with the approch or implementation.
* Fix minor UI issueMax2015-01-031-0/+1
| | | | When cancelling a connection, because SSH is asking for a password, the "SSH connecting…" message in the upper right window corner would not be reset.
* Some internal addtions for mysql event supportMax2015-01-025-26/+32
| | | | (Also deduplicated some code)
* * Fix broken import on 10.6…Max2015-01-021-1/+6
| | | | | (Import would not work on a new installation where a certain preference key has not yet been set) * Also attached the gear menu in table structure view to the table header view, so the columns to show can now be selected by right-clicking on the table header (like in Activity Monitor)
* Change how Growl status is displayed in prefsMax2014-12-312-9/+75
| | | | The current status of Growl/Notification center will now be shown as a label beneath the "Enable notifications" checkbox.
* Remove some duplicate code by adding abstractionMax2014-12-317-38/+28
|
* Fix a minor case of "bg thread updating UI"Max2014-12-301-1/+1
|
* +[NSThread detachNewThreadWithName:…] changesMax2014-12-301-4/+56
| | | | | The method never did the one extra thing it should do, because… see comment in the code. Let's see how this works out :)
* Fix two minor CSV import dialog issuesMax2014-12-261-22/+24
| | | | | * Tooltips were somewhat broken for non-imported fields (issue exists in 1.0.2) * Newly added expressions would cause the field to switch to "do not import" instead of the added expression
* ************** IMPORTANT: SEE BELOW **************Max2014-12-262-112/+131
| | | | | | | | | This change should fix the "slow CSV import dialog" issue on 10.10 (details below). To accomplish that, some major changes had to be made to the CSV import code. PLEASE VERIFY THE CORRECTNESS OF THE NEXT FEW CSV IMPORTS YOU DO! * Renamed some variables for better search visibility * Changed some instances where NSNumbers were being compared using "==" instead of "isEqual…" (does not work with object literals!) * The CSV import dialog would recreate the popup menus on *every* call to "tableView:objectValueFor…". However Instruments suggests that [NSMenu removeAllItems] and [NSMenu addItemsWithTitles:] are **really** expensive, esp. when called multiple times per second (e.g. when scrolling in the table view). This commit moves the popup menu setup into its own method and only calls it when the data actually changes. * The 'destination table column' was for some reason a NSPopupButtonCell which only ever had one item and sometimes got changed to a NSTextFieldCell in code. I didn't see any need to keep the popup cell and replaced it with a simple text cell.
* Add some more stub codeMax2014-12-233-1/+16
| | | | (as the nib loader on 10.10 is even whinier)
* Fix two threading issuesMax2014-12-231-25/+29
| | | | | * A call of setString: from background thread which could cause a "deleted thread with uncommitted CATransaction" warning * SPFieldMapperController was allocated from a background thread with an own autoreleasepool, while it contains UI objects. This could cause a crash when the autoreleasepool was drained and the field mapper forcefully released, while other UI objects still had it retained.
* Add code for utf8mb4 encodingMax2014-12-192-19/+22
|
* Roll some duplicate code into a loopMax2014-12-141-59/+33
| | | | (so the compiler can unroll it again)
* Fix an exception when opening Bundle EditorMax2014-12-141-4/+3
| | | | Caused by an earlier commit of mine.
* Fix crash on export with "overwrite existing files"Max2014-12-141-3/+10
| | | | This should fix #2010. A required object was not retained long enough.
* Attempt 2 to fix building on 10.7, 10.8Max2014-12-135-18/+16
|
* Attempt 1 to fix building on 10.7Max2014-12-132-0/+10
|
* Fix issue #2040Max2014-12-131-0/+6
| | | | Changing the query favorties/history would cause an UI inconsitency when the list was filtered before.
* Replace some NSDictionaries with literalsMax2014-12-1345-447/+419
| | | | | | * [NSDictionary dictionary] → @{} * [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past. * Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
* Change [NSArray arrayWithObject:] to @[] literalMax2014-12-1325-61/+60
| | | | Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
* Add cast for [NSApp delegate]Max2014-12-1329-98/+106
| | | | | * (Also changed some outdated URLs) * Replaced [NSApplication sharedApplication] with NSApp
* Replace boxed integers in code with @ literalsMax2014-12-1318-65/+65
|
* Reformatting code for modern ObjCMax2014-12-1323-133/+130
| | | | | Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals. Also replaced some TRUE/FALSE with their YES/NO counterparts.
* Mark issue for s.o. to look atMax2014-12-131-2/+3
|
* Changed a few typedef enums to Apples new methodMax2014-12-132-32/+19
|
* Add stub for SPTableContentFilterControllerMax2014-12-052-0/+15
| | | | And with that we are back to a build that should not spam your Console upon launch. (Sorry for the future merge conflict) :)
* Remove a private API in PSMTabBarCellXu Jie2014-12-011-1/+1
| | | | | | Directly assigning to _controlView of a NSActionCell is private and not allowed by Mac App Store. An _customControlView is used to replace _controlView in PSMTabBarCell to avoid direct assigning to _controlView. This should be the last private API to remove before going to Mac App Store.
* Include tab color when duplicating tab.Max2014-11-291-0/+4
| | | | Fixes #2029
* Change some split view width calculations.Max2014-11-293-7/+35
| | | | | | * Attempt to fix the "<SPSplitView: ...>: the delegate <SPSplitView: ...> was sent -splitView:resizeSubviewsWithOldSize: and left the subview frames in an inconsistent state:" message that has been plaguing my console for some time. * This commit also adds a minimum width on the main area to prevent some strange UI bugs.
* Change pagination popover to native typeMax2014-11-282-21/+73
| | | | | | This commit switches our pagination popover to use native NSPopover on 10.7+ making it look more polished and modern. On 10.6 the old style will be used, *however* that one might still suffer from a bug caused by undefined overlapping view drawing behaviour.
* Add a "Open Table in New Window" menu actionMax2014-11-232-13/+49
| | | | This is implemented as an alternate menu item, ie. it will appear when holding down the Option (alt) key instead of the normal "Open Table in new Tab" item. Fixes #2015
* Attempt to fix #1961Max2014-11-114-13/+38
| | | | | | | | | | | | | Namely this commit changes two things: 1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491): [NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release [[self window] orderOut:self]; This call order has now been swapped. 2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority. Requesting QA on this commit.
* Merge branch 'master' of https://github.com/sequelpro/sequelproMax2014-10-263-34/+72
|\ | | | | | | | | Conflicts: Source/SPGotoDatabaseController.m
| * Fix error building on 10.8.Stuart Connolly2014-10-262-4/+6
| |
| * Fix error building on 10.8.Stuart Connolly2014-10-262-27/+65
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-22 03:42:12 +0000