aboutsummaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix one case of "SSH input fields cut off"Max2015-02-081-0/+6
| | | | | | When the last selected favorite was "Quick Connect" with SSH, on the next launch SSH would be re-selected, but the fields other than SSH Host would be cut off. This was caused by a race condition between our window setup code and Cocoas window restoration code. Solved by disabling window restoration for now (didn't really work for us anyway).
* Fix some minor compiler warningsMax2015-02-036-4/+50
|
* Rename utf8 and utf8mb4Max2015-02-011-6/+9
| | | | | * To reduce confusion (and create some, for those people not yet aware of the difference) I have renamed the utf8s to "UTF-8 Unicode BMP" resp. "UTF-8 Full Unicode" according to their supported character range. * Also *both* utf8 variants will now be at the top of the list when creating new tables/databases
* Change lexer definition of high bytes.Max2015-02-012-4/+4
| | | | | | | | | | | | flex does not(*) support UTF-8, therefore alpha [a-z_\.À-ﾟ] has always been interpreted by flex as alpha [a-z_\.\xC3\x80-\xEF\xBE\x9F] I assume this is not what was indetend and the only reason it worked, is because C3 (195),BE (190) and 9F (159) are already covered by 80-EF (128-239). Incidentally this range would also cover the whole Unicode BMP in UTF8. This change should make it more obvious. (*) There were some patches in 2012 and 2014 but they don't seem to have been merged.
* Update lexer to reflect that backticks can actually escape themselves (won't ↵Max2015-02-012-2/+2
| | | | cause visible changes)
* Simplify catchall lexer ruleMax2015-02-011-2/+1
|
* Fix syntax highlighting for emoji et al. #2044Max2015-01-281-7/+38
| | | | Voodoo magic provided by @Bibiko ;)
* Move some duplicate code into it's own fileMax2015-01-274-110/+132
|
* Merge pull request #2053 from chn42/masterMax Lohrmann2015-01-131-3/+3
|\ | | | | Fix an issue with ssh -L forwarding (OpenSSL 6.7 onwards only supports ":" as separator to "-L")
| * Fix an issue with ssh -L forwarding (: is the correct separator)Christoph Neukirch2015-01-131-3/+3
| |
* | Change the way the NSOpenPanel is handled when selecting an SSH key to ↵Max Lohrmann2015-01-131-6/+14
|/ | | | address #2042
* Fix an issue where a KV Observer was not removed on dealloc resulting in KVO ↵Max2015-01-111-0/+1
| | | | messaging a Zombie and crashing
* Fix a compiler warningMax2015-01-101-3/+3
|
* Somehow a "}" got dropped in 56949ac7Max2015-01-101-0/+1
|
* Unescape escaped mirrored snippets in query fav.Max2015-01-091-14/+16
| | | | fixes #2049
* Fix some warningsMax2015-01-073-7/+12
|
* Addition to previous commit. Attention:Max2015-01-061-122/+123
| | | | Depening on your diff tool (Kaleidoscope and Tower are pretty bad, AppCode works well) this change might look big, but all I did was remove two levels of else { } by using return; instead.
* Change some code formattingMax2015-01-063-98/+108
|
* Minor internal changesMax2015-01-066-17/+20
|
* Addition to commit 2735e15bMax2015-01-0435-249/+223
|
* Replace some "magic numbers" with constantsMax2015-01-043-8/+16
|
* Formalize [x release], x = nil; conventionMax2015-01-0461-322/+333
| | | | | Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it. Feel free to revert this commit if you see issues with the approch or implementation.
* Fix minor UI issueMax2015-01-031-0/+1
| | | | When cancelling a connection, because SSH is asking for a password, the "SSH connecting…" message in the upper right window corner would not be reset.
* Some internal addtions for mysql event supportMax2015-01-025-26/+32
| | | | (Also deduplicated some code)
* * Fix broken import on 10.6…Max2015-01-021-1/+6
| | | | | (Import would not work on a new installation where a certain preference key has not yet been set) * Also attached the gear menu in table structure view to the table header view, so the columns to show can now be selected by right-clicking on the table header (like in Activity Monitor)
* Change how Growl status is displayed in prefsMax2014-12-312-9/+75
| | | | The current status of Growl/Notification center will now be shown as a label beneath the "Enable notifications" checkbox.
* Remove some duplicate code by adding abstractionMax2014-12-317-38/+28
|
* Fix a minor case of "bg thread updating UI"Max2014-12-301-1/+1
|
* +[NSThread detachNewThreadWithName:…] changesMax2014-12-301-4/+56
| | | | | The method never did the one extra thing it should do, because… see comment in the code. Let's see how this works out :)
* Fix two minor CSV import dialog issuesMax2014-12-261-22/+24
| | | | | * Tooltips were somewhat broken for non-imported fields (issue exists in 1.0.2) * Newly added expressions would cause the field to switch to "do not import" instead of the added expression
* ************** IMPORTANT: SEE BELOW **************Max2014-12-262-112/+131
| | | | | | | | | This change should fix the "slow CSV import dialog" issue on 10.10 (details below). To accomplish that, some major changes had to be made to the CSV import code. PLEASE VERIFY THE CORRECTNESS OF THE NEXT FEW CSV IMPORTS YOU DO! * Renamed some variables for better search visibility * Changed some instances where NSNumbers were being compared using "==" instead of "isEqual…" (does not work with object literals!) * The CSV import dialog would recreate the popup menus on *every* call to "tableView:objectValueFor…". However Instruments suggests that [NSMenu removeAllItems] and [NSMenu addItemsWithTitles:] are **really** expensive, esp. when called multiple times per second (e.g. when scrolling in the table view). This commit moves the popup menu setup into its own method and only calls it when the data actually changes. * The 'destination table column' was for some reason a NSPopupButtonCell which only ever had one item and sometimes got changed to a NSTextFieldCell in code. I didn't see any need to keep the popup cell and replaced it with a simple text cell.
* Add some more stub codeMax2014-12-233-1/+16
| | | | (as the nib loader on 10.10 is even whinier)
* Fix two threading issuesMax2014-12-231-25/+29
| | | | | * A call of setString: from background thread which could cause a "deleted thread with uncommitted CATransaction" warning * SPFieldMapperController was allocated from a background thread with an own autoreleasepool, while it contains UI objects. This could cause a crash when the autoreleasepool was drained and the field mapper forcefully released, while other UI objects still had it retained.
* Add code for utf8mb4 encodingMax2014-12-192-19/+22
|
* Roll some duplicate code into a loopMax2014-12-141-59/+33
| | | | (so the compiler can unroll it again)
* Fix an exception when opening Bundle EditorMax2014-12-141-4/+3
| | | | Caused by an earlier commit of mine.
* Fix crash on export with "overwrite existing files"Max2014-12-141-3/+10
| | | | This should fix #2010. A required object was not retained long enough.
* Attempt 2 to fix building on 10.7, 10.8Max2014-12-135-18/+16
|
* Attempt 1 to fix building on 10.7Max2014-12-132-0/+10
|
* Fix issue #2040Max2014-12-131-0/+6
| | | | Changing the query favorties/history would cause an UI inconsitency when the list was filtered before.
* Replace some NSDictionaries with literalsMax2014-12-1345-447/+419
| | | | | | * [NSDictionary dictionary] → @{} * [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past. * Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
* Change [NSArray arrayWithObject:] to @[] literalMax2014-12-1325-61/+60
| | | | Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
* Add cast for [NSApp delegate]Max2014-12-1329-98/+106
| | | | | * (Also changed some outdated URLs) * Replaced [NSApplication sharedApplication] with NSApp
* Replace boxed integers in code with @ literalsMax2014-12-1318-65/+65
|
* Reformatting code for modern ObjCMax2014-12-1323-133/+130
| | | | | Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals. Also replaced some TRUE/FALSE with their YES/NO counterparts.
* Mark issue for s.o. to look atMax2014-12-131-2/+3
|
* Changed a few typedef enums to Apples new methodMax2014-12-132-32/+19
|
* Add stub for SPTableContentFilterControllerMax2014-12-052-0/+15
| | | | And with that we are back to a build that should not spam your Console upon launch. (Sorry for the future merge conflict) :)
* Remove a private API in PSMTabBarCellXu Jie2014-12-011-1/+1
| | | | | | Directly assigning to _controlView of a NSActionCell is private and not allowed by Mac App Store. An _customControlView is used to replace _controlView in PSMTabBarCell to avoid direct assigning to _controlView. This should be the last private API to remove before going to Mac App Store.
* Include tab color when duplicating tab.Max2014-11-291-0/+4
| | | | Fixes #2029
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 20:40:52 +0000