aboutsummaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
...
* Favorites saving:stuconnolly2012-05-291-25/+24
| | | | | | - Switch to using a UUID for the backup filename to prevent issues of it already existing. - Fix an obvious logic error whereby the saving would be aborted when we couldn't create the backup file (fixes issue #1357).
* - Fix issues where removing favorites could cause crashes in other ↵rowanbeentje2012-05-286-1/+47
| | | | | | | | tabs/windows where the favorite was selected (Issue #1351) - Keep multiple windows and tabs in sync when editing favorites - Fix a new KVO observation not being removed on object teardown
* - Fix SSH connection error dialog issues where a localised error text ↵rowanbeentje2012-05-272-10/+10
| | | | contained the word "bind".
* Improve connection handling and editing:rowanbeentje2012-05-277-13/+29
| | | | | | | | | - Fix long-standing intermittent crashes caused by connection errors after SSH tunnels were established - Fix edits causing keychain -25299 errors (Issue #1340) - Allow changes of favourite type to be saved rather than disassociating the edit from the selection - Fix the favourites view scrolling to the top when there's no selection and connection details are being edited - Fix some issues with automatic naming of connections on connection type change
* Improve default favorite popup button handling when there are no favorites.stuconnolly2012-05-271-6/+16
|
* - Improve handling of MySQL connection cancellation, particularly when ↵rowanbeentje2012-05-261-27/+28
| | | | closing the associated window to prevent crashes
* Improve connection view menu item validation.stuconnolly2012-05-251-20/+19
|
* Export tidy up.stuconnolly2012-05-2511-98/+20
|
* Conection outline view fixes:stuconnolly2012-05-242-20/+55
| | | | | | | | | - When selecting a group node, instead of hiding the connection details, reset them to an empty state. - When removing a favorite make sure the details view is also set to an empty state. - Remove setting the outline view item's text colour, which should fix display issues on 10.7 Addresses points 1 & 5 on issue #1339.
* Improvements to connection view outline view:rowanbeentje2012-05-203-10/+65
| | | | | | | | | | - Prevent groups from being dragged into themselves (or child nodes) to prevent data loss - Improve selection handling when manually reordering nodes - Don't allow drags of the "Favorites" title at the top of the view to prevent exceptions - Prevent the "Favorites" title from being collapsed to prevent confusion on 10.7+ - Improve group tooltips to reflect contained favourites and groups - Improve menu validation checks
* - Clean up connection delegate on connection view close, addressing crashes ↵rowanbeentje2012-05-191-1/+4
| | | | when closing windows where connections are failing
* * Fixes the case of the curious @"es"'sdmoagx2012-05-173-8/+8
|
* Improve connection keepalive, disconnect, and connection loss after ↵rowanbeentje2012-05-152-4/+5
| | | | | | | | | | | reviewing crash logs and testing a number of situations: - Improve stability of closing connections after a connection loss - Minimise prompting a user for connection state restore if closing windows/tabs - Allow cancellation of keepalive ping threads to prevent crashes after deallocation of parent - Manually handle ping thread state struct memory to avoid cross-thread deallocation issues - Improve disconnection speed and resilience
* - Manually allocate memory for table selection restoration processing ↵rowanbeentje2012-05-131-3/+7
| | | | instead of relying on the stack; this should address exceptions on background threads when loading tables
* Fix another implicit cast warning.stuconnolly2012-05-111-1/+1
|
* Fix remaining implicit cast warnings.stuconnolly2012-05-117-15/+23
|
* Fix implicit cast warnings.stuconnolly2012-05-115-8/+8
|
* - Iterate over group nodes backwards when removing them during sorting, ↵rowanbeentje2012-05-101-2/+2
| | | | fixing excpetions if sorting multiple group nodes in a tree
* - Fix a build warning caused by r3649 changesrowanbeentje2012-05-101-0/+1
| | | | | - Improve debug to catch a structure connection issue
* - Ensure the selected connection is correctly scrolled to on Lion, working ↵rowanbeentje2012-05-102-4/+19
| | | | around animation issues
* Reapply changes from r3314, r3447 and r3450 from SPFavoritesPreferencePane ↵rowanbeentje2012-05-091-24/+30
| | | | to SPConnectionController, fixing tweaks missed by the outline view migration; particularly addresses Lion keychain cacheing issues causing password edits to make it appear that those passwords were lost for the rest of the session.
* More gcc warning fixes.stuconnolly2012-05-091-12/+10
|
* Fix more gcc warnings.stuconnolly2012-05-0911-42/+51
|
* Fix gcc warnings.stuconnolly2012-05-093-13/+13
|
* Add missing [super dealloc] call.stuconnolly2012-05-091-0/+2
|
* - Fix crashes when duplicating favouritesrowanbeentje2012-05-081-16/+18
|
* - Alter table filtering to reset pagination when filters are entered; ↵rowanbeentje2012-05-081-4/+9
| | | | pagination should still be correctly preserved in all other cases
* Fix an error thrown when attempting to save favorites data to disk caused by ↵stuconnolly2012-05-081-3/+3
| | | | the handling of null values. This also subsequetly caused an exception to be thrown when checking if any passwords needed updated.
* Tweak edit sheet sizing.stuconnolly2012-05-081-2/+2
|
* Make sure we resize the table content's edit sheet if it's opened with a ↵stuconnolly2012-05-082-21/+25
| | | | size greater than the current screen. Fixes issue #680.
* Improve formatting of SQL keywords in view syntax prettifier and add an ↵stuconnolly2012-05-082-17/+23
| | | | associated test.
* Rework connection loss handling in SPMySQL, particularly to improve ↵rowanbeentje2012-05-081-4/+2
| | | | | | | | | | | | background loss of connections: - Attempt to fix a condition causing a reconnection loop by fixing the order of connection state check and a query variable - If a connection is lost in the background, only attempt a single reconnect instead of requiring user intervention at once - Add a new connection state to handle background disconnects - If the connection has been lost in the background but is about to be used, reconnect it automatically (informing the user of loss if appropriate) - Don't attempt background reconnections if the connection has not been used for some time (Also update localisable strings, and tweak navigator controller connection usage)
* UUID string test.stuconnolly2012-05-071-1/+1
|
* Move the BASH command code from the string additions category to remove the ↵stuconnolly2012-05-0710-443/+541
| | | | dependency on SP specific code and all the tests to build successfully.
* - Change process ID tracking in the Server Processes list from using ints ↵rowanbeentje2012-05-041-19/+19
| | | | to using long longs, ensuring 64 bit ID support even on 32 bit systems. This addresses Issue #1335.
* Rename database action class.stuconnolly2012-05-0410-14/+12
|
* Add initial support of moving views when renaming a database. Currently not ↵stuconnolly2012-05-0414-269/+246
| | | | hooked up yet. Part of issue #1235.
* When creating a connection favorite from the entered details, replace the ↵stuconnolly2012-05-031-2/+6
| | | | use of NSRunAlertPanel with SPBeginAlertSheet.
* Remove KVO observers when closing the main window.stuconnolly2012-05-031-4/+24
|
* Add support for saving the state of the connection favorites outline view.stuconnolly2012-05-0311-38/+111
|
* - Fix a crash on closing windows by deregistering controller view ↵rowanbeentje2012-05-022-3/+4
| | | | | | | | notifications on dealloc - Fix a crash on opening windows after closing windows due to an overrelease of the favourites tree - Fix an exception on logging in due to incorrect keychain ID type on the document
* - Alter the variable that currentFavorite tracks to the favourite instead ↵rowanbeentje2012-05-025-25/+31
| | | | | | | of a copy of the represented node; this addresses a crash on Lion (Issue #1328) - Clean up variables and initialisers, restore connection keychain ID tracking and setting
* Fix memory leaks.stuconnolly2012-05-027-10/+24
|
* Fix renaming users. Fixes issue #1327.stuconnolly2012-05-021-1/+1
|
* Update general preference pane code that was missed in the merge.stuconnolly2012-05-023-32/+106
|
* Use the correct host when renaming a user.stuconnolly2012-05-021-1/+1
|
* Make sure the connection details input is visible after removing a node.stuconnolly2012-05-021-0/+3
|
* Prevent connection initialization when there's no favorite selected.stuconnolly2012-05-021-8/+10
|
* When removing an empty group node don't display the warning about removing ↵stuconnolly2012-05-021-60/+79
| | | | the groups and favorites contained within it.
* Merge outline view branch into trunk.stuconnolly2012-05-0246-2386/+3914
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | Adds support for managing and grouping favorites into folders in the connection view and removes the associated favorites management from the preferences window. NOTE: On first launch your connection favorites will be migrated from Sequel Pro's preference file to a new file in ~/Application Support/Sequel Pro/Data. Your old favorites will remain in the preference file until removed in a future version. Outstanding known issues: - Removing a group node with no child favorites presents a warning about also removing the non-existent favorites. - Starting the application with no favorites, creating a group node then selecting, hides the connection details input. Doesn't support emoty selection. - Setting the name of a connection, adding it to the favorites and then swicthing to a different connection type, screws with the favorite name. - The preservation between launches of whether group nodes are collapsed or not is currently not supported.