| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
The red (first) connection color would not be duplicated to another tab, when choosing "Open Table in New X" from the context menu (issue reported by Kyle via e-mail).
|
| |
|
|
| |
when they don't have a label assigned
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
(This also affects PSMSequelProTabStyle, but see the comment there why it is left unchanged)
|
| |
|
|
|
|
| |
When the last selected favorite was "Quick Connect" with SSH, on the next launch SSH would be re-selected, but the fields other than SSH Host would be cut off.
This was caused by a race condition between our window setup code and Cocoas window restoration code. Solved by disabling window restoration for now (didn't really work for us anyway).
|
| | |
|
| |
|
|
|
| |
* To reduce confusion (and create some, for those people not yet aware of the difference) I have renamed the utf8s to "UTF-8 Unicode BMP" resp. "UTF-8 Full Unicode" according to their supported character range.
* Also *both* utf8 variants will now be at the top of the list when creating new tables/databases
|
| |
|
|
|
|
|
|
|
|
|
|
| |
flex does not(*) support UTF-8, therefore
alpha [a-z_\.À-ﾟ]
has always been interpreted by flex as
alpha [a-z_\.\xC3\x80-\xEF\xBE\x9F]
I assume this is not what was indetend and the only reason it worked, is because C3 (195),BE (190) and 9F (159) are already covered by 80-EF (128-239). Incidentally this range would also cover the whole Unicode BMP in UTF8.
This change should make it more obvious.
(*) There were some patches in 2012 and 2014 but they don't seem to have been merged.
|
| |
|
|
| |
cause visible changes)
|
| | |
|
| |
|
|
| |
Voodoo magic provided by @Bibiko ;)
|
| | |
|
| |\
| |
| | |
Fix an issue with ssh -L forwarding (OpenSSL 6.7 onwards only supports ":" as separator to "-L")
|
| | | |
|
| |/
|
|
| |
address #2042
|
| |
|
|
| |
messaging a Zombie and crashing
|
| | |
|
| | |
|
| |
|
|
| |
fixes #2049
|
| | |
|
| |
|
|
| |
Depening on your diff tool (Kaleidoscope and Tower are pretty bad, AppCode works well) this change might look big, but all I did was remove two levels of else { } by using return; instead.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
| |
|
|
| |
When cancelling a connection, because SSH is asking for a password, the "SSH connecting…" message in the upper right window corner would not be reset.
|
| |
|
|
| |
(Also deduplicated some code)
|
| |
|
|
|
| |
(Import would not work on a new installation where a certain preference key has not yet been set)
* Also attached the gear menu in table structure view to the table header view, so the columns to show can now be selected by right-clicking on the table header (like in Activity Monitor)
|
| |
|
|
| |
The current status of Growl/Notification center will now be shown as a label beneath the "Enable notifications" checkbox.
|
| | |
|
| | |
|
| |
|
|
|
| |
The method never did the one extra thing it should do, because… see comment in the code.
Let's see how this works out :)
|
| |
|
|
|
| |
* Tooltips were somewhat broken for non-imported fields (issue exists in 1.0.2)
* Newly added expressions would cause the field to switch to "do not import" instead of the added expression
|
| |
|
|
|
|
|
|
|
| |
This change should fix the "slow CSV import dialog" issue on 10.10 (details below). To accomplish that, some major changes had to be made to the CSV import code. PLEASE VERIFY THE CORRECTNESS OF THE NEXT FEW CSV IMPORTS YOU DO!
* Renamed some variables for better search visibility
* Changed some instances where NSNumbers were being compared using "==" instead of "isEqual…" (does not work with object literals!)
* The CSV import dialog would recreate the popup menus on *every* call to "tableView:objectValueFor…". However Instruments suggests that [NSMenu removeAllItems] and [NSMenu addItemsWithTitles:] are **really** expensive, esp. when called multiple times per second (e.g. when scrolling in the table view). This commit moves the popup menu setup into its own method and only calls it when the data actually changes.
* The 'destination table column' was for some reason a NSPopupButtonCell which only ever had one item and sometimes got changed to a NSTextFieldCell in code. I didn't see any need to keep the popup cell and replaced it with a simple text cell.
|
| |
|
|
| |
(as the nib loader on 10.10 is even whinier)
|
| |
|
|
|
| |
* A call of setString: from background thread which could cause a "deleted thread with uncommitted CATransaction" warning
* SPFieldMapperController was allocated from a background thread with an own autoreleasepool, while it contains UI objects. This could cause a crash when the autoreleasepool was drained and the field mapper forcefully released, while other UI objects still had it retained.
|
| | |
|
| |
|
|
| |
(so the compiler can unroll it again)
|
| |
|
|
| |
Caused by an earlier commit of mine.
|
| |
|
|
| |
This should fix #2010. A required object was not retained long enough.
|
| | |
|
| | |
|
| |
|
|
| |
Changing the query favorties/history would cause an UI inconsitency when the list was filtered before.
|
| |
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
| |
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
