| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
(so the compiler can unroll it again)
|
| |
|
|
| |
Caused by an earlier commit of mine.
|
| |
|
|
| |
This should fix #2010. A required object was not retained long enough.
|
| | |
|
| | |
|
| |
|
|
| |
Changing the query favorties/history would cause an UI inconsitency when the list was filtered before.
|
| |
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
| |
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
| |
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
| | |
|
| |
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
| | |
|
| | |
|
| |
|
|
| |
And with that we are back to a build that should not spam your Console upon launch. (Sorry for the future merge conflict) :)
|
| |
|
|
|
|
| |
Directly assigning to _controlView of a NSActionCell is private and not allowed by Mac App Store.
An _customControlView is used to replace _controlView in PSMTabBarCell to avoid direct assigning to _controlView.
This should be the last private API to remove before going to Mac App Store.
|
| |
|
|
| |
Fixes #2029
|
| |
|
|
|
|
| |
* Attempt to fix the "<SPSplitView: ...>: the delegate <SPSplitView: ...> was sent -splitView:resizeSubviewsWithOldSize: and left the subview frames in an inconsistent state:" message that has been plaguing my console for some time.
* This commit also adds a minimum width on the main area to prevent some strange UI bugs.
|
| |
|
|
|
|
| |
This commit switches our pagination popover to use native NSPopover on 10.7+ making it look more polished and modern.
On 10.6 the old style will be used, *however* that one might still suffer from a bug caused by undefined overlapping view drawing behaviour.
|
| |
|
|
| |
This is implemented as an alternate menu item, ie. it will appear when holding down the Option (alt) key instead of the normal "Open Table in new Tab" item. Fixes #2015
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Namely this commit changes two things:
1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491):
[NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release
[[self window] orderOut:self];
This call order has now been swapped.
2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority.
Requesting QA on this commit.
|
| |\
| |
| |
| |
| | |
Conflicts:
Source/SPGotoDatabaseController.m
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
|
| |
* Possibility to double-click an item to go there
* Search is case-insensitive
|
| |
|
|
|
|
|
|
| |
The dialog enables
* searching for a database by name (substring matching),
* using C&P to select databases
* navigating to databases not in the database dropdown
* faster keyboard-based navigation
|
| | |
|
| |\
| |
| |
| | |
uxp-disable_smartquotes
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It might be useful to keep this setting on globally, but smart quotes break
SQL, resulting in the requirement of having to do an undo-type-undo dance to
force the editor to not replace the single (') and double (") quote
characters with the ‘, ’ and “, ” characters, respectively. Since we
can presume that no one will want to use these non-SQL quotation marks
within SQL unless they explicitly decide to do so (in matching a varchar
field, for instance), they should be off by default. Additionally, the
double-dash (--) is used in SQL for inline comments, which gets substituted
for the em-dash (—). Disabling this seems to be a good idea on the same
argument.
More info about text substitution: http://support.apple.com/kb/PH14294
|
| | |
| |
| |
| | |
Should fix #1978
|
| |/
|
|
|
| |
* Avoid a malloc(4) / free() and let the compiler figure that out
* sizeof(pointer) != sizeof(memory area pointed to by pointer)
|
| | |
|
| |
|
|
|
|
|
| |
Add a checkbox to the Editor preferences to disable placing backticks
around attributes when completing in the custom query pane.
Resolves #764
|
| |
|
|
|
|
| |
Add menu item "MySQL help for Word/Selection", with Control-H as the
default key equivalent
Delete SPTextView's built in handling of Control-H key presses
|
| |
|
|
| |
executed in.
|
| | |
|
| |
|
|
| |
This is mostly from https://github.com/incbee/DMLocalizedNibBundle (retaining Wil Shipleys original license)
|
| | |
|
| |
|
|
|
|
|
| |
This fixes an exception that would happen if three conditions were met:
1) No database was selected or it was empty
2) A custom export filename was set
3) You tried to export the result of a custom query
|
| | |
|
| |
|
|
| |
update itself; this will improve table switching speed significantly on laggy connections due to a forced information re-fetch
|
| |
|
|
| |
calling back to the main thread, fixing a potential spinlock situation when a background thread is querying and the main thread is waiting on the result
|
| |
|
|
| |
displaying table contents, as it saves a lot of shouldUseFieldEditorForRow: checks; shortStringRepresentationUsingEncoding: should return the same values for short strings
|
| |
|
|
| |
for use when loading tables, which may improve Issue #1925 and Issue #1902.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
arguments
|
