aboutsummaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* More bugfixes to the SPMySQL integration branch:rowanbeentje2012-03-145-9/+11
| | | | | | - Fix background database structure checks throwing exceptions at the end of certain table operations - Fix incorrect timer access/overrelease when closing a SPNarrowDownCompletion window when database structure fetching is active
* SPMySQL integration bugfixes:rowanbeentje2012-03-142-7/+5
| | | | | | | - Fix a bug where the socket path would not be autodetected if an empty string was supplied - Fix a bug fetching primary key column names for tables - Fix a bug building database structures on MySQL 3.x servers
* Final feature work on the SPMySQL branch before merging:rowanbeentje2012-03-1410-20/+752
| | | | | | | | - Add a ping keepalive managing object to prevent retain cycles from the NSTimer - Add -[SPMySQLConnection copy] support - Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness. - Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
* - Bring SPMySQL Framework integration branch up to date with trunkrowanbeentje2012-03-054-4/+43
|\
| * - Fix a retain cycle in SPNarrowDownCompletion popups while the structure ↵rowanbeentje2012-03-041-0/+7
| | | | | | | | is being retrieved
| * * Fixes a crash on 10.6 when closing a connection (Overrelease of MCPConnection)dmoagx2012-03-041-1/+1
| |
* | Warning: this branch commit is largely untested, and known to throw ↵rowanbeentje2012-02-2381-949/+897
|/ | | | | | | | | | | | exceptions as database structure retrieval is currently missing! Further work on SPMySQLFramework integration: - Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match - Add new convenience querying and result methods to the framework - Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions - Remove MCPKit from the source - Fix a number of warnings on Release-style builds
* - Cleanup: improve compatibility with 10.7 SDK to reduce compiler warningsrowanbeentje2012-02-0825-99/+98
|
* Fix minor copying and saving console view content issues.stuconnolly2012-01-292-16/+23
|
* - Make SPConnectionController a NSConnectionView subclass so that retain ↵rowanbeentje2012-01-212-4/+1
| | | | cycles caused by manually loading libs with bindings to File's Owner are automatically handled, fixing leaks of SPConnectionController and items it retain including any MCPConnection; this will fix issues with MCPConnections attempting to reconnect but no longer having an associated SPDatabaseDocument
* When editing a FLOAT field in the field editor, don't include the decimal ↵stuconnolly2012-01-161-27/+64
| | | | place when checking against the maxium allowed characters. Fixes issue #1237
* - Fix connection Growl notifications for background tabs to show the ↵rowanbeentje2012-01-151-1/+8
| | | | correct server name
* When exporting a query result as CSV ensure that we're allowing the exporter ↵stuconnolly2012-01-143-162/+204
| | | | decide how to deal with NULLs rather than passing them already converted to the user's placeholder prefernce which results in them being quoted. Fixes issue #1281. Also, general tidy up.
* Protect against dodgy preference data that may case bounds exceptions when ↵stuconnolly2012-01-113-5/+7
| | | | selecting the default favorite in the general preference pane.
* Improve index addition, especially where key sizes are required:rowanbeentje2012-01-111-3/+28
| | | | | | | - Fix exceptions caused by the sizes column formatter requiring a NSNumber - When displaying the indexes view ensure the sizes column is hidden by default, as the advanced view is closed - unless a field with a required size has been selected - If a field with a required size has been selected, don't hide the sizes column when collapsing the advanaced view
* - Roll back r3453 to avoid future license issuesrowanbeentje2012-01-101-3/+3
|
* Fix the indexes view not restoring the use vertical table view gridlines ↵stuconnolly2012-01-091-0/+1
| | | | preference.
* - Expicitly cast parameters before passing into NSString formatters ↵rowanbeentje2012-01-094-6/+6
| | | | assuming 64-bit lengths; this addresses exceptions and hangs viewing table contents on 32-bit machines, many thanks to stuart02 for identifying and tracking down this issue
* • removed for syntax hiliting "ensureLayoutForCharacterRange" since it can ↵Bibiko2012-01-081-4/+0
| | | | cause for some unknown reasons an exception
* - Add a new CSV import field escape setting, as a new default, supporting ↵rowanbeentje2012-01-063-3/+30
| | | | both backslash and double-character escaping. This will mean the vast majroty of CSVs selected for import will be read correctly by default, fixing issues such as Issue #1252
* • removed setting of textColor after syntax hilitingBibiko2012-01-051-11/+0
|
* • removed blocking of SPTextView textStorage while syntax hiliting Bibiko2012-01-051-2/+2
|
* • fixed issue for line numbering view if associated textView is scrolled ↵Bibiko2012-01-053-20/+39
| | | | | | from origin {0,0}; now it's synchronized • minor speed ups for custom query editor
* • sped up the line number drawing; now it's 5 times fasterBibiko2012-01-052-20/+30
|
* - Fix compilation errors reported by pornelski in Issue #1253rowanbeentje2012-01-041-3/+3
|
* - Fix addition of new passwords for favourites edited via the Preferences ↵rowanbeentje2011-10-201-4/+14
| | | | interface. This addresses Issue #1214.
* - Fix two incorrect initialisations; thanks to sqlprodev for spotting theserowanbeentje2011-10-202-2/+2
|
* - Update code to use NSStrings for NSTableColumn identifiers, as per 10.7 SDKrowanbeentje2011-10-176-89/+62
| | | | | - Update localizable strings
* - Improve the favourites editing process to edit keychain items, rather ↵rowanbeentje2011-10-163-22/+84
| | | | than deleting and recreating them. This has two advantages: firstly, it matches the Apple recommendation, as it preserves keychain item access lists and comments for keychain items when they are edited; secondly, it works around a bug in 10.7 which appears to be a Keychain cacheing issue, causing password retrievals to return the original keychain item on launch - which is no longer valid after deletion/recreation. This addresses Issue #1197.
* When building a string of all console messages, use a copy of the visible ↵stuconnolly2011-10-161-2/+8
| | | | message set ensure it's not modified while being enumerated. Fixes exception http://spbug.com/l/2743
* Update donate URL.stuconnolly2011-10-091-1/+1
|
* For some reason table creation on MySQL 4.0 servers doesn't like the ↵stuconnolly2011-10-094-33/+44
| | | | engine/type being quoted.
* * Move key of a hidden pref to the same place as the othersdmoagx2011-10-092-2/+2
|
* Add a hidden preference for specifying the long running query notification ↵stuconnolly2011-10-084-8/+10
| | | | time (currently in milliseconds). Implements issue #944
* Ensure the that table constraints are cleared in [SPTableData ↵stuconnolly2011-10-082-33/+34
| | | | informationForTable:] to prevent the inclusion of them in subsequent calls for different tables. Fixes issue 1206.
* - Rework table data saving to ensure that cells that should be edited via ↵rowanbeentje2011-10-056-324/+307
| | | | | | | the edit sheet aren't then overwritten by the cell value, potentially causing data truncation in 10.5. This addresses Issue 1196. - Consolidate field editing in sheet logic
* - Update database encoding routines to cache the database encoding, ↵rowanbeentje2011-09-292-6/+25
| | | | | | | preventing repeated calls when navigating tables using "default" encoding, or views - Ensure the database encoding is correctly updated when new databases are selected. This addresses Issue #1201
* Set the previously used export filename and path when the export dialog is ↵stuconnolly2011-09-291-23/+43
| | | | opened not in awakeFromNib. Fixes issue #1198.
* Fix test.stuconnolly2011-09-261-2/+2
|
* - Fix editing of binary string values, a regression in r3428; addresses log ↵rowanbeentje2011-09-222-0/+6
| | | | 2665
* Rework linebreak handling in content and custom query result views, as ↵rowanbeentje2011-09-215-37/+141
| | | | | | | | | | | triggered by Issue #1184: - Display table cells on a single line for preview purposes - Display gray pilcrow/reverse pilcrow placeholders instead of linebreaks - If a cell contains linebreaks, automatically trigger sheet editing mode - Handle newly displayed linebreaks in column width detection - If using the up/down arrow keys in a field editor, allow them to select the previous/next line within an editor if appropriat (instead of always moving to the previous/next row)
* * Add "Copy CREATE *" to context and gear menu, fixes #1190 (updated ↵dmoagx2011-09-152-0/+22
| | | | .strings files)
* Improve custom query result export menu item validation to prevent ↵stuconnolly2011-09-131-1/+1
| | | | triggering an export whilst a query is being performed.
* - Speculative fix for Issue #1154 (problems using some field separators ↵rowanbeentje2011-09-121-0/+3
| | | | during CSV import)
* - Add the ability to view hidden files in SSH/SSL key selection dialogs; ↵rowanbeentje2011-09-106-24/+57
| | | | this addresses Issue #1176
* - Make add relation error detail intro localisablerowanbeentje2011-09-091-1/+7
| | | | | | - If the add relation error strongly appears to be a name-already-taken error, add the name to the takenNames list to prevent it being used again and to highlight the error - Update localisable strings
* - Require there to be at least 50 rows to be in the table before using the ↵rowanbeentje2011-09-071-1/+1
| | | | "DELETE FROM foo" remove all rows code path. This improves the chance that the user actually intends to delete all the rows in the table, addressing Issue #1166.
* Rework relation addition and name lookups following testing and research:rowanbeentje2011-09-073-96/+56
| | | | | | | | - Remove the background lookup of table constraint names for the current database. This prevented connection use while the query was running, and the query cannot be optimised and severely taxes servers with many databases. Revert to checking names against names in the current database - Repurpose the activity spinner for adding relation query execution - When an error is encountered adding a relation, re-open the sheet with the submitted values after displaying the error - Add use of 'SHOW InnoDB STATUS' command and text extraction to show more explicit errors for the most common constraint errors
* Replace use of string literals with constants in SPTableRelations.mstuconnolly2011-09-041-15/+22
|
* Fix for issue 1168. Whenever the database is changed load all of the ↵stuconnolly2011-09-045-87/+160
| | | | currently used relation names in a backgroud thread. In the event that the user opens the add new relation sheet during this process, the ability to enter a relation name and confirm the addition is disabled until the retrieval process is complete. There is also a new progress indicator on the add sheet to indicate this.