| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
from the project, and replace with an MIT-licensed TCMPortMapper sources NSNotificationCenterThreadingAdditions category. This should fix method clashes in the SP_REFACTOR project, so remove behavioural/namespacing switches.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the functionality required from MCPKit and is based around its interface for relatively easy integration.
Externally visible changes as a result of this merge:
- Speed improvements, particularly when loading large data sets
- Stability improvements, particularly related to connection state after the connection is dropped (eg Issue #1256)
- Improved support for new MySQL data types, which should address Issue #1052.
- Database structure retrieval and query cancellation now use a single persistent helper connection instead of lots of connections on-demand. This should help Issue #1097.
- More internal commands now use queries instead of MySQL functions; for example USE queries are now used to trigger database selection, improving transcripts. This addresses Issue #1247.
- Improved internal encoding work; while this needs support within the UI, it lays the foundation for issues like Issue #1280.
Code improvements:
- Much improved class layouts including extensive category usage
- Improved documentation across framework methods
- Support for fast enumeration across result objects
- Rewrite fixes use of a number of deprecate functions
- Much less code duplication across result set types
- Improved encapsultation within the framework, limiting the number of methods exposed, and also not exposing all the MySQL headers
From the Readme file:
The SPMySQL Framework is intended to provide a stable MySQL connection framework, with the ability to run text-based queries and rapidly retrieve result sets with conversion from MySQL data types to Cocoa objects.
SPMySQL.framework has an interface loosely based around that provided by MCPKit by Serge Cohen and Bertrand Mansion (http://mysql-cocoa.sourceforge.net/), and in particular the heavily modified Sequel Pro version (http://www.sequelpro.com/). It is a full rewrite of the original framework, although it includes code from patches implementing the following Sequel Pro functionality, largely contributed by Hans-Jörg Bibiko, Stuart Connolly, Jakob Egger, and Rowan Beentje:
- Connection locking (Jakob et al)
- Ping & keepalive (Rowan et al)
- Query cancellation (Rowan et al)
- Delegate setup (Stuart et al)
- SSL support (Rowan et al)
- Connection checking (Rowan et al)
- Version state (Stuart et al)
- Maximum packet size control (Hans et al)
- Result multithreading and streaming (Rowan et al)
- Improved encoding support & switching (Rowan et al)
- Database structure; moved to inside the app (Hans et al)
- Query reattempts and error-handling approach (Rowan et al)
- Geometry result class (Hans et al)
- Connection proxy (Stuart et al)
|
| |
| |
| |
| | |
list never to be initialised - 10.7 magically fixed this and worked, but 10.6 didn't show any triggers. Thanks to schlabberdog for spotting and diagnosing this issue!
|
| |
| |
| |
| |
| |
| | |
- Return User Manager details as strings as some result types are marked as binary; fixes opening of user manager
- User manager schema list is now a list of databases instead of a list of database dictionaries with one key; simplify model to match
|
| |
| |
| |
| |
| |
| | |
- Fix background database structure checks throwing exceptions at the end of certain table operations
- Fix incorrect timer access/overrelease when closing a SPNarrowDownCompletion window when database structure fetching is active
|
| |
| |
| |
| |
| |
| |
| | |
- Fix a bug where the socket path would not be autodetected if an empty string was supplied
- Fix a bug fetching primary key column names for tables
- Fix a bug building database structures on MySQL 3.x servers
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Add a ping keepalive managing object to prevent retain cycles from the NSTimer
- Add -[SPMySQLConnection copy] support
- Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness.
- Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
| | | |
|
| |/
|/|
| |
| | |
a table to warn of the potential data loss that may occur. Fixes issue #1258.
|
| |
| |
| |
| | |
is being retrieved
|
|/ |
|
| |
|
| |
|
|
|
|
| |
cycles caused by manually loading libs with bindings to File's Owner are automatically handled, fixing leaks of SPConnectionController and items it retain including any MCPConnection; this will fix issues with MCPConnections attempting to reconnect but no longer having an associated SPDatabaseDocument
|
|
|
|
| |
place when checking against the maxium allowed characters. Fixes issue #1237
|
|
|
|
| |
correct server name
|
|
|
|
| |
decide how to deal with NULLs rather than passing them already converted to the user's placeholder prefernce which results in them being quoted. Fixes issue #1281. Also, general tidy up.
|
|
|
|
| |
selecting the default favorite in the general preference pane.
|
|
|
|
|
|
|
| |
- Fix exceptions caused by the sizes column formatter requiring a NSNumber
- When displaying the indexes view ensure the sizes column is hidden by default, as the advanced view is closed - unless a field with a required size has been selected
- If a field with a required size has been selected, don't hide the sizes column when collapsing the advanaced view
|
| |
|
|
|
|
| |
preference.
|
|
|
|
| |
assuming 64-bit lengths; this addresses exceptions and hangs viewing table contents on 32-bit machines, many thanks to stuart02 for identifying and tracking down this issue
|
|
|
|
| |
cause for some unknown reasons an exception
|
|
|
|
| |
both backslash and double-character escaping. This will mean the vast majroty of CSVs selected for import will be read correctly by default, fixing issues such as Issue #1252
|
| |
|
| |
|
|
|
|
|
|
| |
from origin {0,0}; now it's synchronized
• minor speed ups for custom query editor
|
| |
|
| |
|
|
|
|
| |
interface. This addresses Issue #1214.
|
| |
|
|
|
|
|
| |
- Update localizable strings
|
|
|
|
| |
than deleting and recreating them. This has two advantages: firstly, it matches the Apple recommendation, as it preserves keychain item access lists and comments for keychain items when they are edited; secondly, it works around a bug in 10.7 which appears to be a Keychain cacheing issue, causing password retrievals to return the original keychain item on launch - which is no longer valid after deletion/recreation. This addresses Issue #1197.
|
|
|
|
| |
message set ensure it's not modified while being enumerated. Fixes exception http://spbug.com/l/2743
|
| |
|
|
|
|
| |
engine/type being quoted.
|
| |
|
|
|
|
| |
time (currently in milliseconds). Implements issue #944
|
|
|
|
| |
informationForTable:] to prevent the inclusion of them in subsequent calls for different tables. Fixes issue 1206.
|
|
|
|
|
|
|
| |
the edit sheet aren't then overwritten by the cell value, potentially causing data truncation in 10.5. This addresses Issue 1196.
- Consolidate field editing in sheet logic
|
|
|
|
|
|
|
| |
preventing repeated calls when navigating tables using "default" encoding, or views
- Ensure the database encoding is correctly updated when new databases are selected. This addresses Issue #1201
|
|
|
|
| |
opened not in awakeFromNib. Fixes issue #1198.
|
| |
|
|
|
|
| |
2665
|
|
|
|
|
|
|
|
|
|
|
| |
triggered by Issue #1184:
- Display table cells on a single line for preview purposes
- Display gray pilcrow/reverse pilcrow placeholders instead of linebreaks
- If a cell contains linebreaks, automatically trigger sheet editing mode
- Handle newly displayed linebreaks in column width detection
- If using the up/down arrow keys in a field editor, allow them to select the previous/next line within an editor if appropriat (instead of always moving to the previous/next row)
|
|
|
|
| |
.strings files)
|