aboutsummaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* - Improve SPSSHTunnel question/password dialogs to no longer eat 100% CPU ↵rowanbeentje2010-03-313-29/+35
| | | | | | | | by switching from NSCondition blocking to NSLock blocking - Improve behaviour of SSH tunnels with no password in keychain - prompt appropriately - Set MXPConnection to check the proxy state when attempting to reconnect a dropped connection, extending the timer when an auth UI is up. This prevents a multiple-dialogs misbehaviour (or sometimes deadlock), addressing the last part of http://log.sequelpro.com/view/86 .
* • ensure that the global schema structure data for completion are updated ↵Bibiko2010-03-313-11/+10
| | | | even if SP is not active
* More tidy up. Constants and functions.stuconnolly2010-03-316-29/+31
|
* • fixed issue for refreshing the completion list after finishing the ↵Bibiko2010-03-311-2/+2
| | | | | | structure querying - set variable directly and call [self close] explicitly
* Tidy up imports and fix 'Reverse Sort Order' when sorting connection ↵stuconnolly2010-03-3143-51/+39
| | | | favorites (Thanks Hans).
* • fixed issue for completion window if animated sync icon is shownBibiko2010-03-311-6/+25
| | | | | - init all column' data cells according to their settings to avoid jittering and font size change - this fix also removed one issue for 'overlapping' completion windows
* Manually set the connection favorites button bar delegate to ensure the ↵stuconnolly2010-03-313-2/+7
| | | | split view delegate methods are called.
* check for the attributed string length >= 3 while truncating it to avoid ↵Bibiko2010-03-311-2/+2
| | | | exceptions
* Add a new gear drop down menu to the connection favorites table view ↵stuconnolly2010-03-311-36/+33
| | | | containing the remove, duplicate and sort favorites menu items. Also, fix the selection of newly added and duplicated favorites because of sorting options being applied.
* • if document window will close sent a ↵Bibiko2010-03-313-4/+16
| | | | | | 'cancelPreviousPerformRequestsWithTarget' to the custom query editor to stop auto-completion and auto-help timer to avoid crashes after closing • improved some minor stuff for completion's re-invocation
* If the user is viewing the triggers table and then switches to either a proc ↵stuconnolly2010-03-311-0/+9
| | | | or function disable all interface controls.
* • querying for db structure is queued for the same connection to avoid ↵Bibiko2010-03-316-61/+197
| | | | | | | | | | | 'overlapping' access to global variables • after querying db structure write back data on main thread • completion list displays animated sync images if connection is just querying db structure data • fixed some minor issue for completion list • make sure that if last window of a connection is closed all relevant data will be removed from global variables Note: please test!
* Minor tidy up. Remove uneccessary import and rename pre-compiled header.stuconnolly2010-03-312-3/+1
|
* - Improve error checking for various actions, particularly permissions ↵rowanbeentje2010-03-314-16/+92
| | | | errors (NULL data returned) for views and stored procedures. This should fix http://log.sequelpro.com/view/27 , http://log.sequelpro.com/view/57 , and the last of http://log.sequelpro.com/view/53
* When adding a new table with a CSV storage engine, the initial field cannot ↵stuconnolly2010-03-301-11/+26
| | | | be NULL as nullable fields are not supported. Fixes issue #614. Although resolved, this will ultimately be fixed in a better approach upon the implementation of issue #297 that should allow the user to customize many of the properties of the initial field of a new table.
* • next trial to make getAllKeysOfDbStructure thread safeBibiko2010-03-302-59/+107
| | | | | | | | • some speed improvements for navigator - pre-calculate display string for type info to avoid doing it all the time while refreshing the outline view • suppress double-clicking at a not yet queried db structure if the same connection is querying another structure to avoid accessing the same storage objects from different threads (test) • reload outline view after filtering in navigator runs in its own thread to avoid blocking SP • fixed memory leaks while returning [obj copy]
* • some further code optimizations for navigator Bibiko2010-03-302-23/+53
|
* • some speed improvements and code simplifications for navigatorBibiko2010-03-305-43/+41
| | | | | | • avoid making the completion key list unique since it's possible to insert unique items only • added trigger to query db structure after SQL import • some work to avoid http://log.sequelpro.com/view/90 (not yet ideally - WIP)
* - Ensure Copy [with Column Names]/Copy As SQL are disabled on the trigger ↵rowanbeentje2010-03-292-12/+32
| | | | and relations views. This fixes the copy parts of http://log.sequelpro.com/view/53
* • fixed several threading issues due to threadingBibiko2010-03-291-10/+9
| | | | | - collection classes as NSMutableSet are NOT thread safe! • further tiny speed improvements for navigator
* • added some more sanity checks to avoid exceptions due to threadingBibiko2010-03-291-10/+19
|
* • improved completion suggestion for db schemataBibiko2010-03-293-42/+48
| | | | | | | | - if user typed "foo." and there's an unique schema path regardless cases (like there's an item Foo) show the content of the path Foo - now getUniqueDbIdentifierFor:term returns an array of found type (db or table) and the found string to handle case better for completion • tried to speed up the search in the navigator by using a NSPredicate • [MCPConennection allKeysofDbStructure] - fixed issue while returning if allKeysofDbStructure == nil
* • fixed several issue for completion listsBibiko2010-03-295-27/+97
| | | | | | | • improved gathering and caching of structure data coming from connection windows with the same connection • made the structure querying more stable against threading issues • moved getUniqueDbIdentifierFor from MCPConnection to SPNavigatorController to be up-to-date in all connection windows • improved detection if db structure querying should be performed or not (not yet finished)
* - db structure for tables and views will now be queried by using SHOW… ↵Bibiko2010-03-284-60/+79
| | | | | | | | | | | statements - completion now works for server versions < 5 as well - proc/func info will be queried by using information_schema for mysql >= 5 - changed completion logic to handle new format - completion will get the info from SPNavigator since this controller caches all information about db structure - optimization and fine-tuning will follow very soon
* - Improve MCPConnection behaviour with respect to run loops and proxies, ↵rowanbeentje2010-03-271-4/+2
| | | | | | | improving both proxy disconnection and reconnection after dropped connections - Slightly tweak SPSSHTunnel to improve proxy behaviour
* Add the ability to sort the connection favorites table view in the ↵stuconnolly2010-03-275-8/+126
| | | | preferences. Sort options are by name, host or type as well as the option to be sorted in reverse order. This implements issue #490.
* - When switching tables, correctly catch disconnections and suppress error ↵rowanbeentje2010-03-274-25/+25
| | | | | | | | | dialogs and related crashes - Move connection error sheet close method to the connection delegate - Tweak the information_schema db schema building query to be much faster on busy servers by amending the VIEW part - Set the connection lock to nil after releasing, coping with connection unlocks deferred on the main thread until after dealloc
* Fix an exception caused when selecting the default favorite popup button. ↵stuconnolly2010-03-271-1/+1
| | | | Caused by the addition of validateMenuItem: in r2015.
* Add a contextual menu to the favorites table view in the preferences.stuconnolly2010-03-272-31/+36
|
* changed the invoking point of db structure query at the very end of ↵Bibiko2010-03-261-3/+5
| | | | updateTables: to be able to collect all available tables while querying the structure
* fixed issue while selecting a db name in navigator which wasn't queried yetBibiko2010-03-261-1/+3
|
* • navigatorBibiko2010-03-264-14/+11
| | | | | - fixed issue if different connection windows are connected to the same connection - prepared structure querying method to be able to add user info containing which table/db was changed if we know it to reduce the future parsing cost
* • Navigator and completion listBibiko2010-03-261-1/+7
| | | | | | - fixed issues for deletion of a db like remove all relevant items and refresh the navigator - simplified and minimized code and memory usage while querying the connection structure - whether a schema name is an unique db or table will be evaluated on run-time via allKeysofDbStructure
* Before attempting to parse the create syntax of a table or view, check that ↵stuconnolly2010-03-261-0/+4
| | | | it's not nil. This accommodates cases where the SHOW CREATE SYNTAX query caused the connection reconnect dialog to appear and the user chose the close the connection.
* • first steps to ease the structure querying for auto-completion and navigatorBibiko2010-03-267-50/+109
| | | | | | | - now it accumulates the data and caches them db by db, ie one has to select a db before using its structure for completion and navigator - next step is to avoid querying info_schema as much as possible - it will only query the structure if something was changed - next steps follows as soon as possible
* Until it can be moved to it's own connection don't allow refreshing of the ↵stuconnolly2010-03-261-10/+5
| | | | processes list whilst the document is performing a task to prevent connection lock errors. Related to issue #607.
* Localize 'Save As...' button titles on console and process list windows.stuconnolly2010-03-252-4/+4
|
* Bunch of improvements to the server process list viewer, including:stuconnolly2010-03-255-21/+62
| | | | | | | | | | - It is now a separate window like the console to enable monitoring. - It now uses the same window style as the console. - The ability to show or hide the process ID, column. This could possibly be enabled for some of the other columns as well, suggestions? - The ability to enable or disable the use of SHOW FULL PROCESSLIST or just SHOW PROCESSLIST. This implements most of the enhancements requested in issue #607, with the exception of the option to enable auto-refresh, which is still being worked on.
* Add support for selecting the triggers view as the default in the general ↵stuconnolly2010-03-254-13/+23
| | | | preferences pane.
* • changed behaviour of ^⌥⌘F "Filter Table" or "Change Focus to Table ↵Bibiko2010-03-252-3/+17
| | | | | | | | List" - if > 20 tables are listed it sets the focus on the search field - if <= 20 it sets the focus on the table list, and - if no selection - it selects the first table item - this fixes i597
* Add support for the triggers view in the history controller.stuconnolly2010-03-252-2/+11
|
* • fixed the type info display of fields in the auto-completion list due ↵Bibiko2010-03-251-1/+1
| | | | the changed queried structure
* • NavigatorBibiko2010-03-252-48/+191
| | | | | | | - first implementation of a search functionality, workable but tiny issues have to be improved - up to now the only search implemented is 'contains', regexp/fuzzy search will come soon - the search is only performed in the main outline view, the upper one is static - for the new search store all available schema paths uniquely in an array which will be set during queryDbStructure (this avoids re-parsing of a dict structure)
* • NavigatorBibiko2010-03-254-26/+36
| | | | | | - make usage of a notification sent by the [MCPConnection queryDbStructure] to update the navigator, and this decouples a doc window and MCPConnection from the navigator - minimized the tree update - now connectionID-based - any tree update will be now performed on main thread and waits until done to avoid 'overlapping' updates triggered by different notifications which normally ended up in an inchoate tree display
* - Make [MCPConnection getLastErrorMessage] more consistent by always ↵rowanbeentje2010-03-2513-84/+77
| | | | | | | returning nil if no error occurred (previously a blank string was returned most of the time) - Add a new (BOOL)[MCPConnection queryErrored] method, changing all error message checks to use it for clarity
* - Correctly store scroll and selection for the navigation history when ↵rowanbeentje2010-03-251-2/+15
| | | | filtering content tables
* General tidy up, with a focus on consolidating more constants in ↵stuconnolly2010-03-2438-281/+293
| | | | SPConstants.h/m.
* • NavigatorBibiko2010-03-244-49/+99
| | | | | | - ENTER and RETURN selects schema path in active connection window - outsourced some stuff to SPNavigatorOutlineView • added rotating sync arrows to project for future usage
* - Add a new selectDatabase:item: method to TableDocument, to centralise ↵rowanbeentje2010-03-247-96/+128
| | | | | | | | | | code for selecting databases and tables. Clean up database selection to use this new method, and avoid reloads when re-selecting the same database. - Convert the history controller to use this new call. This fixes history behaviour when a table list filter was active. - Convert the (hidden) navigator to use this new call. This fixes timing issues. - Make some thread safety tweaks to TablesList. - Change TablesList selectTableOrViewWithName: to selectItemWithName:, including procs etc.
* - Remove observers for key paths when dealloc'ing objects to fix later ↵rowanbeentje2010-03-239-6/+46
| | | | | | | crashes when changing those keyvalues (eg changing query editor background colour after closing windows - http://log.sequelpro.com/view/44 ) - Fix a memory leak of a prefs reference in CMTextView