| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
improving the truncation reload code and by removing a problem in TableContent tracking the active table name. This addresses Issue #700 and a number of crash reports.
- Rename SPHistoryView* constants to SPTableView* constants and use them more widely rather than hard-coded tab indexes
- Fix a problem preventing history navigation if a triggers view was the previous item in the history
|
|
|
|
|
|
|
|
| |
- Remove extra call when changing databases, avoiding double calls
- Fix an error if the document has had no encoding set yet (addresses http://spbug.com/l/200)
- Tweak db struture querying to work on MySQL 3 and 4.0
- Rework function to remove duplicated logic, and to address a number of valueForUndefinedKey: exceptions logged via the bug tracker
|
|
|
|
| |
only the db list was reloaded, keeping the list of tables from the previously selected database
|
|
|
|
|
|
|
|
| |
background thread; should fix a number of issues logged by the crash reporter
- Update indicator code to merged master incorporating our changes, reworked and improved
|
|
|
|
|
|
|
| |
- Change MCPConnection.m to no longer use a reference to tableWindow to attach sheets - instead use a delate error display method if available
- Rework TableSource and TableContent sheetDidEnd methods into per-task methods rather than overloading contextInfo
- Rework SPAlertSheets to perform actions on the main thread, with the loss of (unused) support for a didDismissSelector. This addresses a number of crashes logged by the crash reporter
|
| |
|
|
|
|
| |
and disable OK button if it does.
|
|
|
|
|
| |
Added the to be copied/renamed database name to the name input sheet. Added necessary outlets. Added the current db name as preset value in the rename input field.
Renamed databaseNewSheet to databaseCopySheet and copyOnlyStructureButton to copyDatabaseDataButton and inverted behaviour of the button.
|
| |
|
|
|
|
| |
provided
|
|
|
|
| |
successful. Caused an existing DB to be selected, after ren/dup failed because it exists.
|
|
|
|
| |
for message sheets. It could have caused messages appearing in the wrong window.
|
|
|
|
| |
sheet by checking the returnCode of the sheet.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Details as follows:
* altered MCPConnection listTablesFromDB:like: to return NSArray
* altered MCPConnection listFieldsFromTable:like: to use backtick quoted
strings for table and fieldnames
* added MCPConnection listTablesFromDB for a complete table list
* added SPStringAdditions.h to various files to prevent warnings
* added sheets for duplicate/rename DB in DBView.xib
* added duplicate/rename menu items to MainMenu.xib
* added outlets in TableDocument: databaseNewSheet databaseRenameSheet
databaseCopyNameField databaseRenameNameField copyOnlyStructureButton
copyDatabaseButton renameDatabaseButton
* added methods in TableDocument: getConnection, copyDatabase, renameDatabase,
_copyDatabase, _renameDatabase
* added OCMock Framework for object mocking in tests
* added group Others/DatabaseActions
|
|
|
|
|
|
|
|
|
| |
application upon termination with the result being written to /tmp.
To enable call setDumpLeaksOnTermination on SPLogger.
Note, that SPLogger has been restructed to accommodate calling this method without writing the additional log file to the user's desktop. Could probably be enhanced a bit by someone with better C skills than me.
|
| |
|
|
|
|
| |
http://spbug.com/l/137
|
|
|
|
|
|
|
|
| |
standardise current view-commit-checks to use that
- Add checking of that status to history navigation (fixing http://spbug.com/l/127 ) and window closing (fixing http://spbug.com/lr/263 )
- Improve thread safety/deferred actions in TableContent
|
|
|
|
| |
overrelease on crash, by moving from automatic/inherited window management for the task spinner to fully managed. This addresses http://spbug.com/l/4 .
|
|
|
|
| |
only update it when visible - this fixes crashes after the toolbar item is removed from the toolbar and then updated (eg http://spbug.com/l/114 )
|
|
|
|
|
|
|
| |
- Add more calls to deregister watchers to fix crashes to closing threads or objects
- Fix a couple of memory leaks
- Alter a few calls to be performed on main thread (afterDelay: operates on the thread is is called on) - this fixed database reloading after import and field/index deletion error sheets
|
|
|
|
| |
• fixed 'Import from Clipboard' menu item validation to be disabled if no database is selected (thanks to avenjamin for pointing it out)
|
|
|
|
|
|
|
|
|
|
|
| |
background thread, and integrate for SQL import:
- Implement streaming reading of gzip-compressed files for SQL import
- Support exporting SQL dumps into a gzip-compressed file
- SPFileHandle supports the most-used subset of NSFileHandle commands for easy integration
- Integrate zlib 1.2.4 for improved gzip streaming performance (and support for custom buffer sizes and file offset positions)
This implements Issue #571 .
|
| |
|
|
|
|
|
|
| |
- sheet showing the first 4kB of pasteboard content and the SQL/CSV accessory view
- pasteboard content will be saved as temp file and read by using the current table/connection encoding
|
|
|
|
| |
information view or create syntax sheet remember to append a semi-colon. Fixes issue #629.
|
|
|
|
| |
saved (this addresses http://spbug/l/75), and correctly restore empty passwords
|
|
|
|
| |
view regardless if the content is empty or not, since it's very likely that the user wants to change it. This should solve i483.
|
|
|
|
| |
even if SP is not active
|
|
|
|
|
|
| |
'cancelPreviousPerformRequestsWithTarget' to the custom query editor to stop auto-completion and auto-help timer to avoid crashes after closing
• improved some minor stuff for completion's re-invocation
|
|
|
|
|
|
|
|
|
|
|
| |
'overlapping' access to global variables
• after querying db structure write back data on main thread
• completion list displays animated sync images if connection is just querying db structure data
• fixed some minor issue for completion list
• make sure that if last window of a connection is closed all relevant data will be removed from global variables
Note: please test!
|
|
|
|
| |
errors (NULL data returned) for views and stored procedures. This should fix http://log.sequelpro.com/view/27 , http://log.sequelpro.com/view/57 , and the last of http://log.sequelpro.com/view/53
|
|
|
|
|
|
|
| |
• improved gathering and caching of structure data coming from connection windows with the same connection
• made the structure querying more stable against threading issues
• moved getUniqueDbIdentifierFor from MCPConnection to SPNavigatorController to be up-to-date in all connection windows
• improved detection if db structure querying should be performed or not (not yet finished)
|
|
|
|
| |
preferences. Sort options are by name, host or type as well as the option to be sorted in reverse order. This implements issue #490.
|
|
|
|
|
|
|
|
|
| |
dialogs and related crashes
- Move connection error sheet close method to the connection delegate
- Tweak the information_schema db schema building query to be much faster on busy servers by amending the VIEW part
- Set the connection lock to nil after releasing, coping with connection unlocks deferred on the main thread until after dealloc
|
|
|
|
|
| |
- fixed issue if different connection windows are connected to the same connection
- prepared structure querying method to be able to add user info containing which table/db was changed if we know it to reduce the future parsing cost
|
|
|
|
|
|
| |
- fixed issues for deletion of a db like remove all relevant items and refresh the navigator
- simplified and minimized code and memory usage while querying the connection structure
- whether a schema name is an unique db or table will be evaluated on run-time via allKeysofDbStructure
|
|
|
|
|
|
|
| |
- now it accumulates the data and caches them db by db, ie one has to select a db before using its structure for completion and navigator
- next step is to avoid querying info_schema as much as possible
- it will only query the structure if something was changed
- next steps follows as soon as possible
|
|
|
|
|
|
|
|
|
|
| |
- It is now a separate window like the console to enable monitoring.
- It now uses the same window style as the console.
- The ability to show or hide the process ID, column. This could possibly be enabled for some of the other columns as well, suggestions?
- The ability to enable or disable the use of SHOW FULL PROCESSLIST or just SHOW PROCESSLIST.
This implements most of the enhancements requested in issue #607, with the exception of the option to enable auto-refresh, which is still being worked on.
|
|
|
|
| |
preferences pane.
|
|
|
|
|
|
|
|
| |
List"
- if > 20 tables are listed it sets the focus on the search field
- if <= 20 it sets the focus on the table list, and - if no selection - it selects the first table item
- this fixes i597
|
|
|
|
|
|
| |
- make usage of a notification sent by the [MCPConnection queryDbStructure] to update the navigator, and this decouples a doc window and MCPConnection from the navigator
- minimized the tree update - now connectionID-based
- any tree update will be now performed on main thread and waits until done to avoid 'overlapping' updates triggered by different notifications which normally ended up in an inchoate tree display
|
|
|
|
|
|
|
| |
returning nil if no error occurred (previously a blank string was returned most of the time)
- Add a new (BOOL)[MCPConnection queryErrored] method, changing all error message checks to use it for clarity
|
|
|
|
| |
SPConstants.h/m.
|
|
|
|
|
|
|
|
|
|
| |
code for selecting databases and tables. Clean up database selection to use this new method, and avoid reloads when re-selecting the same database.
- Convert the history controller to use this new call. This fixes history behaviour when a table list filter was active.
- Convert the (hidden) navigator to use this new call. This fixes timing issues.
- Make some thread safety tweaks to TablesList.
- Change TablesList selectTableOrViewWithName: to selectItemWithName:, including procs etc.
|
|
|
|
|
|
|
| |
crashes when changing those keyvalues (eg changing query editor background colour after closing windows - http://log.sequelpro.com/view/44 )
- Fix a memory leak of a prefs reference in CMTextView
|
|
|
|
| |
the mysql.user table. If they don't display a warning message that they don't have the necessary privileges for user management.
|
|
|
|
|
|
|
|
| |
- gather more information
- show infos for proc/func
- improved error handling
- reduced jittering while closing a connection window
- still hidden - if navigator is not visible no navigator code will be executed
|
|
|
|
|
|
|
|
| |
address http://log.sequelpro.com/view/43 , http://log.sequelpro.com/view/46
- Improve keepalive timer interaction - this should address http://log.sequelpro.com/view/74 and http://log.sequelpro.com/view/71
- Further thread safety improvements to Custom Query, Table Document, and the history controller
|
|
|
|
|
|
|
|
|
|
| |
- added 'sync' mode - the navigator follows the active window db/table selection if navigator has not multiple selected items
- added drag support of selected items
-- as comma separated and backtick quoted string for external apps
-- as array of schema paths for SP
• CMTextView
- added drop support for selected items coming from the Navigator
- insert them as comma list relative to current selected db/table
|