| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
- committing Source
|
|
|
|
| |
count.
|
|
|
|
|
|
|
| |
would be greater than the total number of rows of the current table
• FIXED: if the user enters into "Limit from" a number which is greater than the total number of rows of the current table, show the last pref's "limitRowsValue" number of rows instead
• FIXED: if the user has already filtered the current table by specifying "Limit from" > 1 and afterwards the user applied a new filter the filtering will be repeated for LIMIT 0, "limitRowsValue" if nothing was found
|
|
|
|
| |
start and end
|
|
|
|
| |
tables which have already seen a column resized in the past. Looks like r389 incorrectly used arrays instead of dictionaries when cleaning up a memory leak.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
text view. This should significantly improve import speed, but most importantly resolves the crashes caused by the drawing that was being performed by the text view. Fixes issue #87 and implements #167.
New console provides the following:
- Live filtering
- Ability to hide message time stamps
- Ability to hide SELECT/SHOW statement messages
- Ability to copy messages to pasteboard, including multiple messages
- Ability to save the current filtered content to a file, with the option to include the message time stamps
|
|
|
|
|
|
| |
loaded)" in a gray color rather than " - text or blob -"
-the remove and duplicate buttons in table and browse view are now disabled when nothing is selected
|
|
|
|
| |
sortField and not referencing possibly deallocated column identifiers directly
|
|
|
|
|
|
|
|
| |
- added a backtickQuotedString: method to SPStringAdditions
- created the file SPArrayAdditions for a componentsJoinedAndBacktickQuoted: method
In the future, we should use backtickQuotedString: to quote identifiers like this:
[NSString stringWithFormat:@"SELECT * FROM %@", [tableName backtickQuotedString]]
|
|
|
|
|
| |
Changes after code review: renamed variable, replaced @"NULL" with [prefs objectForKey:@"nullValue"]
|
|
|
|
|
|
|
|
|
|
| |
Fixed - If you attempt to duplicate a row in tables where blob/text data is present but hidden and there are no
keys, SP correctly pops up the dialog but then continues execution, and so crashes.
Fixed - If the row being duplicated contains NULL data, exceptions triggered by [NSNull length] are thrown, and SP
stops responding.
Thanks to Rowan for code review
|
| |
|
|
|
|
|
|
| |
#198 Older-Younger swapped meaning
|
|
|
|
|
|
|
| |
was switched off inserted the wrong value for autoincrement columns, throwing exceptions and breaking SP
- Fix a bug in the autoincrement check which exposed the bug above even when no autoincrement was set.
|
| |
|
|
|
|
|
|
|
| |
- Improves on r370 and r375 by preventing actions triggered by the save from triggering saves themselves
- Improves further on r370 and r375 by committing any current edits before saving
- Additional comments
|
|
|
|
|
|
|
|
|
| |
image deletions, and image drag and dropping (fixes Issue #85 and google groups report)
- Improves compatbility of drag-and-drops onto the image well, including support for image drags from other applications
- Attempt to automatically select the image or text tab in the edit sheet as appropriate
- Fixes build-from-clean warnings caused by an unexposed function added in r375
|
| |
|
|
|
|
|
|
|
|
|
| |
Issue #155)
- Added basic support for viewing, filtering, and editing BIT columns (resolves Issue #127 in basic form)
- Rewrites selection/save handling. Rows are now only written to database if their content has changed, resolving a long-standing complaint; row selection and editing has also been improved, improving edit/save interaction (fixes Issue #157) and allowing re-editing of the row on failure (fixes Issue #115). Hopefully also addresses #Issue 131, and improves Issue #172.
- Hides the console window when the associated document window closes
|
|
|
|
| |
option of fetching the accurate row count and limiting the result, results in the displayed row count being zero. Caused by fetching the count as the number of items in the fullResult array which hadn't been populated yet. If we are displaying the entire contents of the table set the count to the count of the fullResult array rather than relying on the numRows variable as the array is now populated.
|
|
|
|
|
|
|
|
|
| |
panel also adds the ability to save the current console content to a file on disk. Speed up the updating of the text view by removing the re-draw of the view after each message is appended. The console is still very basic, but is a starting point for more functionality to be added now that it is all handled in a single class.
+ Add the ability to specify the encoding when creating a new database. Addresses issue #125. Also improve the usability of the create database sheet by only enabling the 'Add' button if the database name length is greater than zero. This elimates the check that is done and the error panel that is displayed if the name is empty.
|
|
|
|
|
|
| |
- Added 10.4 (Tiger) support for varchar/char length limits
Related to Issue #170
|
|
|
|
| |
Ideally we should add these limits for other field types depending on their length value.
|
|
|
|
| |
certain tables and views. (Thanks to Marius Ursache for this patch)
|
|
|
|
| |
instead of breaking display when an NSData object can't be encoded, in the style of the -text or blob- placeholder.
|
|
|
|
|
|
|
| |
sheet shows its state correctly (fixes Issue #169)
- Fixes editing with "Don't load blob and text fields" preference enabled by fixing an incorrect method call
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Significantly reduce the queries that have to be performed, improving lag - especially over slow connections (Issue #118; see new controller info under headline code changes).
- Fix Issue #117 properly (export numeric quoting - we now have access to column types and so can quote appropriately).
- Fix Issue #145 (loss of unsigned/null/default attributes when reordering columns).
- Fixes Issue #90 (support for filtering DECIMAL column types)
- Improve table scrolling speed when the table contains long items. (Added a NSFormatter to automatically truncate strings > 150 chars for display purposes only)
- Improved SQL compatibility - for example /* C style comments */ are now correctly ignored in imports and custom queries.
- Add text and symbols emphasising that the table info pane / status view row count is an approximation (partially addresses Issue #141)
- Fixes a major memory leak whenever opening or scrolling tables containing text/blob data.
- SQL import is now faster (SQL parsing part is 3x faster).
- Speed up SQL export (1.5x faster for numeric data; 1.1x faster for string data) and slightly speed up CSV export (~1.1x faster).
- Display sizes on the status view using the byte size formatter, as per table info pane.
Headline code changes:
- Add a new NSMutableString subclass, SPSQLParser. See the header file for documentation and overview, but in short it's a centralised place for SQL parsing. Centralises and improves parsing, improves comment support, improves quoting support. Despite the improved featureset this is also faster than the previous distributed implementations - for example, when used to replace the old splitQueries:, > 3x speedup.
- Implement a new controller which handles a structure and status cache for the current table, and provides structure parsing for specified tables. This cache is now used throughout the code, reducing the queries that have to be performed and providing additional information about the table structure for use; I think it also improves column type format slightly.
- The table info pane and the status view now draw all their data from the cache.
Tweaks:
- Table encoding is now detected directly instead of being derived from the collation - increased accuracy and cope with the DEFAULT encoding.
- Comments and formatting cleaned up in bits I was working on, obviously.
- A couple of methods - particularly [tablesListInstance table] and [tableDocument encoding] - have been renamed to avoid conflicts and fix code warnings.
Future improvements now possible:
- As we now have access to column types and other information, we can provide per-type behaviour where desired.
- The table parsing doesn't currently pull out comments or table indices, together with one or two other attributes. Some of this would be useful for display; some, such as indices, could be used to draw the table structure view as long as we're happy discarding a couple of columns (ie cardinality!)
|
|
|
|
| |
be returned. Fixes #151.
|
|
|
|
| |
SQL is failing.
|
| |
|
|
structure.
|