| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
is NULL.
|
|
|
|
| |
(introduced while fixing #2418) (see also #2229)
|
|
|
|
|
|
| |
changed when editing users (part of #2229)
(This also removes an additional db roundtrip when updating per-db user privileges that previously was needed to differentiate between user actions „Only removing privileges from user“ and „Backtracking on adding privileges to user“. Since we now only update changed values and the latter one would be an empty changeset this is no longer needed)
|
| |
|
|
|
|
| |
time would result in a query error (#2427)
|
|
|
|
| |
* Upgrade xcdatamodel to Xcode 4.3+ so it becomes a diffable textfile
|
|
|
|
|
| |
* Change user manager code so that mysql queries are executed on validation instead of after save (in Core Data, not mysql). This should in general make more sense since a failure in MySQL essentialy means that Core Data can't save it either (but did anyway in the past).
* Remove a deprecated method call that is no longer needed in 10.6+
|
|
|
|
| |
This should also eliminate a few use-after-free crashes
|
| |
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
|
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
|
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Namely this commit changes two things:
1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491):
[NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release
[[self window] orderOut:self];
This call order has now been swapped.
2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority.
Requesting QA on this commit.
|
| |
|
| |
|
|
|
|
| |
discards qualifiers
|
|
|
|
|
|
|
|
|
| |
- Rework how data to populate the user manager is retrieved from the server, speeding up display of lots of users by a large factor
- Fix support for schema permissions for the Anonymous user, and add support for '%' and '' hostnames (only showing if already set once), fixing Issue #1620
- Highlight databases in the user manager that have permissions set for the selected user
- Switch to using the centrally provided database list to reduce queries and remove the information_schema and performance_schema "databases"
- Speed up a number of operations by tweaking the logic and queries used
|
|
|
|
| |
save/cancel/tab switch is still triggered, addressing Issue #1627
|
| |
|
|
|
|
| |
minumum value of zero.
|
|
|
|
| |
UserManagerView, replacing with SPSplitViews and standard equivalents
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
- Potential framework header build fix.
|
|
|
|
| |
updating the mysql.user table. Fixes issue #1285.
|
| |
|
|
|
|
| |
user manager changes.
|
| |
|
| |
|
|
|
|
|
|
| |
- Return User Manager details as strings as some result types are marked as binary; fixes opening of user manager
- User manager schema list is now a list of databases instead of a list of database dictionaries with one key; simplify model to match
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
|
|
|
| |
exceptions redrawing the offscreen outline rows, addressing http://spbug.com/l/1406 .
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
in a single sheet for review. This fixes a number of isGroupRow crashes on any error.
- Track a host row's original host to allow host edits
- Update localisable strings
|
|
|
|
| |
available & granted
|
| |
|
|
|
|
|
|
|
| |
privileges (or removing all privileges) at once, the server treated the list of all options as 'GRANT ALL', instead of GRANT ALL WITH GRANT OPTION.
- Update localisable strings files
|
|
|
|
|
|
|
|
| |
improves handling of special characters in passwords, improving Issue #890
- Improve code in (the unused) [MCPConnection connectWithLogin:password:host:socket:] to match latest updates in the rest of the framework
- Fix creation of new users
|
|
|
|
|
|
|
|
| |
- to enable Find Panel in such a NSTextView which will be displayed in a sheet one has to do the following:
* [main problem is that Find Panel validates its buttons against [[NSApp mainWindow] firstResponder] == NSTextView]
* subclass the NSTextView and add the methods becomeFirstResponder and resignFirstResponder which has to return YES
* since the last first responder remains the first mainWindow responder status one has to set [[NSApp mainWindow] makeFirstResponder:theTextView] directly after displaying the sheet
• corrected SPUserManager message in (IBAction)removeHost:
|
|
|
|
|
|
|
|
| |
- Prepare for the implementation of PDF and HTML export by hiding the export options box for export types that don't need it.
- Fix some spacing issues on the export dialog.
- Create a new SPCategoryAdditions header that is included in the apps precompiled header, making all additions available to all classes.
- Update strings files.
|
| |
|
|
|
|
|
|
|
| |
- When adding a new host specify 'PASSWORD' after 'IDENTIFIED BY' to indicate to the server that the password has already been hashed. Fixes issue #856.
- Localize and replace a few modal error dialogs with use of SPBeginAlertSheet().
- Fix an error when specifying empty passwords for users.
|
|
|
|
| |
console.
|