| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
fixes #2049
|
| |
|
| |
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
|
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
|
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It might be useful to keep this setting on globally, but smart quotes break
SQL, resulting in the requirement of having to do an undo-type-undo dance to
force the editor to not replace the single (') and double (") quote
characters with the ‘, ’ and “, ” characters, respectively. Since we
can presume that no one will want to use these non-SQL quotation marks
within SQL unless they explicitly decide to do so (in matching a varchar
field, for instance), they should be off by default. Additionally, the
double-dash (--) is used in SQL for inline comments, which gets substituted
for the em-dash (—). Disabling this seems to be a good idea on the same
argument.
More info about text substitution: http://support.apple.com/kb/PH14294
|
|
|
|
|
|
| |
Add menu item "MySQL help for Word/Selection", with Control-H as the
default key equivalent
Delete SPTextView's built in handling of Control-H key presses
|
| |
|
| |
|
|
|
|
| |
enable some more
|
|
|
|
| |
should conform to.
|
| |
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| | |
duplicated in multiple places.
|
|/ |
|
|
|
|
| |
in the Custom Query Editor (among others) as the selection is changed with the mouse
|
|
|
|
| |
different function, to allow "Highlight current query" to function again
|
|
|
|
|
|
|
|
| |
linebreak
- Tweak autocomplete poup to show the text positioned underneath the target word
- Consolidate code
|
|
|
|
|
|
|
|
| |
through to black or the window background, addressing incorrect colours in the Custom Query view when using selection colours with alpha values and window backgrounds showing through CREATE SYNTAX sheets (Issue #1099)
- Fix crashes when editing certain colours in editor preferences after a window had been closed, due to not unregistering all observers on SPTextView dealloc
- Enable "Draws Background" on the main Custom Query view text view, as custom colours were no longer being drawn after a change in r3750
|
|
|
|
|
|
|
|
| |
redesigning the advanced Content Filter window
- Tweak SPTextView to support translucent views, or views which are set not to draw their background
- Fix Lion compatibility for advanced content filter default operator (Issue #1255)
|
| |
|
| |
|
|
|
|
| |
dependency on SP specific code and all the tests to build successfully.
|
| |
|
|
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the functionality required from MCPKit and is based around its interface for relatively easy integration.
Externally visible changes as a result of this merge:
- Speed improvements, particularly when loading large data sets
- Stability improvements, particularly related to connection state after the connection is dropped (eg Issue #1256)
- Improved support for new MySQL data types, which should address Issue #1052.
- Database structure retrieval and query cancellation now use a single persistent helper connection instead of lots of connections on-demand. This should help Issue #1097.
- More internal commands now use queries instead of MySQL functions; for example USE queries are now used to trigger database selection, improving transcripts. This addresses Issue #1247.
- Improved internal encoding work; while this needs support within the UI, it lays the foundation for issues like Issue #1280.
Code improvements:
- Much improved class layouts including extensive category usage
- Improved documentation across framework methods
- Support for fast enumeration across result objects
- Rewrite fixes use of a number of deprecate functions
- Much less code duplication across result set types
- Improved encapsultation within the framework, limiting the number of methods exposed, and also not exposing all the MySQL headers
From the Readme file:
The SPMySQL Framework is intended to provide a stable MySQL connection framework, with the ability to run text-based queries and rapidly retrieve result sets with conversion from MySQL data types to Cocoa objects.
SPMySQL.framework has an interface loosely based around that provided by MCPKit by Serge Cohen and Bertrand Mansion (http://mysql-cocoa.sourceforge.net/), and in particular the heavily modified Sequel Pro version (http://www.sequelpro.com/). It is a full rewrite of the original framework, although it includes code from patches implementing the following Sequel Pro functionality, largely contributed by Hans-Jörg Bibiko, Stuart Connolly, Jakob Egger, and Rowan Beentje:
- Connection locking (Jakob et al)
- Ping & keepalive (Rowan et al)
- Query cancellation (Rowan et al)
- Delegate setup (Stuart et al)
- SSL support (Rowan et al)
- Connection checking (Rowan et al)
- Version state (Stuart et al)
- Maximum packet size control (Hans et al)
- Result multithreading and streaming (Rowan et al)
- Improved encoding support & switching (Rowan et al)
- Database structure; moved to inside the app (Hans et al)
- Query reattempts and error-handling approach (Rowan et al)
- Geometry result class (Hans et al)
- Connection proxy (Stuart et al)
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Add a ping keepalive managing object to prevent retain cycles from the NSTimer
- Add -[SPMySQLConnection copy] support
- Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness.
- Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
|/ |
|
|
|
|
| |
cause for some unknown reasons an exception
|
| |
|
| |
|
|
|
|
|
|
| |
from origin {0,0}; now it's synchronized
• minor speed ups for custom query editor
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
keyboard focus is on the favorites outline view (Issue #1072)
- Don't initiate a connection when the currently selected favorite is clicked again slowly
- Match compiler #ifdef around braces to imrpove Xcode 3 file parsing
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
postNotificationOnMainThread: which also exists in TCMPortMapper.framework; NSUserDefaults access now permitted in SP_REFACTOR blocks for a few prefs keys
|
|
|
|
|
|
| |
- Fix a few encoding issues
- Recode a few [NSApp keyWindow] uses back to [SPDatabaseDocument parentWindow] following discussion; possibly for later refactoring into use of an error method
|
|
|
|
| |
UI code from functional code
|
| |
|