| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Depening on your diff tool (Kaleidoscope and Tower are pretty bad, AppCode works well) this change might look big, but all I did was remove two levels of else { } by using return; instead.
|
| |
|
| |
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
|
|
|
| |
(Also deduplicated some code)
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
|
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
|
|
|
| |
This is implemented as an alternate menu item, ie. it will appear when holding down the Option (alt) key instead of the normal "Open Table in new Tab" item. Fixes #2015
|
| |
|
| |
|
| |
|
|
|
|
| |
disabling the add index option. Fixes issue #1546.
|
|
|
|
| |
(http://spbug.com/l/1726)
|
|
|
|
| |
enable some more
|
| |
|
|
|
|
| |
re-enable foreign checks. Also, provide a more helpful error message when a table cannot be deleted because of foreign key constraints.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
the focus to the Filter Content tab bar. ⇧⌘F is used to show the advanced content filter table. This allows ^⌘F to be used for the standard OS X fullscreen window command, addressing Issue #1513.
|
| |
|
|
|
|
| |
selected.
|
| |
|
|
|
|
|
|
|
|
|
| |
responders in an expanding view at the end of the animation
- On initial launch, and when changing database, ensure that the window focus is set to the table list or the table list filter or the table list as appropriate. This addresses Issue #1437.
- Clean up some logic
|
| |
|
|
|
|
|
|
|
|
| |
allow us to remove BWToolKit. Supports constraints and animated collapsible subviews configured in code, fixes crashes and exceptions if a window is closed while animations are taking place or scheduled to take place.
- Replace the two vertical splitters in the table list (the filter splitter, and the table info splitter) with SPSplitView implementations as a test
- Add a helper method in the new SPDateAdditions
|
|
|
|
|
|
|
|
|
| |
- Make the default sheet width wider
- Change "Default" encoding to "Inherit from database" to clarify the action of the menu item
- Fix retrieval of default table type on recent MySQL versions
- Fix retain of default server table type
This should address Issue #1377.
|
|
|
|
| |
new table sheet. Implements issue #1245.
|
| |
|
|
|
|
| |
hooked up yet. Part of issue #1235.
|
| |
|
| |
|
|
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
| |
|
|
|
|
| |
from the project, and replace with an MIT-licensed TCMPortMapper sources NSNotificationCenterThreadingAdditions category. This should fix method clashes in the SP_REFACTOR project, so remove behavioural/namespacing switches.
|
|
|
|
|
|
| |
- Fix background database structure checks throwing exceptions at the end of certain table operations
- Fix incorrect timer access/overrelease when closing a SPNarrowDownCompletion window when database structure fetching is active
|
|
|
|
|
|
|
|
| |
- Add a ping keepalive managing object to prevent retain cycles from the NSTimer
- Add -[SPMySQLConnection copy] support
- Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness.
- Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
|
|
|
| |
cycles caused by manually loading libs with bindings to File's Owner are automatically handled, fixing leaks of SPConnectionController and items it retain including any MCPConnection; this will fix issues with MCPConnections attempting to reconnect but no longer having an associated SPDatabaseDocument
|
|
|
|
| |
engine/type being quoted.
|
|
|
|
| |
.strings files)
|
|
|
|
| |
by loading the new table and loading the structure tab on different threads (log #2266)
|
| |
|
|
|
|
| |
knocked out in r3376.
|
|
|
|
| |
http://spbug.com/l/2360 and http://spbug.com/l/2453
|
| |
|
|
|
|
| |
to plain text matching; thanks to Emma Persky for the original patch
|