| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
This should also eliminate a few use-after-free crashes
|
| |
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
| |
|
| |
|
| |
|
|
|
|
| |
enable some more
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
preventing the correct saving of the edited trigger thereafter (Issue #1534)
- Clean up interface resetting and validation to fix edge cases where the interface was not reset correctly or carried state incorrectly across multiple selections
- Fix a small memory leak when editing multiple triggers
- Clean up code
- Remove the table name column in the triggers interface as it will always display the selected table
- Display NULL values in the triggers interface using the preference setting, and in grey
|
|
|
|
|
|
|
|
| |
window if a trigger can't be saved so that new statements can be fixed
- Fix editing of triggres failing when some MySQL versions append nul bytes to the statement results
- Retain the edited trigger details to fix crashes on 10.8
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
|\ |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
| |
|
| |
|
|
|
|
| |
add new rows/records
|
| |
|
|
|
|
|
|
|
| |
- Improve trigger deletion error process to show error sheets correctly
- Fix spelling of "Statement" in interface
- Tweak trigger column widths
|
|
|
|
|
|
|
|
|
| |
columns in views
- In SPTableStructureDelete, don't request the encoding if the table is reloading; this prevents multithreaded data fetches and race conditions causing Issue #974.
- Alter SPTableData to use thread mutexes instead of a boolean to prevent threading issues, which also fixes Issue #974 in a different way. Alter race condition checks to block their threads instead of returning bogus information to prevent state issues.
- Alter table loading to no longer load trigger information until required, speeding up use of other views and cleaning up the console log.
|
|
|
|
|
|
|
|
| |
- Prepare for the implementation of PDF and HTML export by hiding the export options box for export types that don't need it.
- Fix some spacing issues on the export dialog.
- Create a new SPCategoryAdditions header that is included in the apps precompiled header, making all additions available to all classes.
- Update strings files.
|
| |
|
| |
|
| |
|
|
|
|
| |
re-creating it, if an error occurs when attempting to re-create it remember to then re-create the original one. Fixes issue #795.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811
Other changes include:
- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.
|
|
|
|
| |
- this fixes issue 841
|
|
|
|
|
|
|
| |
TRIGGER query due to possible localizations, instead make usage of selected indices
- fixes i829
- some code cleaning and commenting stuff
|
|
|
|
| |
the work started in r2201 and should address Issue #748.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pops up
with all the fields prepopulated.
Edit works as 'DROP' old trigger and then 'CREATE' new trigger (since MySQL doesn't
have support for 'ALTER' trigger).
In case of error while adding the new trigger, when you add a new trigger, all the
info from the original trigger is preserved. (Don't know if this is the best solution).
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
- Addition of PSMTabBar framework
- Rework away from a document-based TableDocument
- Support tabs throughout the application
- Add menu items for creating tabs, and add support for dragging tabs to different windows
|
|
|
|
|
|
|
| |
- Change MCPConnection.m to no longer use a reference to tableWindow to attach sheets - instead use a delate error display method if available
- Rework TableSource and TableContent sheetDidEnd methods into per-task methods rather than overloading contextInfo
- Rework SPAlertSheets to perform actions on the main thread, with the loss of (unused) support for a didDismissSelector. This addresses a number of crashes logged by the crash reporter
|
|
|
|
|
|
|
| |
- Trigger queries are no longer made for MySQL < 5.0.2
- Trigger loading has been deferred until the trigger tab is active, reducing queries when switching tables and thus increasing overall responsiveness
- Export triggers in MySQL dumps even if the Table Content switch is unchecked
|
| |
|
|
|
|
| |
or function disable all interface controls.
|
|
|
|
|
|
|
| |
returning nil if no error occurred (previously a blank string was returned most of the time)
- Add a new (BOOL)[MCPConnection queryErrored] method, changing all error message checks to use it for clarity
|
|
|
|
| |
SPConstants.h/m.
|
|
|
|
|
|
|
| |
crashes when changing those keyvalues (eg changing query editor background colour after closing windows - http://log.sequelpro.com/view/44 )
- Fix a memory leak of a prefs reference in CMTextView
|
|
|
|
| |
generation performance improvements.
|
|
|
|
| |
support for them was initially added.
|
|
|
|
| |
via Cmd+6). Note, that better support for entering the trigger statement in terms of escaping and delimiter support most likely needs to be added.
|
|
menu item View > Table Triggers (apple-6).
Heavily copied from Relations tab, lots of functionality missing. Just
lists the triggers for the table now.
M Source/SPTableData.m
M Source/SPConstants.h
M Source/SPConstants.m
A Source/SPTableTriggers.h
A Source/SPTableTriggers.m
M Source/TableDocument.h
M Source/TableDocument.m
M Source/SPTableData.h
M Interfaces/English.lproj/MainMenu.xib
M Interfaces/English.lproj/DBView.xib
M sequel-pro.xcodeproj/project.pbxproj
|