| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
is currently being edited and can't been saved cleanly. Addresses at least http://spbug.com/l/735 .
|
|
|
|
|
|
|
| |
had crept into the source, replacing with the correct [NSWindow makeFirstResponder:NSTableView]. This fixes a number of exceptions.
- Update localisable strings.
|
|
|
|
| |
• Field Editor Sheet field name label also displays NOT NULL if set
|
|
|
|
|
|
|
|
|
|
| |
single function in each class
- Tweak NSTableView subclasses to catch presses of the Escape key and ask the class to abort row editing. This makes Esc key behaviour much more consistent, and allows cancelling/reverting edits made via the mouse (eg checkboxes, dropdowns, enums), or after the cell editing has finished but the row is still selected.
- Remove debug
- Update localisable strings
|
|
|
|
|
|
| |
• re-enabled length checking while editing in FieldEditorSheet
• FieldEditorSheet now shows field type declaration
• some preparations for BINARY editing in FieldEditorSheet
|
| |
|
|
|
|
|
|
|
| |
BIT(63) since the old _int2bin routine didn't work because we're dealing with a char* containing bytes if BIT(>8)
- also for views and CustomQuery editing
• started to clean up (VAR)BINARY editing (work in progress)
|
|
|
|
|
|
|
| |
tables as well; this fixes caching of table row count in certain combinations of table sizes and preference values, and should fix Issue #673.
- Add a missing Errors.strings localisable strings table
|
|
|
|
|
|
|
|
| |
(now rolled into argumentForRow: for centralised logic), addressing Issue #791
- Update table row count at bottom of window when deleting rows in the content view
- Update localisable strings
|
|
|
|
| |
avoid calls on released objects; this addresses http://spbug.com/l/1408, http://spbug.com/l/254 and http://spbug.com/l/781
|
| |
|
|
|
|
| |
of the first page, the previous row count was not correctly reset, thus sometimes triggering an exception. This correctly resets the count, addressing http://spbug.com/l/558
|
|
|
|
|
|
|
| |
- simplified code
- reduced number of queries for edit status
- WHERE argument to identify first try to avoid using blob data for speed, if field is not identified with ignoring blob data then use blob data as well
|
|
|
|
|
|
|
|
| |
- simplified code
- reduced number of queries for edit status
- WHERE argument to identify first try to avoid using blob data for speed, if field is not identified with ignoring blob data then use blob data as well
• for TableContent fixed tooltip display
- note: improvements as for CustomQuery follow soon
|
| |
|
|
|
|
|
|
|
|
|
| |
avoid the trampoline exceptions
• unified error message while cell editing
• in Custom Query table cell editing errors are displayed as tooltips and added these message if edit event comes from the keyboard
• fixed: check edit status in Content Tables only for views to avoid unnecessary queries
• used [SPCustomQuery fieldEditStatusForRow:andColumn:] consequently to simplify code
|
|
|
|
|
|
|
|
|
|
|
| |
with extended characters in MySQL identifiers (names of dbs/tables/cols):
- Move encoding queries and control into MCPKit, with newly cleaned-up methods, and switch a number of locations to using the new code.
- Use UTF8 connections for many identifier-based queries (selecting and listing databases, tables, stored procs, table information). This fixes selection and creation of table and database names containing extended characters, also fixing exceptions and errors.
- Improve UTF8 over Latin1 to correctly set the client character set encoding as well, fixing custom queries and edits; remove custom code in SPTableContent achieving the same thing in a single location.
- Fix database encoding detection routines
- Update localisable strings
|
|
|
|
|
|
| |
modify a cell
• in Custom Query table after field editor sheet dismissing preserve the the edited field selection
|
|
|
|
|
|
|
|
| |
data in Content tables
- now each cell can be selected via keyboard navigation regardless whether it's editable or not; only if the user tries to modify it then it will be checked if it's editable or not - for speed while navigation
- fixed issue for view data editing to show blobs in editor sheet if user wants to modify it
- Note: still work on progress
|
|
|
|
|
|
|
|
|
|
| |
since we need that for Content and Custom Query table; only class specific stuff like ESC trapping will handled in the actual class
• enabled in cell editing for Custom Query tables
- also added spreadsheet button to Custom Query status bar
• fixed ESC trapping: F5 can be used for completion
• simplified [SPCopyTable keyDown:] for trapping ENTER/RETURN key
• some code cosmetics
|
|
|
|
|
|
|
| |
- by clicking a the same table header the sort will changed to desc, asc, no sort order, desc, asc, etc.
• fixed sorting issue for Custom Query table
- reset sort order status before executing a new custom query
• code cosmetics: reduced file size for SPCustomQuery.m
|
|
|
|
| |
- If enum field is edited RETURN selects the new value instead of saving the entire row
|
|
|
|
|
|
|
|
|
|
| |
shortStringRepresentationUsingEncoding] after simplifying the code
• fixed NSAutoreleaseNoPool(): SPMainThreadTrampoline autoreleased with no pool in place - leak while canceling a print job
- call [self endTask] BEFORE [pool drain]
• in SPTableContent set the focus to table after editing a cell by the field editor sheet on main thread
- this could fix exception 1481
• some code cosmetics: reduced file sizes
|
|
|
|
|
| |
- disable ↑ and ↓ for jumping the next table cell if current cell is a enum field to allow to use the arrow keys for selecting an item from the list
- Note: ?\018↩ handling has to be improved here! (coming soon)
|
|
|
|
|
|
|
| |
- now it selects any field (if it's editable for views) regardless whether the field is a blob
- if user tries to edit a blob field the field editor sheet will occur for editing
• after cancellation of cell editing in the Content Window table preserve the focus on the table
• minor code cosmetics for editing of data coming from a view in Content Window
|
|
|
|
|
|
|
|
|
|
| |
active)
• view data editing
- disable add/duplicate/remove row for views
- first improvements for editing navigation via keyboard
- after editing avoid relaodTable instead use loadTableValues
- outsourced: (NSInteger)fieldEditStatusForRow:andColumn: since it will be used for keyboard editing navigation
|
|
|
|
| |
- if multipleLineEditingButton is set to on or field is a blob field allow to show the field data as non-editable fieldEditorSheet if field is not editable
|
|
|
|
|
| |
- fixed: call endTask for the current progress spinner if while editing a field the data were changed meanwhile
- fixed line breaking of some long tooltips
|
|
|
|
|
|
| |
- the editing is field based as for Custom Query editing
- shouldEditRow checks if the clicked field can be identified unambiguously
- CAUTION: This must be tested heavily before releasing!! Esp. any kind of threading issues and progress spinner stuff for slower connections
|
|
|
|
|
|
|
|
|
| |
[aString appendString:[NSString stringWithFormat:]] by
[aString appendFormat:]
since it's much more faster
• first look at loop where several [aStr appendString:] occur to try to combine them into one appendString or appendFormat since the allocation of memory takes really time
Note: I tested all my changes but we should test it further to be sure that I didn't a mistake!
|
| |
|
|
|
|
|
|
|
|
| |
- Move Table Content progress tracking onto the main thread's load timer
- Improve thread safety when autosizing
- Improve autosize to not contrain wide columns as much in tables where all columns can be shown, or if the column is double-clicked to size.
(This completes work on Issue #271 and Issue #272)
|
|
|
|
|
|
|
|
| |
- Add automatic column sizing (for columns without saved widths) as part of the value loading process
- Rework table updates to be timer based, for time-based and more regular updates. This improves speed and allows tables to update more consistently.
This results in overall smoother table loads, faster table loads, and autosizing columns. This partially implements Issues #271 and #272.
Column autosizing will likely be tweaked, and this will all also be extended to Custom Query views in a future patch.
|
|
|
|
| |
all rows in a table
|
|
|
|
|
|
|
|
|
| |
- Exporting BIT fields properly in SQL dumps using b'x' notation.
- Properly handling editing of BIT fields in both the content and custom query results views.
- Correctly display BIT fields in the content view, where binary values are zero-padded to the specified length of the field.
(Note, that the new BIT handling logic has only been added to MCPKit's MCPStreamingResult and MCPResult as the latter does not keep a record of the field's length which the new functionality depends on. Needs to be discussed).
|
| |
|
|
|
|
|
|
|
|
|
| |
to restore it
• do not save tabs or a single window if connectionController is shown
• added comments
• added to SPTableContent method "tablesListWidth" to retrieve tablesList's view width
|
|
|
|
|
|
|
|
| |
- Move the custom filename options view to a drop down view on the main exporter dialog.
- Change the export data source matrix to a popup button.
- Fix the export button being enabled when no tables are selected to be exported.
- Various interface validation fixes.
|
|
|
|
| |
logged exceptions for beyond-bound index accesses
|
|
|
|
|
|
|
| |
the interface being updated from the wrong thread on listeners
- Add a "Support Files" folder to MCPKit, containing NSNotificationAdditions to support main thread notifications from within MCPKit
|
| |
|
|
|