aboutsummaryrefslogtreecommitdiffstats
path: root/Source/SPNarrowDownCompletion.m
Commit message (Collapse)AuthorAgeFilesLines
* merge SPQueryController (part of #2789)Max2018-01-201-1/+0
|
* The export code caused an exception when no database was selected but the ↵Max2015-06-161-1/+1
| | | | filename contained the database token (fixes #2145)
* Minimal refactoringMax2015-03-091-1/+1
| | | | Replaced some (range.location + range.length) with NSMaxRange(range)
* Addition to commit 2735e15bMax2015-01-041-17/+12
|
* Formalize [x release], x = nil; conventionMax2015-01-041-1/+1
| | | | | Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it. Feel free to revert this commit if you see issues with the approch or implementation.
* Replace some NSDictionaries with literalsMax2014-12-131-3/+3
| | | | | | * [NSDictionary dictionary] → @{} * [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past. * Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
* Add pref to disable backticks in completionsAbhi Beckert2014-09-061-1/+5
| | | | | | | Add a checkbox to the Editor preferences to disable placing backticks around attributes when completing in the custom query pane. Resolves #764
* Update URL in source file header to point to GitHub.Stuart Connolly2014-01-261-1/+1
|
* Remove SVN property placeholder.Stuart Connolly2014-01-261-2/+0
|
* Changing SP_REFACTOR macro to SP_CODAsqlprodev2013-02-141-5/+5
|
* - Convert all old .tiff resource images to .png formatrowanbeentje2012-12-211-6/+6
| | | | | | | - Recompress all pngs losslessly to reduce disk use slightly - Remove old unused images - Switch some code over to imageNamed: to allow easier Retina additions in future
* Change Sequel Pro's license from GPL (version 2) to MIT.stuconnolly2012-07-251-17/+23
|
* Fix more gcc warnings.stuconnolly2012-05-091-14/+14
|
* - Add the enter key and right arrow key to the list of keys that will ↵rowanbeentje2012-04-191-1/+1
| | | | select the current autocompletion suggestion if the suggestion list is open, rather than performing their default actions. This addresses Issue #1321.
* - Fix crashes on use of custom query autocompletion when the database ↵rowanbeentje2012-04-141-2/+3
| | | | structure is still being retrieved
* Merge in the SPMySQL Framework. This new framework should provide much of ↵rowanbeentje2012-03-171-6/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the functionality required from MCPKit and is based around its interface for relatively easy integration. Externally visible changes as a result of this merge: - Speed improvements, particularly when loading large data sets - Stability improvements, particularly related to connection state after the connection is dropped (eg Issue #1256) - Improved support for new MySQL data types, which should address Issue #1052. - Database structure retrieval and query cancellation now use a single persistent helper connection instead of lots of connections on-demand. This should help Issue #1097. - More internal commands now use queries instead of MySQL functions; for example USE queries are now used to trigger database selection, improving transcripts. This addresses Issue #1247. - Improved internal encoding work; while this needs support within the UI, it lays the foundation for issues like Issue #1280. Code improvements: - Much improved class layouts including extensive category usage - Improved documentation across framework methods - Support for fast enumeration across result objects - Rewrite fixes use of a number of deprecate functions - Much less code duplication across result set types - Improved encapsultation within the framework, limiting the number of methods exposed, and also not exposing all the MySQL headers From the Readme file: The SPMySQL Framework is intended to provide a stable MySQL connection framework, with the ability to run text-based queries and rapidly retrieve result sets with conversion from MySQL data types to Cocoa objects. SPMySQL.framework has an interface loosely based around that provided by MCPKit by Serge Cohen and Bertrand Mansion (http://mysql-cocoa.sourceforge.net/), and in particular the heavily modified Sequel Pro version (http://www.sequelpro.com/). It is a full rewrite of the original framework, although it includes code from patches implementing the following Sequel Pro functionality, largely contributed by Hans-Jörg Bibiko, Stuart Connolly, Jakob Egger, and Rowan Beentje: - Connection locking (Jakob et al) - Ping & keepalive (Rowan et al) - Query cancellation (Rowan et al) - Delegate setup (Stuart et al) - SSL support (Rowan et al) - Connection checking (Rowan et al) - Version state (Stuart et al) - Maximum packet size control (Hans et al) - Result multithreading and streaming (Rowan et al) - Improved encoding support & switching (Rowan et al) - Database structure; moved to inside the app (Hans et al) - Query reattempts and error-handling approach (Rowan et al) - Geometry result class (Hans et al) - Connection proxy (Stuart et al)
| * More bugfixes to the SPMySQL integration branch:rowanbeentje2012-03-141-0/+2
| | | | | | | | | | | | - Fix background database structure checks throwing exceptions at the end of certain table operations - Fix incorrect timer access/overrelease when closing a SPNarrowDownCompletion window when database structure fetching is active
| * Final feature work on the SPMySQL branch before merging:rowanbeentje2012-03-141-6/+9
| | | | | | | | | | | | | | | | - Add a ping keepalive managing object to prevent retain cycles from the NSTimer - Add -[SPMySQLConnection copy] support - Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness. - Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
| * - Bring SPMySQL Framework integration branch up to date with trunkrowanbeentje2012-03-051-0/+7
| |\ | |/ |/|
| * Warning: this branch commit is largely untested, and known to throw ↵rowanbeentje2012-02-231-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | exceptions as database structure retrieval is currently missing! Further work on SPMySQLFramework integration: - Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match - Add new convenience querying and result methods to the framework - Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions - Remove MCPKit from the source - Fix a number of warnings on Release-style builds
* | - Fix a retain cycle in SPNarrowDownCompletion popups while the structure ↵rowanbeentje2012-03-041-0/+7
|/ | | | is being retrieved
* Tidy up console/query controller.stuconnolly2011-09-031-0/+1
|
* - Cancel and clear autocomplete if a keyboard combo is being run - this ↵rowanbeentje2011-08-301-0/+3
| | | | fixes Issue #1119
* - Fix issues undoing past an autocompletion type-through, addressing ↵rowanbeentje2011-08-261-0/+2
| | | | exceptions (log #1847)
* Fixes source text encoding problems accidentally introduced in r3273sqlprodev2011-04-141-1/+1
|
* SP_REFACTOR: Workaround for naming conflict with ↵sqlprodev2011-04-141-1/+1
| | | | postNotificationOnMainThread: which also exists in TCMPortMapper.framework; NSUserDefaults access now permitted in SP_REFACTOR blocks for a few prefs keys
* initial commit of SP_REFACTOR ifdefs, the start of a long quest to separate ↵sqlprodev2011-04-111-3/+11
| | | | UI code from functional code
* Fix more compiler warnings, including a few bugsrowanbeentje2011-03-081-5/+5
|
* fixed compiler warningssqlprodev2011-03-011-2/+2
|
* • fixed completion issue via alias namesBibiko2011-01-211-6/+12
|
* • fixed issue for placeholder insertion while completion of already ↵Bibiko2011-01-211-4/+15
| | | | | | backticked names and the final insertion - part 2 - also fixed undo behaviour
* • fixed issue for placeholder insertion while completion of already ↵Bibiko2011-01-211-5/+14
| | | | backticked names and the final insertion
* • fix table name encoding problem (return name can be NSNull) which can ↵Bibiko2010-12-111-0/+1
| | | | | | arise while SPTablesList updateTables method, • added [theView breakUndoCoalescing]; before inserting the grey completion suggestion due to possible undo exceptions
* - Fix behaviour of manually-triggered autocomplete following recent changesrowanbeentje2010-12-071-16/+18
|
* - Clean up placeholder removal code, and improve speed of full clean slightlyrowanbeentje2010-12-011-35/+47
| | | | | - Fix deletion of text after the caret when moving through autocomplete suggestion lists
* - Rework insertCommonPrefix to insertAutocompletePlaceholder, implementing ↵rowanbeentje2010-11-301-48/+69
| | | | | | | | | a more Mac-like behaviour: insert a faded placeholder for the currently selected autocomplete item. - Update the autocomplete placeholder when the autocomplete dropdown selection is changed - Clean up methods for removing placeholders, and ensure the placeholder is always removed (fixes issues with pasting with a placeholder visible, etc) - When the Help window is closed, switch off AutoHelp - this will aid in supporting those users who accidentally switch on AutoHelp and then can't figure out how to switch it off, resulting in returning windows.
* Minor tweaks to autocompletion:rowanbeentje2010-11-061-0/+6
| | | | | | - Show the text cursor at the location future input will be inserted for clarity - Show autocompleted text faded to indicate it's temporary and may be replaced by other keypresses
* - Split out all of SPExportController's delegate methods to their own category.stuconnolly2010-10-241-2/+0
| | | | | | | | - Prepare for the implementation of PDF and HTML export by hiding the export options box for export types that don't need it. - Fix some spacing issues on the export dialog. - Create a new SPCategoryAdditions header that is included in the apps precompiled header, making all additions available to all classes. - Update strings files.
* Considering nearly every class uses constants, import it via the prefix header.stuconnolly2010-10-191-3/+0
|
* Remove unused macros as well as macros that were only used in a single place ↵stuconnolly2010-09-291-4/+6
| | | | from the precompiled header.
* • overall replacement of:Bibiko2010-08-201-3/+3
| | | | | | | | | [aString appendString:[NSString stringWithFormat:]] by [aString appendFormat:] since it's much more faster • first look at loop where several [aStr appendString:] occur to try to combine them into one appendString or appendFormat since the allocation of memory takes really time Note: I tested all my changes but we should test it further to be sure that I didn't a mistake!
* • auto-completion in Query Editor now detects whether the caret is inside ↵Bibiko2010-08-161-0/+6
| | | | quotes or not in order to come up with the correct suggestions
* - Tweak custom query autocompletion to no longer show a key-capturing ↵rowanbeentje2010-07-171-2/+6
| | | | invisible empty autocomplete when no autocomplete matches are found
* Rename CMTextView to SPTextView.stuconnolly2010-05-271-1/+1
|
* Merge in minor fixes from 0.9.8 RC merge review:rowanbeentje2010-04-241-2/+2
| | | | | | - Make a tiny fix to narrow down completion to avoid memory overrelease issues - Unhide the "Show create view syntax" menu and contextual menu items when selecting a view
* - SPNarrowDownCompletion: Pass NSApp certain events *after* processing ↵rowanbeentje2010-04-231-2/+3
| | | | locally, to fix further crashes like http://spbug.com/l/139 .
* - Allow CMTextView to track SPNarrowDownCompletion state, ensuring old ↵rowanbeentje2010-04-221-8/+21
| | | | | | | windows are closed. This also allows SPNarrowDownCompletion to be closed when CMTextView is deallocated; this should fix http://spbug.com/l/139 . - Fix some minor memory leaks
* Review usage of notifications, afterDelay: and waitUntilDone:NO calls:rowanbeentje2010-04-121-0/+1
| | | | | | | - Add more calls to deregister watchers to fix crashes to closing threads or objects - Fix a couple of memory leaks - Alter a few calls to be performed on main thread (afterDelay: operates on the thread is is called on) - this fixed database reloading after import and field/index deletion error sheets
* Tried to fine-tune the auto-completion behaviour esp. for automatically ↵Bibiko2010-04-071-1/+54
| | | | | | inserted suggestions and increased the minimum auto-complete delay to 0.5s since below that a fight between computer speed and user typing speed could occur. This addresses i625.
* • overlapping of completion windows after refreshing its content if db ↵Bibiko2010-04-061-3/+7
| | | | | | structure fetching was finished - for some reasons it could happen that the timer? fires twice, to avoid this changed the re-invocation strategy
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 04:35:16 +0000