| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
* Instead of trying to figure out if an index is used by an FK ahead of time Sequel Pro will now simply run the query and check for the error code (and only for error 1553 will it attempt to also remove the FK)
* This means that a user will receive two remove dialogs in this rare case, but I think that is actually preferable. Common wisdom shows that users never read the first warning dialog, so in the past they may have agreed to something that they didn’t intend to do. The second dialog should actually make them pause and read it. Also there is a different confirmation button now.
* This also fixes the code to detect which FK in particular MySQL is referring to. SP should now correctly handle compound indexes and multi-column FKs as well as ambiguous results.
|
| |
|
| |
|
| |
|
|
|
|
| |
This should also eliminate a few use-after-free crashes
|
| |
|
|
|
|
| |
Fixes #1917
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
enable some more
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
reload call, so the correct validation is done. Fixes issue #1292.
|
|
|
|
|
|
| |
- FULLTEXT index type should only be available for MyISAM tables
- Index prefix lengths are ignored when specified for FULLTEXT indexes so don't require one (fixes issue #1306)
|
|
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
| |
|
|
|
|
|
|
|
|
|
|
| |
instead of regexes
- Support multiple primary keys in the SPTableData parse
- If possible, use primary keys to preserve table content selection instead of row indexes
- Improve SPTableData primary keys method to use cached value instead of using another query
- Preserve selection when filtering tables if appropriate
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
|
|
|
|
|
|
| |
- Fix exceptions caused by the sizes column formatter requiring a NSNumber
- When displaying the indexes view ensure the sizes column is hidden by default, as the advanced view is closed - unless a field with a required size has been selected
- If a field with a required size has been selected, don't hide the sizes column when collapsing the advanaced view
|
|
|
|
|
|
|
| |
run multiple times
- Fix crashes and exceptions when using "Use monospaced fonts" or "Display vertical grid lines" preferences after closing at least one window
|
|
|
|
|
|
| |
- Fix logic for enabling/disabling the index storage type popup button when changing the index type.
- Add a number formatter to the index length field.
|
| |
|
|
|
|
| |
add new rows/records
|
|
|
|
|
|
| |
- Fix a few encoding issues
- Recode a few [NSApp keyWindow] uses back to [SPDatabaseDocument parentWindow] following discussion; possibly for later refactoring into use of an error method
|
|
|
|
| |
UI code from functional code
|
|
|
|
|
| |
- Tweak README
|
| |
|
|
|
|
|
|
| |
- Move index type query part before the column list to fix advanced use errors
- Correct spelling of -_removeIndexUsingDetails:
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu to use tag-based values when generating queries, allowing localisation of menu contents without using those localised values in queries. This addresses I$
- Remove the ability to specify a FULLTEXT auto_increment index, as I believe this isn't possible.
- Prevent sheet reuse from specifying invalid storage types for PRIMARY KEYs
- Fix exceptions when adding indexes to a table where every field is already indexed
- Fix initialField/indexedFieldNames check to improve on r3061
- Fix toggling advanced index view after closing the sheet with the view open
- Update localisable strings
|
|
|
|
|
|
| |
initialFiledNames if initialField is not nil
- this should fix i933
|
| |
|
|
|
|
| |
that is not already indexed. This completes the implementation of issue #928.
|
|
|
|
| |
the drop down list. Part of issue #928.
|
|
|
|
| |
also check for a composite primary key. Part of issue #928.
|
|
|
|
|
|
|
|
|
|
|
| |
central functionality out of SPTablesList:
- Centralise control over table loading, moving it away from SPTablesList and into SPDatabaseDocument and the new SPDatabaseViewController category
- Centralise control over the main tab view, moving control away from SPTablesList and into SPDatabaseDocument and the new SPDatabaseViewController category
- Simplify and clean up view loading logic
- Improve thread safety
- Update localisable strings
|
| |
|
| |
|
|
|
|
| |
#863.
|
|
|
|
| |
Localizable.strings.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811
Other changes include:
- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.
|
|
|
|
| |
(in the advanced view) which was added in MySQL 5.1.10.
|
|
|
|
|
|
|
|
|
|
|
| |
requiresLength since they are still in use
• fixed: if new field was added store the the underlying NSDictionary not only the field name
• fixed in [addIndex:]: init indexedFields with a mutable copy
- this fixes all issue for "mutating method sent to immutable object" of SPIndexController like i1609
• fixed "Add" Button validation
• fixed display of "Size" column validation
• code cosmetics
|
|
|
|
|
|
|
|
| |
- Fix an exception caused when cancelling adding an index with the advanced options view open.
- Move 'Cancel and 'Add' buttons to be inline with index type and name controls.
Both found/suggested by Rowan.
|