| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
|
|
|
|
| |
* Tooltips were somewhat broken for non-imported fields (issue exists in 1.0.2)
* Newly added expressions would cause the field to switch to "do not import" instead of the added expression
|
|
|
|
|
|
|
|
|
| |
This change should fix the "slow CSV import dialog" issue on 10.10 (details below). To accomplish that, some major changes had to be made to the CSV import code. PLEASE VERIFY THE CORRECTNESS OF THE NEXT FEW CSV IMPORTS YOU DO!
* Renamed some variables for better search visibility
* Changed some instances where NSNumbers were being compared using "==" instead of "isEqual…" (does not work with object literals!)
* The CSV import dialog would recreate the popup menus on *every* call to "tableView:objectValueFor…". However Instruments suggests that [NSMenu removeAllItems] and [NSMenu addItemsWithTitles:] are **really** expensive, esp. when called multiple times per second (e.g. when scrolling in the table view). This commit moves the popup menu setup into its own method and only calls it when the data actually changes.
* The 'destination table column' was for some reason a NSPopupButtonCell which only ever had one item and sometimes got changed to a NSTextFieldCell in code. I didn't see any need to keep the popup cell and replaced it with a simple text cell.
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
| |
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
| |
|
|
|
|
| |
#1596; also address two compiler warnings about unused variables
|
|
|
|
| |
was set to not be imported
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
enable some more
|
|
|
|
| |
tables when importing CSVs, fixing Issue #1621 (SPNotLoaded values are generated when rows shorter than the header row are seen)
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
correctly build the column syntax if the last field(s) are set not to import, addressing Issue #1358.
|
|
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
| |
|
|
|
|
|
|
|
|
| |
with a primary key with multiple columns of which the first of which is a blob or binary type
- Clean up NSNull comparisons and add comments
- Clear the selection when filtering a table, allowing reselection to look a little more consistent
|
|
|
|
| |
in its current syntax builder by using the improved getter.
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
|
|
|
|
|
|
|
|
| |
deleted
- If multiple tables are selected when opening the SPFieldMapperController select the first to import into
- Clean up tableName in tablesList - now returns nil if no tables are selected or multiple tables are selected, instead of returning an empty string for multiple tables
|
| |
|
| |
|
|
|
|
| |
postNotificationOnMainThread: which also exists in TCMPortMapper.framework; NSUserDefaults access now permitted in SP_REFACTOR blocks for a few prefs keys
|
|
|
|
|
|
| |
- Fix a few encoding issues
- Recode a few [NSApp keyWindow] uses back to [SPDatabaseDocument parentWindow] following discussion; possibly for later refactoring into use of an error method
|
|
|
|
| |
UI code from functional code
|
| |
|
|
|
|
|
| |
- Tweak README
|
| |
|
| |
|
|
|
|
|
| |
- reset import operators after each change of the chosen alignment
- double-click at PathControl performs goBackToFileChooser delayed in order to avoid time racing issues
|
|
|
|
|
|
|
| |
column names
- first calculate Levenshtein distance; if it is greater than 0 then subtract the length of shared prefix, suffix, and in common character sequence
- avoid mapping of already mapped file header names, instead take the next best match not mapped
|
|
|
|
|
|
|
| |
- Improve 10.5 compatibility when clearing menus ( http://spbug.com/l/1508 , http://spbug.com/l/1829 , http://spbug.com/l/1818 )
- Fix a possible crash when updating database lists
- Update localisable strings
|
|
|
|
|
|
| |
• fixed several issues while importing a CSV file if this file contains empty lines or if a line has less columns as header
- fixed issue for matching header names
- fixed issue for user-defined SQL functions while importing; in such a case set the value to @"" to get the defaults
|
|
|
|
|
| |
- it seems that isKindOfClass: method to check length and data type of the csv source while creating a new table failed for empty cells or NULL; I tried to catch these issues
- has to be checked further
|
|
|
|
|
| |
- fixed issues for tooltips of user-defined values
- avoid double-calling the 'add value' sheet since it can be called via popupmenu and keyboard short-cut
|
|
|
|
|
|
|
|
| |
- a column placeholder will be wrapped into '…' if csv cell content is not NULL, in other words there's no need to write eg length('$1') instead simply write length($1)
- fixed issue if csv cell content is NULL
- fixed issue for deletion of global values if they were already in use
- assigned keyboard short-cut ⌥⌘G to "Add value or expression…" menu item
|
|
|
|
|
|
|
|
| |
- Prepare for the implementation of PDF and HTML export by hiding the export options box for export types that don't need it.
- Fix some spacing issues on the export dialog.
- Create a new SPCategoryAdditions header that is included in the apps precompiled header, making all additions available to all classes.
- Update strings files.
|
|
|
|
|
| |
- added the possibility to apply any sql function while importing set via "Add value or expression" sheet eg concat('$2', '$1', length('$3')) whereby $1 $2 $3 are the placeholder for the csv file columns 1 2 3 [first column starts with 1]
• fixed ' escaping issue in MCPConnection
|
|
|
|
|
|
|
|
| |
table history
• CSV Import Field Mapper Sheet
- fixed issue for inserting a global value containing a '
- started preparations of the "Add value or expression" sheet for future enhancements
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811
Other changes include:
- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.
|
|
|
|
|
|
| |
checked value is not a NSString
- fixes issue 1649
|
|
|
|
|
|
|
| |
had crept into the source, replacing with the correct [NSWindow makeFirstResponder:NSTableView]. This fixes a number of exceptions.
- Update localisable strings.
|