| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
was provided.
|
|
|
|
| |
database
|
|
|
|
|
|
| |
misbehaviour if loading a table failed (fixes #2180)
Note: I suspect this was a leftover from refactoring but I can't rule out the possibility of a code path where this was desired.
|
| |
|
|
|
|
| |
you do that!?) (fixes #2147)
|
|
|
|
| |
aka "deleted uncommited CA transaction"
|
|
|
|
|
|
| |
database (#2082)
(While we're at it, also removed some duplicate CREATE DATABASE code)
|
|
|
|
| |
The red (first) connection color would not be duplicated to another tab, when choosing "Open Table in New X" from the context menu (issue reported by Kyle via e-mail).
|
|
|
|
| |
messaging a Zombie and crashing
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
| |
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
|
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
|
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
| |
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
|
|
|
| |
Fixes #2029
|
|
|
|
|
|
| |
* Attempt to fix the "<SPSplitView: ...>: the delegate <SPSplitView: ...> was sent -splitView:resizeSubviewsWithOldSize: and left the subview frames in an inconsistent state:" message that has been plaguing my console for some time.
* This commit also adds a minimum width on the main area to prevent some strange UI bugs.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Namely this commit changes two things:
1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491):
[NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release
[[self window] orderOut:self];
This call order has now been swapped.
2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority.
Requesting QA on this commit.
|
|
|
|
|
|
|
|
| |
The dialog enables
* searching for a database by name (substring matching),
* using C&P to select databases
* navigating to databases not in the database dropdown
* faster keyboard-based navigation
|
|
|
|
| |
arguments
|
| |
|
| |
|
|
|
|
| |
the view binary data as hex option is toggled. Fixes #1875.
|
|
|
|
| |
distinguish from string data of similar content.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
dropped relationship. Fixes issue #1591.
|
|
|
|
|
|
|
|
|
| |
REVIEW **
Known issues:
* There might be additional colors be shown when dragging tabs between windows
* The color set might need fine tuning
* Coloring of items in the favorite outline view is not yet handled
|
|
|
|
|
|
|
|
|
| |
Issue #1805:
- Add new menu item for "Save Query", making the existing item "Save Query As" as an alternate
- Track the opened SQL file and used encoding to be able to easily save the same file again
- Standardise encoding detection to use the UniversalDetector framework and use that for opened SQL files where the encoding menu is not used
|
| |
|
|
|
|
| |
enable some more
|
| |
|
|
|
|
| |
is established.
|
|
|
|
| |
beginWaitingAlertSheetWithTitle:... class method on a new SPAlertSheets class, allowing us to use invocation forwarding to ensure the entire function is executing on the main thread. This allows runloop processing to happen on the main thread, addressing Issue #1676
|
|
|
|
|
|
|
|
| |
favorites
- Fix the action of the "Add to Favorites" File menu item to correctly create the new favorite
These address Issue #1666.
|
| |
|
|
|
|
| |
tab, further addressing Issue #1619
|
|
|
|
| |
read from a spf/spfs during startup. This addresses Issue #1619
|
| |
|
| |
|
|
|
|
| |
the focus in it, addressing Issue #1590
|
|
|
|
|
|
|
|
|
| |
- Rework how data to populate the user manager is retrieved from the server, speeding up display of lots of users by a large factor
- Fix support for schema permissions for the Anonymous user, and add support for '%' and '' hostnames (only showing if already set once), fixing Issue #1620
- Highlight databases in the user manager that have permissions set for the selected user
- Switch to using the centrally provided database list to reduce queries and remove the information_schema and performance_schema "databases"
- Speed up a number of operations by tweaking the logic and queries used
|
|
|
|
|
|
|
|
| |
database encoding
- Clean up the database creation logic and remove redundant selection logic
- Correctly reset and detect the database encoding when creating and switching databases
|