aboutsummaryrefslogtreecommitdiffstats
path: root/Source/SPDatabaseDocument.m
Commit message (Collapse)AuthorAgeFilesLines
* Fix crashes on tab/window closing due to previously registed preference ↵Stuart Connolly2017-03-241-3/+2
| | | | observers not being removed.
* Remove duplicate setting of sheet title/message.Stuart Connolly2017-03-231-4/+2
|
* - #1235: Prevent renaming a database which contains any non-table objects as ↵Stuart Connolly2017-03-231-17/+55
| | | | | | | | it's currently not supported. - #1235: Inform the user when duplicating a database than any non-table objects won't be copied. - Add missing high resolution images to project. - Fix a potential memory leak inside SPCreateDatabaseInfo
* Performance improvement for databases that contain lots of objects. When ↵Stuart Connolly2017-03-221-26/+25
| | | | getting shell variables for bundles don't call the object names methods multiple times.
* Fix table triggers view not reacting to UI preference changes. Also, move ↵Stuart Connolly2017-03-181-129/+72
| | | | the responsibility of adding/removing preference observers to the controllers of respective views (more to follow).
* #2732: Fix table information panel stuck on activities view.Stuart Connolly2017-03-151-8/+9
|
* Begin work on comparing two databasesAbhi Beckert2016-12-021-0/+65
|
* Some changes suggested in PR #2606 to improve MySQL 5.8 handlingMax2016-11-011-4/+4
|
* Fix a case of "background thread updating UI"Max2016-06-261-16/+18
|
* #2434 now use NSTitlebarAccessoryViewController if availableAbhi Beckert2016-06-051-10/+27
|
* fix various compile warningsAbhi Beckert2016-04-031-1/+1
|
* #346 Work on new tab bar designAbhi Beckert2016-03-181-3/+4
|
* Fix a wrongly structured setter that might have been involved in some crashesMax2016-03-051-2/+3
|
* Change some risky behavior (might be related to #2432)Max2016-03-051-2/+5
|
* Avoid an exception on a rare issue where determing the database fails after ↵Max2016-01-131-1/+2
| | | | sql import/running a custom query
* Hand ServerSupport instance to exportersMax2015-11-201-0/+1
|
* * Add QuickLook support for "export settings" filesMax2015-11-151-3/+3
| | | | | | * Add MGTemplateEngine to the QL plugin * Reorder the generator code a bit, so it's not one monolithic function * Add constants for some other sfp format types
* In order to enable even more people to shoot themselves in the foot, this ↵Max2015-11-121-0/+34
| | | | | | commit adds support for remote server shutdown 💣
* Fix the charset/collation selection when creating a new db/table (minor ↵Max2015-11-031-0/+2
| | | | leftover from #2237)
* * Basic math is hard sometimes (fixes an issue introduced by me in ↵Max2015-10-311-3/+3
| | | | | | | b2d798ba9282d3acf1a2d65de30849e529d4d255) * Fix an exception that could occur when trying to view a damaged table * Fix a theoretical use-after-free issue by a wrongly structured retain/release in a setter
* Wrap a repeated call in a simpler methodMax2015-10-251-1/+1
|
* Fix bundle commands no longer working in popup field editor (and possibly ↵Max2015-10-211-6/+8
| | | | | | other cases) (#2299) Replacing some [NSApp mainWindow] with their actually intended calls [NSApp keyWindow] and [view window]
* Replace a lot of SPBeginAlertSheet()s with the more concise SPOnewayAlertSheet()Max2015-10-201-32/+53
| | | | This should also eliminate a few use-after-free crashes
* Constrain the Table Info Comment/Create split view so that neither side can ↵Max2015-10-141-0/+4
| | | | be completely hidden (fixes #2285)
* Add mysql:// URL handler (fixes #1681)Max2015-10-141-11/+21
|
* Fix another case of "background thread updating UI"Max2015-10-131-16/+20
|
* Change two magic strings into constantsMax2015-10-101-7/+7
|
* Trying to fix a range of crashes when closing a connection windowMax2015-10-051-0/+1
| | | | Caused by a use-after-free of an unretained ivar
* Added extra parameter to SPOnewayAlertSheet and runs runModal if no window ↵Guillermo Ignacio Enriquez Gutierrez2015-08-221-1/+2
| | | | was provided.
* Fix a concurrent modification exception that could occur when duplicating a ↵Max2015-07-201-5/+10
| | | | database
* Remove an unbalanced call to -[SPDatabaseDocument endTask] which caused ↵Max2015-07-201-0/+1
| | | | | | misbehaviour if loading a table failed (fixes #2180) Note: I suspect this was a leftover from refactoring but I can't rule out the possibility of a code path where this was desired.
* Add some info which might help a bit with debugging threading issuesMax2015-07-021-4/+8
|
* Fix a crash when the database popup was removed from the toolbar (why would ↵Max2015-06-181-9/+36
| | | | you do that!?) (fixes #2147)
* Fixed two case of background thread interacting with UIMax2015-04-221-2/+3
| | | | aka "deleted uncommited CA transaction"
* Fix Sequel Pro forgetting database charset when renaming or copying a ↵Max2015-03-121-18/+20
| | | | | | database (#2082) (While we're at it, also removed some duplicate CREATE DATABASE code)
* Fix an issue with connection color and cloned connectionsMax2015-03-031-4/+4
| | | | The red (first) connection color would not be duplicated to another tab, when choosing "Open Table in New X" from the context menu (issue reported by Kyle via e-mail).
* Fix an issue where a KV Observer was not removed on dealloc resulting in KVO ↵Max2015-01-111-0/+1
| | | | messaging a Zombie and crashing
* Change some code formattingMax2015-01-061-10/+15
|
* Addition to commit 2735e15bMax2015-01-041-2/+1
|
* Replace some "magic numbers" with constantsMax2015-01-041-6/+6
|
* Formalize [x release], x = nil; conventionMax2015-01-041-56/+55
| | | | | Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it. Feel free to revert this commit if you see issues with the approch or implementation.
* Add code for utf8mb4 encodingMax2014-12-191-18/+20
|
* Replace some NSDictionaries with literalsMax2014-12-131-48/+46
| | | | | | * [NSDictionary dictionary] → @{} * [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past. * Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
* Change [NSArray arrayWithObject:] to @[] literalMax2014-12-131-4/+4
| | | | Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
* Add cast for [NSApp delegate]Max2014-12-131-23/+23
| | | | | * (Also changed some outdated URLs) * Replaced [NSApplication sharedApplication] with NSApp
* Replace boxed integers in code with @ literalsMax2014-12-131-9/+9
|
* Reformatting code for modern ObjCMax2014-12-131-26/+26
| | | | | Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals. Also replaced some TRUE/FALSE with their YES/NO counterparts.
* Include tab color when duplicating tab.Max2014-11-291-0/+4
| | | | Fixes #2029
* Change some split view width calculations.Max2014-11-291-1/+6
| | | | | | * Attempt to fix the "<SPSplitView: ...>: the delegate <SPSplitView: ...> was sent -splitView:resizeSubviewsWithOldSize: and left the subview frames in an inconsistent state:" message that has been plaguing my console for some time. * This commit also adds a minimum width on the main area to prevent some strange UI bugs.
* Attempt to fix #1961Max2014-11-111-10/+4
| | | | | | | | | | | | | Namely this commit changes two things: 1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491): [NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release [[self window] orderOut:self]; This call order has now been swapped. 2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority. Requesting QA on this commit.