aboutsummaryrefslogtreecommitdiffstats
path: root/Source/SPDatabaseDocument.m
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix the charset/collation selection when creating a new db/table (minor ↵Max2015-11-031-0/+2
| | | | leftover from #2237)
* * Basic math is hard sometimes (fixes an issue introduced by me in ↵Max2015-10-311-3/+3
| | | | | | | b2d798ba9282d3acf1a2d65de30849e529d4d255) * Fix an exception that could occur when trying to view a damaged table * Fix a theoretical use-after-free issue by a wrongly structured retain/release in a setter
* Wrap a repeated call in a simpler methodMax2015-10-251-1/+1
|
* Fix bundle commands no longer working in popup field editor (and possibly ↵Max2015-10-211-6/+8
| | | | | | other cases) (#2299) Replacing some [NSApp mainWindow] with their actually intended calls [NSApp keyWindow] and [view window]
* Replace a lot of SPBeginAlertSheet()s with the more concise SPOnewayAlertSheet()Max2015-10-201-32/+53
| | | | This should also eliminate a few use-after-free crashes
* Constrain the Table Info Comment/Create split view so that neither side can ↵Max2015-10-141-0/+4
| | | | be completely hidden (fixes #2285)
* Add mysql:// URL handler (fixes #1681)Max2015-10-141-11/+21
|
* Fix another case of "background thread updating UI"Max2015-10-131-16/+20
|
* Change two magic strings into constantsMax2015-10-101-7/+7
|
* Trying to fix a range of crashes when closing a connection windowMax2015-10-051-0/+1
| | | | Caused by a use-after-free of an unretained ivar
* Added extra parameter to SPOnewayAlertSheet and runs runModal if no window ↵Guillermo Ignacio Enriquez Gutierrez2015-08-221-1/+2
| | | | was provided.
* Fix a concurrent modification exception that could occur when duplicating a ↵Max2015-07-201-5/+10
| | | | database
* Remove an unbalanced call to -[SPDatabaseDocument endTask] which caused ↵Max2015-07-201-0/+1
| | | | | | misbehaviour if loading a table failed (fixes #2180) Note: I suspect this was a leftover from refactoring but I can't rule out the possibility of a code path where this was desired.
* Add some info which might help a bit with debugging threading issuesMax2015-07-021-4/+8
|
* Fix a crash when the database popup was removed from the toolbar (why would ↵Max2015-06-181-9/+36
| | | | you do that!?) (fixes #2147)
* Fixed two case of background thread interacting with UIMax2015-04-221-2/+3
| | | | aka "deleted uncommited CA transaction"
* Fix Sequel Pro forgetting database charset when renaming or copying a ↵Max2015-03-121-18/+20
| | | | | | database (#2082) (While we're at it, also removed some duplicate CREATE DATABASE code)
* Fix an issue with connection color and cloned connectionsMax2015-03-031-4/+4
| | | | The red (first) connection color would not be duplicated to another tab, when choosing "Open Table in New X" from the context menu (issue reported by Kyle via e-mail).
* Fix an issue where a KV Observer was not removed on dealloc resulting in KVO ↵Max2015-01-111-0/+1
| | | | messaging a Zombie and crashing
* Change some code formattingMax2015-01-061-10/+15
|
* Addition to commit 2735e15bMax2015-01-041-2/+1
|
* Replace some "magic numbers" with constantsMax2015-01-041-6/+6
|
* Formalize [x release], x = nil; conventionMax2015-01-041-56/+55
| | | | | Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it. Feel free to revert this commit if you see issues with the approch or implementation.
* Add code for utf8mb4 encodingMax2014-12-191-18/+20
|
* Replace some NSDictionaries with literalsMax2014-12-131-48/+46
| | | | | | * [NSDictionary dictionary] → @{} * [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past. * Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
* Change [NSArray arrayWithObject:] to @[] literalMax2014-12-131-4/+4
| | | | Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
* Add cast for [NSApp delegate]Max2014-12-131-23/+23
| | | | | * (Also changed some outdated URLs) * Replaced [NSApplication sharedApplication] with NSApp
* Replace boxed integers in code with @ literalsMax2014-12-131-9/+9
|
* Reformatting code for modern ObjCMax2014-12-131-26/+26
| | | | | Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals. Also replaced some TRUE/FALSE with their YES/NO counterparts.
* Include tab color when duplicating tab.Max2014-11-291-0/+4
| | | | Fixes #2029
* Change some split view width calculations.Max2014-11-291-1/+6
| | | | | | * Attempt to fix the "<SPSplitView: ...>: the delegate <SPSplitView: ...> was sent -splitView:resizeSubviewsWithOldSize: and left the subview frames in an inconsistent state:" message that has been plaguing my console for some time. * This commit also adds a minimum width on the main area to prevent some strange UI bugs.
* Attempt to fix #1961Max2014-11-111-10/+4
| | | | | | | | | | | | | Namely this commit changes two things: 1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491): [NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release [[self window] orderOut:self]; This call order has now been swapped. 2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority. Requesting QA on this commit.
* Add a "Go to Database" dialogMax2014-10-121-0/+19
| | | | | | | | The dialog enables * searching for a database by name (substring matching), * using C&P to select databases * navigating to databases not in the database dropdown * faster keyboard-based navigation
* Fix string formatting warnings in NSRunAlertPanel by using the additional ↵rowanbeentje2014-05-041-1/+1
| | | | arguments
* Update URL in source file header to point to GitHub.Stuart Connolly2014-01-261-1/+1
|
* Remove SVN property placeholder.Stuart Connolly2014-01-261-2/+0
|
* Force a table reload (just the view not the actual data retrieval) whenever ↵Stuart Connolly2014-01-201-30/+46
| | | | the view binary data as hex option is toggled. Fixes #1875.
* Add an option to display binary data as hex, while displaying it in blue to ↵Stuart Connolly2014-01-141-3/+8
| | | | distinguish from string data of similar content.
* More tidy up.Stuart Connolly2013-12-021-2/+6
|
* Tidy up change to test git integration.Stuart Connolly2013-12-021-2/+0
|
* Remove more use of deprecated methods.Stuart Connolly2013-11-271-74/+65
|
* Updated Save Create Syntax panel sheet to 10.6+ SDKMarius Ursache2013-11-111-22/+12
|
* Cleaned up Format string is not a string literal (potentially insecure) errorsMarius Ursache2013-11-091-18/+18
|
* Ensure the relations table view is refreshed after field changes result in a ↵stuconnolly2013-10-271-0/+1
| | | | dropped relationship. Fixes issue #1591.
* * This change adds basic tab coloring support for favorites - ** POC / NEEDS ↵dmoagx2013-10-231-0/+6
| | | | | | | | | REVIEW ** Known issues: * There might be additional colors be shown when dragging tabs between windows * The color set might need fine tuning * Coloring of items in the favorite outline view is not yet handled
* Allow opened SQL files to be saved back to the original file, addressing ↵rowanbeentje2013-09-081-1/+13
| | | | | | | | | Issue #1805: - Add new menu item for "Save Query", making the existing item "Save Query As" as an alternate - Track the opened SQL file and used encoding to be able to easily save the same file again - Standardise encoding detection to use the UniversalDetector framework and use that for opened SQL files where the encoding menu is not used
* - Address further Release/Distribution build warningsrowanbeentje2013-05-221-2/+2
|
* - Fix all the Xcode 4.6.2 build warnings, and tweak warning settings to ↵rowanbeentje2013-05-211-2/+4
| | | | enable some more
* * Move some duplicate code for charset/collation to it's own classdmoagx2013-04-261-204/+46
|
* Issue #1601: Fix menu items not being validated properly once a connection ↵stuconnolly2013-04-031-49/+63
| | | | is established.