| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
a rename to prevent a secondary thread using the database list while it's being modified on the main thread. Fixes log reports http://spbug.com/l/2294
|
| | |
|
| |
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
instead of regexes
- Support multiple primary keys in the SPTableData parse
- If possible, use primary keys to preserve table content selection instead of row indexes
- Improve SPTableData primary keys method to use cached value instead of using another query
- Preserve selection when filtering tables if appropriate
|
| |
|
|
| |
after the parent document was closed
|
| | |
|
| | |
|
| |
|
|
| |
from the project, and replace with an MIT-licensed TCMPortMapper sources NSNotificationCenterThreadingAdditions category. This should fix method clashes in the SP_REFACTOR project, so remove behavioural/namespacing switches.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the functionality required from MCPKit and is based around its interface for relatively easy integration.
Externally visible changes as a result of this merge:
- Speed improvements, particularly when loading large data sets
- Stability improvements, particularly related to connection state after the connection is dropped (eg Issue #1256)
- Improved support for new MySQL data types, which should address Issue #1052.
- Database structure retrieval and query cancellation now use a single persistent helper connection instead of lots of connections on-demand. This should help Issue #1097.
- More internal commands now use queries instead of MySQL functions; for example USE queries are now used to trigger database selection, improving transcripts. This addresses Issue #1247.
- Improved internal encoding work; while this needs support within the UI, it lays the foundation for issues like Issue #1280.
Code improvements:
- Much improved class layouts including extensive category usage
- Improved documentation across framework methods
- Support for fast enumeration across result objects
- Rewrite fixes use of a number of deprecate functions
- Much less code duplication across result set types
- Improved encapsultation within the framework, limiting the number of methods exposed, and also not exposing all the MySQL headers
From the Readme file:
The SPMySQL Framework is intended to provide a stable MySQL connection framework, with the ability to run text-based queries and rapidly retrieve result sets with conversion from MySQL data types to Cocoa objects.
SPMySQL.framework has an interface loosely based around that provided by MCPKit by Serge Cohen and Bertrand Mansion (http://mysql-cocoa.sourceforge.net/), and in particular the heavily modified Sequel Pro version (http://www.sequelpro.com/). It is a full rewrite of the original framework, although it includes code from patches implementing the following Sequel Pro functionality, largely contributed by Hans-Jörg Bibiko, Stuart Connolly, Jakob Egger, and Rowan Beentje:
- Connection locking (Jakob et al)
- Ping & keepalive (Rowan et al)
- Query cancellation (Rowan et al)
- Delegate setup (Stuart et al)
- SSL support (Rowan et al)
- Connection checking (Rowan et al)
- Version state (Stuart et al)
- Maximum packet size control (Hans et al)
- Result multithreading and streaming (Rowan et al)
- Improved encoding support & switching (Rowan et al)
- Database structure; moved to inside the app (Hans et al)
- Query reattempts and error-handling approach (Rowan et al)
- Geometry result class (Hans et al)
- Connection proxy (Stuart et al)
|
| | |
| |
| |
| |
| |
| | |
- Fix background database structure checks throwing exceptions at the end of certain table operations
- Fix incorrect timer access/overrelease when closing a SPNarrowDownCompletion window when database structure fetching is active
|
| | |
| |
| |
| |
| |
| |
| |
| | |
- Add a ping keepalive managing object to prevent retain cycles from the NSTimer
- Add -[SPMySQLConnection copy] support
- Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness.
- Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
| |/ |
|
| | |
|
| |
|
|
| |
correct server name
|
| |
|
|
|
|
|
| |
preventing repeated calls when navigating tables using "default" encoding, or views
- Ensure the database encoding is correctly updated when new databases are selected. This addresses Issue #1201
|
| |
|
|
|
|
|
|
| |
- Remove the background lookup of table constraint names for the current database. This prevented connection use while the query was running, and the query cannot be optimised and severely taxes servers with many databases. Revert to checking names against names in the current database
- Repurpose the activity spinner for adding relation query execution
- When an error is encountered adding a relation, re-open the sheet with the submitted values after displaying the error
- Add use of 'SHOW InnoDB STATUS' command and text extraction to show more explicit errors for the most common constraint errors
|
| |
|
|
| |
currently used relation names in a backgroud thread. In the event that the user opens the add new relation sheet during this process, the ability to enter a relation name and confirm the addition is disabled until the retrieval process is complete. There is also a new progress indicator on the add sheet to indicate this.
|
| | |
|
| | |
|
| |
|
|
|
| |
- Implement an undo manager per tab (strictly speaking, per connection 'document'), addressing Issue #1109.
|
| |
|
|
|
|
|
|
|
|
|
| |
the main window only; hide SSH/SSL status when entering fullscreen mode, to prevent drawing issues
- Lion compatibility improvement: update tab colours under 10.7 to match system styles
- Lion compatibility improvement: fix issues dragging tabs out of windows and into other tab bars
- Lion compatibility improvement: fix QuickLook issues under 10.7, including windows which couldn't be closed, fullscreened, or crashes
- Fix exceptions in the bundle controller when using tab switching keys
- Lion compatibility improvement: use overlay scrollers where possible
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
displaying NULLs within tables when the connection encoding is incorrectly detected (Issue #1100):
- No longer rely on a combination of mysql_options(..., MYSQL_SET_CHARSET_NAME, ...utf8...) and mysql_character_set_name() to detect the connection encoding; this incorrectly misses init_connect commands; instead use SHOW_VARIABLES a$
- Combine initial version check/timezone check/encoding check on startup, reducing connection queries and thus improving connection speed
- Add support for abbreviated MySQL timezone definitions
- Combine MCPKit's -connect and -connectWithLogin:password:host:port:socket: methods to reduce code duplication and fix argument handling for the latter method
|
| | |
|
| |
|
|
| |
exceptions when re-saving old .spf files
|
| |
|
|
| |
instead of an empty string; the MySQL manual suggests that maybe we should be doing this, and it may address Issue #1065.
|
| | |
|
| |
|
|
| |
sequelpro://SP_PROCESS_ID@passToDoc/RunQueryInQueryEditor/ which executes a passed SQL query and displays the result if any in the data table of the query editor
|
| |
|
|
| |
* Update strings files
|
| |
|
|
| |
tab (equivalent to the 'Open Database in New Tab' menu item). Implements issue #1040.
|
| | |
|
| | |
|
| |
|
|
| |
postNotificationOnMainThread: which also exists in TCMPortMapper.framework; NSUserDefaults access now permitted in SP_REFACTOR blocks for a few prefs keys
|
| |
|
|
|
|
| |
- Fix a few encoding issues
- Recode a few [NSApp keyWindow] uses back to [SPDatabaseDocument parentWindow] following discussion; possibly for later refactoring into use of an error method
|
| |
|
|
| |
UI code from functional code
|
| |
|
|
| |
keychain names and accounts. This addresses incorrect password use, fixing Issue #1020
|
| |
|
|
|
|
|
| |
- This may be due to an Apple bug. I tracked it down to purely SPDatabaseDocument having a reference outlet to the activity scroll view.
- Removing the reference worked as a fix; removing all code that used that reference did not.
- Renaming the reference, and removing SPTableInfo's use of a reference, appears to act as a workaround. If the reference is not renamed, the bug still mainfests (!!!)
|
| |
|
|
| |
Issue #1011
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
parent window on making that tab foremost, which is unneccessary and can cause switching to the previous Space. This addresses Issue #970.
|
| |
|
|
| |
- the main purpose of that keyboard short-cut is the SHOW the Console window even if it's visible but hidden under other windows; now ⇧⌘K orders out the Console window if it's invisible or visible but mot the front most window; if it's the front most window ⇧⌘K will hide it
|
| |
|
|
|
|
| |
- if (![NSThread isMainThread]) return [self updateWindowTitle:sender]; will run forever if called not from main thread; instead do: if (![NSThread isMainThread]) return [[self onMainThread] updateWindowTitle:sender];
|
| |
|
|
| |
under race conditions
|
