| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
This should also eliminate a few use-after-free crashes
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove a redundant ivar (and while we are at it, restructure some code)
* And then there was this gem:
(...)
if (fileMode == O_RDONLY) {
int i, c;
char bzbuf[4];
const char *charFileMode = fileMode == O_WRONLY ? "wb" : "rb";
(...)
|
|
|
|
| |
* Move a lock() that could become unbalanced and theoretically cause havoc
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
|
|
|
|
| |
(Import would not work on a new installation where a certain preference key has not yet been set)
* Also attached the gear menu in table structure view to the table header view, so the columns to show can now be selected by right-clicking on the table header (like in Activity Monitor)
|
|
|
|
|
| |
* A call of setString: from background thread which could cause a "deleted thread with uncommitted CATransaction" warning
* SPFieldMapperController was allocated from a background thread with an own autoreleasepool, while it contains UI objects. This could cause a crash when the autoreleasepool was drained and the field mapper forcefully released, while other UI objects still had it retained.
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Issue #1805:
- Add new menu item for "Save Query", making the existing item "Save Query As" as an alternate
- Track the opened SQL file and used encoding to be able to easily save the same file again
- Standardise encoding detection to use the UniversalDetector framework and use that for opened SQL files where the encoding menu is not used
|
| |
|
|
|
|
| |
enable some more
|
| |
|
| |
|
|
|
|
| |
sources and mysql doc that seems to have always been it's name?) #1476
|
| |
|
|
|
|
|
|
|
| |
fix nightly builds
- Fix warnings
|
|
|
|
|
|
|
|
| |
with a primary key with multiple columns of which the first of which is a blob or binary type
- Clean up NSNull comparisons and add comments
- Clear the selection when filtering a table, allowing reselection to look a little more consistent
|
|
|
|
|
|
| |
- Fix background database structure checks throwing exceptions at the end of certain table operations
- Fix incorrect timer access/overrelease when closing a SPNarrowDownCompletion window when database structure fetching is active
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions as database structure retrieval is currently missing!
Further work on SPMySQLFramework integration:
- Improve SPMySQL framework build settings including correct ppc builds and a Distribution configuration for the build distributions to match
- Add new convenience querying and result methods to the framework
- Amend Sequel Pro source to use the new SPMySQL.framework methods everywhere, replacing MCPKit methods where they differ and improving some functions
- Remove MCPKit from the source
- Fix a number of warnings on Release-style builds
|
| |
|
|
|
|
| |
both backslash and double-character escaping. This will mean the vast majroty of CSVs selected for import will be read correctly by default, fixing issues such as Issue #1252
|
|
|
|
| |
during CSV import)
|
|
|
|
| |
crashes if a new table name to create was entered
|
| |
|
|
|
|
| |
to NULL instead of 0 if an empty string is entered. This matches TableContent behaviour and addresses Issue #1034.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- appended a ',' to the wrong NSString
- fixes i978
|
|
|
|
|
|
|
|
|
|
| |
errors occurred, starting off hidden
- Add "errors"/"no errors" prefix to the custom query status area
- Add an import cancelled line to the import error list when stopping imports after errors
- Fix custom query error highlighting by scrolling to the error
- Update localisable strings
|
|
|
|
|
|
|
|
|
| |
based on a tab view
- When importing SQL, use the accessory view to ask how to handle errors: Ask (the new default), which prompts the user on each error whether to continue, stop, or ignore all errors; and ignoring all errors, which matches the old behaviour. This addresses Issue #901.
- When showing the reconnection dialog ensure the window isn't minimised
- Update localisable strings
|
|
|
|
|
|
|
|
|
|
|
| |
central functionality out of SPTablesList:
- Centralise control over table loading, moving it away from SPTablesList and into SPDatabaseDocument and the new SPDatabaseViewController category
- Centralise control over the main tab view, moving control away from SPTablesList and into SPDatabaseDocument and the new SPDatabaseViewController category
- Simplify and clean up view loading logic
- Improve thread safety
- Update localisable strings
|
|
|
|
|
|
| |
• fixed several issues while importing a CSV file if this file contains empty lines or if a line has less columns as header
- fixed issue for matching header names
- fixed issue for user-defined SQL functions while importing; in such a case set the value to @"" to get the defaults
|
|
|
|
|
|
| |
- Use indeterminate progress bars when importing BZIPped SQL files
- Support .tsv as a CSV extension, and automatically choose the field delineator based on .csv/.tsv extension
|
|
|
|
|
|
|
|
| |
- a column placeholder will be wrapped into '…' if csv cell content is not NULL, in other words there's no need to write eg length('$1') instead simply write length($1)
- fixed issue if csv cell content is NULL
- fixed issue for deletion of global values if they were already in use
- assigned keyboard short-cut ⌥⌘G to "Add value or expression…" menu item
|
|
|
|
|
|
|
|
| |
- Prepare for the implementation of PDF and HTML export by hiding the export options box for export types that don't need it.
- Fix some spacing issues on the export dialog.
- Create a new SPCategoryAdditions header that is included in the apps precompiled header, making all additions available to all classes.
- Update strings files.
|
|
|
|
|
| |
- added the possibility to apply any sql function while importing set via "Add value or expression" sheet eg concat('$2', '$1', length('$3')) whereby $1 $2 $3 are the placeholder for the csv file columns 1 2 3 [first column starts with 1]
• fixed ' escaping issue in MCPConnection
|
| |
|
|
|
|
|
|
| |
via GeomFromText()
• minor code cosmetics
|
|
|
|
|
| |
- the SRID value will be appended at the WKT string like POINT(1 1),101 which will be transformed to GeomFromText('POINT(1 1)',101) on the fly
- otherwise the SRID information will be deleted after editing a geometry field
|
| |
|
|
|
|
|
| |
- if mapped target table field is of type GEOMETRY import csv data via GeomFromText()
- replaced succeeding appendString lines by appendFormat since tests have shown that allocating memory once is faster than do it several times
|