| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
when the window is about to be closed and can stop a pending UI timer (#2775)
|
|
|
|
| |
it has caused (part of #2770)
|
|
|
|
| |
(This should not cause any behavioral changes)
|
|
|
|
| |
exception with a very specific timing (#2754)
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
DATETIME/TIMESTAMP fields (part of #2315)
|
|
|
|
|
|
| |
other cases) (#2299)
Replacing some [NSApp mainWindow] with their actually intended calls [NSApp keyWindow] and [view window]
|
|
|
|
| |
This should also eliminate a few use-after-free crashes
|
|
|
|
| |
query result would not contain all data if keyboard navigation was used (#2283)
|
| |
|
|
|
|
| |
Accessibility Services are enabled and a certain other Application is running (issue #2220)
|
| |
|
|
|
|
|
|
|
|
| |
... which occurred if ALL of the following conditions were met:
* A cell of a custom query result was being edited
* At the same time another process removed said row
* The custom query was rerun without canceling or finishing the edit first
(also added a NSBeep() for a certain tooltip error message)
|
|
|
|
| |
Replaced some (range.location + range.length) with NSMaxRange(range)
|
| |
|
|
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
| |
|
|
|
|
| |
Changing the query favorties/history would cause an UI inconsitency when the list was filtered before.
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
|
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
|
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
| |
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
|
|
|
| |
for use when loading tables, which may improve Issue #1925 and Issue #1902.
|
|
|
|
|
| |
Add inverse sorting for custom queries
Keep the inverse order while shift+clicking after the first click
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Issue #1805:
- Add new menu item for "Save Query", making the existing item "Save Query As" as an alternate
- Track the opened SQL file and used encoding to be able to easily save the same file again
- Standardise encoding detection to use the UniversalDetector framework and use that for opened SQL files where the encoding menu is not used
|
|
|
|
|
|
|
|
|
| |
increases and lower memory usage:
- Add a new SPMySQLStreamingResultStore class to SPMySQL.framework. This class acts as both a result set and a data store for the accompanying data, storing the row information in a custom format in a custom malloc zone.
- Amend SPDataStorage to wrap the new class, so original result information is stored in the one location in the custom format. Any edited information is handled by SPDataStorage for clean separation
- Rework table content and custom query data data stores to use the new class. This significantly speeds up data loading, resulting in faster data loads if they weren't previously network constrained, or lower CPU usage otherwise. The memory usage is also lowered, with the memory overhead for many small cells being enormously reduced.
|
|
|
|
| |
enable some more
|
|
|
|
| |
rows of the current result, so don't return the actual result.
|
|
|
|
| |
beginWaitingAlertSheetWithTitle:... class method on a new SPAlertSheets class, allowing us to use invocation forwarding to ensure the entire function is executing on the main thread. This allows runloop processing to happen on the main thread, addressing Issue #1676
|
|
|
|
| |
has occurred, addressing Issue #1670
|
|
|
|
|
|
|
| |
part of the button but ended in the right-hand part of the button
- Change the button to use "Run All" instead of "Run All Queries" to avoid localisation issues
|
|
|
|
|
|
|
|
|
|
|
|
| |
single button with dropdown menu with ability to change the default action:
- Create a new SPComboPopupButton class; this subclasses NSPopupButton to retain the ability to show the popup menu, but only when the right-hand side of the button is pressed, allowing the rest of the button to perform the click action
- Combine the previous two "Run" buttons on the Custom Query view into a new SPComboPopupButton
- Move the Run menu items from the gear menu into the Run button popup menu so they can be discovered more easily (and the shortcuts seen more easily)
- Add a menu item to switch the button's default action, which also swaps all associated shortcuts
- Clean up associated logic
This implements Issue #1569
|
|
|
|
| |
NULL; this implements Issue #1638
|
| |
|
|
|
|
| |
should conform to.
|
| |
|
| |
|
|
|
|
| |
to "Run Current")
|
| |
|
|
|
|
|
|
|
|
| |
results, in two different ways:
- Preserve the existing scroll rectangle if reloading the view
- Update the scroll rect on the main thread when not reloading the view
|
| |
|
| |
|