aboutsummaryrefslogtreecommitdiffstats
path: root/Source/SPConnectionController.m
Commit message (Collapse)AuthorAgeFilesLines
* Rework alert sheets:rowanbeentje2010-05-091-8/+5
| | | | | | | - Change MCPConnection.m to no longer use a reference to tableWindow to attach sheets - instead use a delate error display method if available - Rework TableSource and TableContent sheetDidEnd methods into per-task methods rather than overloading contextInfo - Rework SPAlertSheets to perform actions on the main thread, with the loss of (unused) support for a didDismissSelector. This addresses a number of crashes logged by the crash reporter
* Only attempt to check or set the max allowed packet if there is an active ↵stuconnolly2010-04-231-2/+4
| | | | connection as well as only displaying dialogs when there is a window visible. Fixes http://spbug.com/l/113.
* Fix an issue whereby choosing to edit the selected favourite in the ↵stuconnolly2010-04-201-1/+2
| | | | connection view would select the wrong favourite in the preferences because sorting has been applied to the table view.
* - Improve SPSSHTunnel question/password dialogs to no longer eat 100% CPU ↵rowanbeentje2010-03-311-0/+2
| | | | | | | | by switching from NSCondition blocking to NSLock blocking - Improve behaviour of SSH tunnels with no password in keychain - prompt appropriately - Set MXPConnection to check the proxy state when attempting to reconnect a dropped connection, extending the timer when an auth UI is up. This prevents a multiple-dialogs misbehaviour (or sometimes deadlock), addressing the last part of http://log.sequelpro.com/view/86 .
* Add support for selecting the triggers view as the default in the general ↵stuconnolly2010-03-251-1/+1
| | | | preferences pane.
* - Remove observers for key paths when dealloc'ing objects to fix later ↵rowanbeentje2010-03-231-1/+2
| | | | | | | crashes when changing those keyvalues (eg changing query editor background colour after closing windows - http://log.sequelpro.com/view/44 ) - Fix a memory leak of a prefs reference in CMTextView
* - Fix a couple of calls which crashed if the window had already been ↵rowanbeentje2010-03-181-0/+16
| | | | | | | closed, fixing window close on query startup or after queries; this fixes http://log.sequelpro.com/view/9 - Fix an exception caused in the NavigatorController if the dbstructure has not been fetched yet
* • Connection Controller ViewBibiko2010-03-161-0/+17
| | | | | - set favorite table's next key view in ConnectionView to tab view (standard,socket,ssh) to allow to navigate via ⇥ - if password field of the current selected connection in the ConnectionView is empty set first responder to it since it's very likely that user wants to fill it; otherwise favorite table is first responder
* - Fix exception on duplication of table source rows that haven't been saved ↵rowanbeentje2010-03-071-1/+1
| | | | | | | yet; this addresses http://log.sequelpro.com/view/23 - Clean up fix in r1859
* - When editing favourites from the connection screen, fix an exception when ↵rowanbeentje2010-03-071-1/+1
| | | | no selection is active. This addresses http://log.sequelpro.com/view/14
* Trim leading and trailing whitespace and newlines from the host and SSH host ↵stuconnolly2010-01-211-0/+6
| | | | input fields in the connection view. Fixes issue #545.
* Address Issue #546 (format string bugs):rowanbeentje2010-01-201-4/+5
| | | | | | - Fix incorrect uses of [NSString stringWithFormat:] with preconstructed strings and no arguments in SPUserManager - To fix display issues, replace NSBeginAlertSheet (which includes automatic sprintf expansion of the message) with a safely-escaped SPBeginAlertSheet in many files
* - Upgrade Sequel Pro to be compiled as a 3-way PPC/i386/x86_64 binary for ↵rowanbeentje2010-01-091-29/+29
| | | | | | | release builds, including a large number of 64bit compatibility upgrades and tweaks - Upgrade RegexKitLite to 3.3
* Move connection type constants to SPConstants.stuconnolly2009-11-151-23/+23
|
* - Enforce display of a number of interface elements while the main thread ↵rowanbeentje2009-11-121-0/+5
| | | | is blocked - this should address Issue #457
* Make the 'insufficient connection details' dialogs sheets.stuconnolly2009-11-111-2/+2
|
* Change the main window's non-connected/connecting state title to 'Sequel ↵stuconnolly2009-11-111-2/+13
| | | | Pro' and only change it to 'Connecting...' when we are actually trying to establish a connection. Fixes issue #456.
* Replace hard coded occurrences of preference key DefaultFavorite with a ↵stuconnolly2009-10-291-1/+1
| | | | constant.
* Replace the use of hard coded preference keys with constants to prevent ↵stuconnolly2009-10-171-15/+16
| | | | issues such as the one fixed in revision 1419. All future preference usage should be done so using these constants.
* • changed Error Detail HUD window for the connection manager slightly:Bibiko2009-10-131-0/+2
| | | | | | | - suppress spell checking - set left alignment - set a minimum window size - set font size to 12pt (to make it easier to read)
* - Preserve the "host" field for other connection types when socket ↵rowanbeentje2009-10-111-7/+8
| | | | connections are selected, synthesising "localhost" where necessary. This addresses Issue #384.
* Missing SVN properties.stuconnolly2009-10-091-1/+1
|
* • changed routine for opening SPF filesBibiko2009-10-061-0/+7
| | | | | | | | | - if no passwords are stored inside the SPF file try to retrieve the passwords from the KeyChain - for that purpose store the key 'kcid' in the SPF file if available - changed the accessory view: 'auto_connect' is always enabled (even no pw will be saved due to new routine) • fixed issue for Open Recent of SQL files • add a saved SPF file to Open Recent list if the user saved an Untitled doc or saved an open SPF file under an other name
* • while a connection will be initialized via a SPF file disable the ↵Bibiko2009-09-231-0/+4
| | | | possibility to choose an other connection from the favorites' list; otherwise the SPF file could run out of sync
* • due to new minimum size of the connection pane rearranged help buttonBibiko2009-08-281-1/+2
|
* Give the connection view's split view maximum and minimum sizes.stuconnolly2009-08-281-2/+15
|
* If the SSH tunnel is unable to bind to the local port because there is ↵stuconnolly2009-08-281-6/+38
| | | | already an existing tunnel, give the user the option of using a standard connection to localhost on the port that is in use in order to use the existing tunnel. Fixes issue #371.
* Rename MainController to SPAppController.stuconnolly2009-08-081-1/+1
|
* - Fix SSH tunnel support for private/public keys following framework ↵rowanbeentje2009-08-081-2/+2
| | | | upgrade changes
* - Fix "Add to favorites" behaviour when the user has no favourites (This ↵rowanbeentje2009-08-071-19/+18
| | | | | | | addresses Issue #354) - Improve favorites saving including names with anonymous users
* Rename Keychain class.stuconnolly2009-08-071-1/+1
|
* - When getting splitview sizes to resize database menu, correctly use the ↵rowanbeentje2009-07-281-2/+2
| | | | | | | subview size directly instead of the contents of the scrollview (which incorrectly doesn't measure presence of the scrollbar) - Remove the connection view entirely once a window has connected, fixing resize events following document splitview resize
* - Tweak table information panel to show scrollbars if it's resized to a ↵rowanbeentje2009-07-261-2/+1
| | | | | | | | position that would hide content - Store collapse state of table information panel in preferences - Apply a double fix for BWSplitView/NSSplitView+BWAnchoredButtonBar not informing delegates of resizes - correctly inform original BWSplitView delegates of resizes, and allow BWAnchoredButtonBar registered delegates to recieve the original split view resize notifications. This fixes database menu resizing in synch with splitview resizing for improved/consistent look and feel.
* To fix query logging not working, initialize delegateQueryLogging to YES ↵stuconnolly2009-07-231-0/+3
| | | | upon connection initialization as well as setting the value based on the user's preferences during initiateMySQLConnection in SPConnectionController. Also, initialize delegateResponseToWillQueryString when the connection's delegate is set and revert back to simply calling the delegate method willQueryString:connection: as opposed to using the selector cache as its currently not working. Might need to look into restoring this if we incur a big performance hit after this revision.
* Merge framework integration branch back to trunk. Summary of changes:stuconnolly2009-07-211-14/+24
| | | | | | | | | | | | | | | - Includes all custom code from subclasses CMMCPConnection and CMMCPResult, meaning they have subsequently been removed from the project. - All previous Sequel Pro specific code in the above subclasses has been removed in favour of the delegate (currently set to TableDocumet) informing the framework of such information. - All references to CMMCPConnection and CMMCPResult have subsequently been changed to MCPConnection and MCPResult. - Framework includes MySQL 5.1.36 client libraries and source headers. - Framework is now built as a 4-way (32/64 bit, i386/PPC arch) binary. - All import references to <MCPKit_bundled/MCPKit_bundled.h> have been changed to <MCPKit/MCPKit.h>. - New script 'build-mysql-client.sh' can be used to build the MySQL client libraries from the MySQL source. See the script's header for a list of available options or run it with no arguments to display it's usage. Note that there are still a few changes to be made to the framework with regard to removing Sequel Pro specific calls to the delegate. These however can be made later on as they have no effect on functionality and are merely design changes. Also, note that any future development done on the framework should be made to be as 'generic' as possible, with no Sequel Pro specific references. This should allow the framework to be integrated into another project without the need for SP specific code.
* - Make the DBView window the document window. This allows the document to ↵rowanbeentje2009-07-151-2/+2
| | | | | | | | | | be closed when the window is closed, freeing the document's memory - Update a number of dealloc methods to include more retained memory, and to avoid releasing non-retained memory - Remove notification observers and delegates where appropriate to avoid issues after document closing - Fix a couple of memory leaks - Support window cascading for all windows past the first, using the first window as the autosave window
* - Commit the second part of r995 (oops), addressing database selection issuesrowanbeentje2009-07-091-1/+1
|
* - Fix connection controller errors with nil strings (bindings?), fixing ↵rowanbeentje2009-07-091-0/+3
| | | | | | | Issue #331 - Make the "optional" socket more optional: add a list of common socket file locations that are checked (instead of just /tmp/mysql.sock), including MAMP to address a common use case
* - Ensure that error IDs are available from CMMCPConnection after connection ↵rowanbeentje2009-07-081-7/+11
| | | | | | | or database selection problems - Detect connection errors due to "Access denied" problems and show a clearer, more appropriate error message
* Overhaul the connection screen:rowanbeentje2009-07-061-0/+827
- Replace the connection sheet with a new connection view - Provide a tab-based selection system for Standard, Socket, and SSH connections, and show only the necessary fields. This resolves Issue #50. - Detect when "localhost" is used in error and alert the user (also to address Issue #50) - Update favorite editing to match connection view - Move connection methods to a new connection controller and tidy up TableDocument