aboutsummaryrefslogtreecommitdiffstats
path: root/Source/SPConnectionController.m
Commit message (Collapse)AuthorAgeFilesLines
* Merge further revisions from trunk back to the 1.0.x release branch:rowanbeentje2013-04-281-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - r4034: End editing for deleting content filter or query favourites, addressing exceptions and Issue #1648 - r4035: Apply schlabberdog's fix for log #3969, addressing Issue #1647 - r4036: Fix an error parsing SQL inside an unterminated delimiter statement causing an off-by-one error in positioning, addressing Issue #1643 - r4037: If date-type fields are cleared, and allow NULLs, save the cell value as NULL; this implements Issue #1638 - r4038: Alter the content filter manager and the query favourite manager to import items from a file into the Global group if the document is untitled, improving import UX and addressing Issue #1616 and Issue #1645. Also select and scroll to the newly imported items for clarity. - r4039: Fix crashes in the User Manager when fields don't validate but a save/cancel/tab switch is still triggered, addressing Issue #1627 - r4041: Tweak and improve the User Manager: Rework how data to populate the user manager is retrieved from the server, speeding up display of lots of users by a large factor; Fix support for schema permissions for the Anonymous user, and add support for '%' and '' hostnames (only showing if already set once), fixing Issue #1620; Highlight databases in the user manager that have permissions set for the selected user; Switch to using the centrally provided database list to reduce queries and remove the information_schema and performance_schema "databases"; Speed up a number of operations by tweaking the logic and queries used - r4042: Fix release builds after r4041; Update localizable strings - r4043: Set Sequel Pro to always run on Integrated Graphics on machines with both integrated and discrete, improving power consumption if nothing else is triggering the discrete GPU. This addresses Issue #1609 - r4044: Make the theme background apply to the query favourites editor - r4045: If the Custom Query editor view is active on window open, correctly set the focus in it, addressing Issue #1590 - r4046: Add support for querying the server default charset and collation; Move a bit of redundant code into a method - r4047: Restore tab bar label when cancelling a connection - r4048: Fix format string error in QueryKit - r4049: Alter the preferences favourite minimum version to avoid issues with previous runs of nightlies, which may partially address Issue #1588; Remove the old favourites key from the preferences now imports have succeeded - r4050: Allow Favorites import to read favorites from an old preferences .plist file, further addressing Issue #1588 - r4051: Change the string '=' and '!=' to be case- and collation-insensitive by default, using the Shift key (as documented in the tooltip) to trigger a BINARY exact match. This addresses Issue #1578 - r4052: When adding a database the servers default charset is now shown - r4053: Adjust keywords list to fix auto capitalisation of "ON" - r4054: Add a new SPMySQLEmptyResult class to SPMySQLFramework, returning it instead of nil if a query produces no result set. This allows per-result-set properties to be preserved, fixing issues where information like query execution time was lost - addressing Issue #1577 - r4056: Improve startup when loading from file, preventing overwrite of details read from a spf/spfs during startup. This addresses Issue #1619 - r4057: Correctly reset document state for setting it from file/when duplicating tab, further addressing Issue #1619 - r4058: Add a stub override to fix exceptions when code receiving a SPMySQLEmptyResult expects a SPMySQLStreamingResult/SPMySQLFastStreamingResult (Exception #3988) - r4060: Make some small tweaks to string BINARY handling: Correctly send the binary state/collation when reordering fields, addressing Issue #1265; Allow unticking of the binary box to save correctly, allowing conversion of fields to non-binary collations again - r4061: Fix errors when editing or moving columns on server vesions which do not support character sets/collations, addressing Issue #1629; Fix needless collation queries on those servers; Disable field enums and table encoding dropdown on those servers
* Merge a number of revisions from trunk back to the 1.0.x release branch:rowanbeentje2013-04-281-2/+27
| | | | | | | | | | | | | | | - r4021: Add a check for SPNotLoaded values when automatically generating new tables when importing CSVs, fixing Issue #1621 (SPNotLoaded values are generated when rows shorter than the header row are seen) - r4022: Fix crashes when importing favorites on the connection view, addressing Issue #1556; Select and scroll to newly created favorites after import - r4023: Default to disabling SSH multiplexing to avoid connection issues as per Issue #1457; leave multiplexing code present, but behind a preference. Run `defaults write com.sequelpro.SequelPro SSHMultiplexingEnabled -boolean YES` to re-enable - r4024: Fix handling of double-dash style comments within field names, addressing Issue #1554 - r4025: When favorites in the connection view gave no password, no longer set the focus to the password field as soon as they're selected; instead, make the password field the next responder for tab keys. This addresses Issue #1555 - r4028: Fix escaping of backlsashes in non-LIKE clauses, addressing string matching with the = and RegExp operators - addresses Issue #1563 - r4029: Fix handling of primary keys listing multiple fields of which an early field has a specified length, addressing Issue #1641 - r4030: Alter the database creation sheet to correctly use the selected new database encoding; Clean up the database creation logic and remove redundant selection logic; Correctly reset and detect the database encoding when creating and switching databases - r4031: Fix blurry text in a number of text views in 1.0.x (Possibly caused by IB mangling; recreated new text views with the same settings to address). This fixes Issue #1560 - r4032: Detect deleted or non-writable folders for export targets and give appropriate errors (particularly for saved paths), addressing Issue #1566 - r4033: Add support for export path tokens containing non-alphanumeric characters, automatically grouping and tokenising as required for both dragged and typed tokens. This addresses Issue #1567
* - Allow all filenames/types in SSH and SSL key/cert selection dialogs, to ↵release-1.0.1rowanbeentje2013-01-291-11/+2
| | | | fix naming issues; addresses Issue #1544 and Issue #1493
* Remove useless init and dealloc method comments and perform general tidy up.stuconnolly2013-01-221-2/+4
|
* - Prevent Groups from being created as a child of the Quick Connection ↵rowanbeentje2012-12-301-4/+2
| | | | item, instead creating them at the bottom of the favourites list to prevent favourite loss
* - Fix favourite editing on the connection interface being unable to delete ↵rowanbeentje2012-12-141-3/+25
| | | | some properties
* - Improve connection testing to use edited passwords on a connection with ↵rowanbeentje2012-11-281-6/+9
| | | | | | | keychain entries - Clean up connection error handling slightly
* - When the connection interface is restored as a result of a connection ↵rowanbeentje2012-11-201-1/+9
| | | | attempt cancellation or failure, restore the passwords from their bulleted-out state. This addresses Issue #1497.
* Fix the selected node in the favorites connection view when adding a new ↵stuconnolly2012-11-181-5/+6
| | | | favorite to an empty group.
* - Attempt to fix nightly build signingrowanbeentje2012-11-181-1/+1
| | | | | - Add .key to the SSH key accepted file type list to partially address Issue #1493
* - When connection details are saved, ensure the outline view reflects the ↵rowanbeentje2012-11-081-2/+3
| | | | change in edit status
* - Prevent new favourites from being created as a sibling/child of the Quick ↵rowanbeentje2012-10-201-2/+2
| | | | | | | Connect item if it was selected - Name a last unnamed connection thread
* - Add names for most threads created by Sequel Pro for easier debugrowanbeentje2012-10-141-2/+3
|
* - Clean up some connection cancellation/close-during-connect edges as a ↵rowanbeentje2012-10-141-4/+1
| | | | | | | result of r3894, attempting to improve some exceptions during aborted connections - Name threads created in SPMySQL.framework
* - In the SPMySQL.framework, separate framework-triggered connections and ↵rowanbeentje2012-10-141-17/+43
| | | | | | | | | disconnections from external actions, and use that separation to perform safer disconnects - When closing a database document, add a new notification, and use that to resolve retain cycles affecting connection processes - Improve connection controller disconnection when the document is closed, fixing crashes, by building on those two features (addresses Issue #1396) - Use some of the new functionality to improve SSH and MySQL connection cancellation, making both cancelable in the interface and making both respond much more quickly
* - Alter favourite sorting in the connection interface: name sorts are now ↵rowanbeentje2012-10-101-20/+29
| | | | | | | case-insensitive for a more Mac-like feel, groups are sorted alphabetically among favourite nodes when name sorting is being used, and above (or below when reversed) other favourites in type/host mode - Update localisable strings and fix a warning
* - Connection interface: correctly update the sort order when adding new ↵rowanbeentje2012-10-101-5/+18
| | | | items or renaming items. This addresses Issue #1209
* Connection interface tweaks:rowanbeentje2012-10-091-37/+57
| | | | | | | - When adding a new connection and name editing is entered, accept name changes without validating hostnames etc - When deleting groups of nodes, ensure that passwords for child nodes are correctly removed from the Keychain - Add remove item, rename item, and duplicate item entries to the connection interface gear menu (matching the contextual menu)
* - Connection interface: when adding a group node or item, ensure that it's ↵rowanbeentje2012-10-081-1/+10
| | | | visible by ensuring the parent item is expanded
* - Fix the Quick Connect entry on the connection screen being a drag and ↵rowanbeentje2012-10-081-1/+1
| | | | | | | drop target - Speculative fix for 10.6 & 10.5 connection screen padding/layout issues
* Change the connection screen interface, particularly relating to favourite ↵rowanbeentje2012-10-061-226/+355
| | | | | | | | | | | | | | editing on the connection screen (Issue #1339, Issue #1440): - No longer save changes made to connection favourites as soon as the interface is updated - Alter the interfaace if favourites are editing, offering to save the changes either to the old connection favourite or to a new favourite - Add a "Test connection" button to verify changes before saving - Add a "Quick Connect" entry to the top of the connection view's favourites list so a blank form is always available - Use a custom highlight when editing favourites to show the favourite has changed but is still linked - Reduce the margin on the left-hand side of the connection favourites list to increase the available space - Alter favourite name generation, making it less aggressive when generating names from partial details (eg creating names of just "@") and removing the user - Alter key icon usage to correctly update the button appearance if an SSL or SSH key is selected
* - Remove all BWToolKit elements in the connection view, replacing with ↵rowanbeentje2012-08-011-0/+14
| | | | | | | | | standard equivalents and SPSplitView - Replace the "Add" action menu on the connection view with two buttons for easier use and to avoid having to set up more popup buttons - Improve SPSplitView's handling of delegates set through code - Update localisable strings
* Change Sequel Pro's license from GPL (version 2) to MIT.stuconnolly2012-07-251-14/+21
|
* Merged SP r3710 with Codasqlprodev2012-07-051-0/+54
|
* - Fix flickering and incorrect connection view positioning on initial ↵rowanbeentje2012-06-051-2/+2
| | | | window creation
* - Fix loss of connection name/password for SSH connections whn switching ↵rowanbeentje2012-06-051-2/+6
| | | | | | | from an empty selection - Fix a build warning
* - Fix saving of connection password on host changes from triggering too oftenrowanbeentje2012-06-051-8/+2
|
* - Fix loss of password on certain connection editing actions (type changes, ↵rowanbeentje2012-06-041-0/+11
| | | | localhost/127.0.0.1 auto-type changes)
* - Remove delayed favourite selection call on tab setup. This fixes detail ↵rowanbeentje2012-06-031-52/+42
| | | | | | | reset issues causing Issue #1362 and Issue #1338, possibly others. - Clean up duplicate code setting and resetting connection interface state, ensuring one code path used by all
* - Fix deselection of favourites on key selection, correctly preserving ↵rowanbeentje2012-05-291-1/+0
| | | | | | | edits; this will improve Issue #1332 - Fix width of SSH key field
* - Fix issues where removing favorites could cause crashes in other ↵rowanbeentje2012-05-281-0/+7
| | | | | | | | tabs/windows where the favorite was selected (Issue #1351) - Keep multiple windows and tabs in sync when editing favorites - Fix a new KVO observation not being removed on object teardown
* Improve connection handling and editing:rowanbeentje2012-05-271-2/+5
| | | | | | | | | - Fix long-standing intermittent crashes caused by connection errors after SSH tunnels were established - Fix edits causing keychain -25299 errors (Issue #1340) - Allow changes of favourite type to be saved rather than disassociating the edit from the selection - Fix the favourites view scrolling to the top when there's no selection and connection details are being edited - Fix some issues with automatic naming of connections on connection type change
* Conection outline view fixes:stuconnolly2012-05-241-1/+38
| | | | | | | | | - When selecting a group node, instead of hiding the connection details, reset them to an empty state. - When removing a favorite make sure the details view is also set to an empty state. - Remove setting the outline view item's text colour, which should fix display issues on 10.7 Addresses points 1 & 5 on issue #1339.
* Improvements to connection view outline view:rowanbeentje2012-05-201-0/+3
| | | | | | | | | | - Prevent groups from being dragged into themselves (or child nodes) to prevent data loss - Improve selection handling when manually reordering nodes - Don't allow drags of the "Favorites" title at the top of the view to prevent exceptions - Prevent the "Favorites" title from being collapsed to prevent confusion on 10.7+ - Improve group tooltips to reflect contained favourites and groups - Improve menu validation checks
* - Clean up connection delegate on connection view close, addressing crashes ↵rowanbeentje2012-05-191-1/+4
| | | | when closing windows where connections are failing
* Fix implicit cast warnings.stuconnolly2012-05-111-1/+1
|
* - Iterate over group nodes backwards when removing them during sorting, ↵rowanbeentje2012-05-101-2/+2
| | | | fixing excpetions if sorting multiple group nodes in a tree
* - Ensure the selected connection is correctly scrolled to on Lion, working ↵rowanbeentje2012-05-101-1/+11
| | | | around animation issues
* Reapply changes from r3314, r3447 and r3450 from SPFavoritesPreferencePane ↵rowanbeentje2012-05-091-24/+30
| | | | to SPConnectionController, fixing tweaks missed by the outline view migration; particularly addresses Lion keychain cacheing issues causing password edits to make it appear that those passwords were lost for the rest of the session.
* - Fix crashes when duplicating favouritesrowanbeentje2012-05-081-16/+18
|
* Fix an error thrown when attempting to save favorites data to disk caused by ↵stuconnolly2012-05-081-3/+3
| | | | the handling of null values. This also subsequetly caused an exception to be thrown when checking if any passwords needed updated.
* When creating a connection favorite from the entered details, replace the ↵stuconnolly2012-05-031-2/+6
| | | | use of NSRunAlertPanel with SPBeginAlertSheet.
* Remove KVO observers when closing the main window.stuconnolly2012-05-031-4/+24
|
* Add support for saving the state of the connection favorites outline view.stuconnolly2012-05-031-1/+1
|
* - Fix a crash on closing windows by deregistering controller view ↵rowanbeentje2012-05-021-2/+3
| | | | | | | | notifications on dealloc - Fix a crash on opening windows after closing windows due to an overrelease of the favourites tree - Fix an exception on logging in due to incorrect keychain ID type on the document
* - Alter the variable that currentFavorite tracks to the favourite instead ↵rowanbeentje2012-05-021-13/+19
| | | | | | | of a copy of the represented node; this addresses a crash on Lion (Issue #1328) - Clean up variables and initialisers, restore connection keychain ID tracking and setting
* Fix memory leaks.stuconnolly2012-05-021-1/+5
|
* Make sure the connection details input is visible after removing a node.stuconnolly2012-05-021-0/+3
|
* Prevent connection initialization when there's no favorite selected.stuconnolly2012-05-021-8/+10
|
* When removing an empty group node don't display the warning about removing ↵stuconnolly2012-05-021-60/+79
| | | | the groups and favorites contained within it.