| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
- make usage of a notification sent by the [MCPConnection queryDbStructure] to update the navigator, and this decouples a doc window and MCPConnection from the navigator
- minimized the tree update - now connectionID-based
- any tree update will be now performed on main thread and waits until done to avoid 'overlapping' updates triggered by different notifications which normally ended up in an inchoate tree display
|
|
|
|
|
|
|
| |
returning nil if no error occurred (previously a blank string was returned most of the time)
- Add a new (BOOL)[MCPConnection queryErrored] method, changing all error message checks to use it for clarity
|
|
|
|
|
|
|
|
| |
- gather more information
- show infos for proc/func
- improved error handling
- reduced jittering while closing a connection window
- still hidden - if navigator is not visible no navigator code will be executed
|
|
|
|
| |
dealloc/unlock procedure. Addresses http://log.sequelpro.com/view/73
|
|
|
|
|
|
|
|
| |
address http://log.sequelpro.com/view/43 , http://log.sequelpro.com/view/46
- Improve keepalive timer interaction - this should address http://log.sequelpro.com/view/74 and http://log.sequelpro.com/view/71
- Further thread safety improvements to Custom Query, Table Document, and the history controller
|
|
|
|
| |
separation and fixing thread compatibility (not mentioned in docs but it seems NSTimers from terminated threads also terminate!)
|
| |
|
| |
|
|
|
|
| |
warnings
|
| |
|
|
|
|
| |
rather than the data processing thread. This ensures the connection unlock is walys called - even when no data is present - thus addressing Issue #594. (Prior to r1931 manual memory management caught this case anyway)
|
|
|
|
|
|
| |
- added key, extra, privileges information to it
- changed object type for 'field_name' to an array containing the values type, charset, key, extra, priv
- completion for fields now also shows PRI, MUL, etc. keys
|
|
|
|
|
|
|
|
|
| |
crashes: prevent multiple disconnects, add more checks, cancel current queries, and add a tiny delay to allow mysql cleanup.
- Alter MCPStreamingResult to no longer return a retained instance, setting up correct result disposal on autorelease but changing callers to retain as soon as they receive.
- Review and change a number of local variables shadowing/shielding other local or global variables.
|
|
|
|
| |
variables, a few leaks, and additional nil setting/checking to prevent overreleases or releases of random areas of memory.
|
|
|
|
| |
first launch of a version containing the framework. This will make the first-launch 0.9.8 experience much nicer, and avoid submitting lots of out of date reports.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
github master:
- Fix crashes in NSURLConnection (9d260f9b0e330adae01ca3255af194f46c7809b7)
- Fix bad NSStrings caused by non-terminated [cleanedAgent bytes] (d1c54608f77146e9b3a4c2ade5bbd5f5addfdf45)
- Fix for Sparkle Bug #393388: Leaking NSFileManager errors (afe8afc41f414af3234426a7406fe486f75e8485)
- Fix dictionary leak in system version fetch (f259b5e825098e8695713e16a39cf9d9b4d90edc)
- Fix NSMethodSignature leak (2d47989616547cde6cccb36ff4a33370b1b1f01c)
- Fix scheduleNextUpdateCheck crasher (9b5b541c8266cd009ee6fc779156c1a1207e8661)
- Fix appcast download crash on 10.5 if download fails (bd80144c7b67b7a66c215e40174dfb9310843573)
- Fix additional permission prompt autorelease crash (96ea09e44f018c9e10f9a1911b2104e164301876)
- Fix fr_CA.lproj symlink and generation (10bcc69c80cf58c831a411a7abf5012f3614fb10 and 0904ec151c242bc9a7a9976ed56a32e5a3b93951)
To be followed by a second part, restoring deleted nibs to be replaced by flattened 10.5+ nibs
|
|
|
|
|
|
|
| |
out at 30 seconds to prevent sleeping threads
- Improve keepalive timer interaction
|
|
|
|
|
|
| |
- Catch certain exception edge cases causing crashes (these exceptions are currently still not logged, but better than a crash)
- Capture and submit the last 10k of console log rather than the first 10k
|
|
|
|
| |
generation errors. This should address http://log.sequelpro.com/view/35
|
|
|
|
|
|
|
| |
previous 5.1.36
- Update MySQL client build script for snow leopard compatibility, and to build the client libraries as a three-way binary (x86/ppc/x86_64) in keeping with the rest of Sequel Pro
|
|
|
|
|
|
|
|
| |
- The delegate is now triggered for connectionLost: on the main thread, as this action will probably trigger a GUI update; this addresses http://log.sequelpro.com/view/10 .
- Connection proxy disconnects are now triggered on the main thread
- Connection checks are now made via a pthread'd ping in a loop, removing the reliance on SIGALRM which may hop thread execution back to the main thread when called on another thread. The new approach is cleaner but does rely on a loop with a sleep.
This will hopefully improve the disconnect/retry/reconnect crashes.
|
|
|
|
|
|
|
|
| |
- Update to a development version of the feedback reporter, which improves logging and allows functionality like exception reporting from non-main threads (together with many other improvements).
- Use the new preference privacy delegate methods to remove query history and favorite settings, together with other hostname/user path type settings, to anonymise the preferences submitted
- Limit the console log submitted to 10k
- Move the framework into the Frameworks folder
|
|
|
|
| |
inspection of leaks and Clang static analysis.
|
|
|
|
|
|
|
|
|
|
|
| |
functions (off by default). Remove the forked "...Sql..." functions, as they're now duplicates, and switch CustomQuery to using the original methods.
- TableDump imports can now process DELIMITERs correctly as a result.
- Alter the TableDump display of tables etc to use TablesList as the source of information, and used cached lists where appropriate for a small speedup. Also means we gain consistent sorting.
- Display procedures and functions in the toggleable list when exporting as SQL
- Tweak the procedure and function export to only export selected items, and also to respect the "export drop syntax" and "export create syntax" checkboxes
- Fix a crash when removing items from the TablesList resulted in an errorneous selection by deselecting all rows before deleting (and preemptively applying the same fix to TableContent)
|
|
|
|
| |
- Fixes issue where Database selector wasn't resizing to match Table list width.
|
|
|
|
|
|
|
| |
probably as a result of r1709
- Improve SSH and object cleanup, especially for cases where the connection drops, to ensure the connection proxy is cleaned up and all memory released
|
|
|
|
|
|
|
|
|
| |
- Set error strings on MCPConnection on user disconnect to allow existing error chcking to catch the state
- Improve close behaviour from threads
- Improve window close behaviour and appearance
- Add new checks for disconnection in one or two crash-prone locations
This addresses Issue #531, one of Issue #532, one of Issue #539, and probable reported crashes on Issue #541.
|
|
|
|
| |
completion
|
|
|
|
| |
certain conditions
|
|
|
|
| |
thread, as well as the existing background database connection, for a smoother experience
|
|
|
|
| |
Note: not yet finished!
|
|
|
|
| |
Note: not yet active - only querying the data in background will be performed for testing
|
|
|
|
|
|
|
|
|
| |
names/field names + type and encoding completion
- after connecting and updating the table list a background task executed on a different connection will be performed to query the information_schema db (MySQL >= 5 only so far)
- the MCPConnection object holds a NSDictionary with all structural data
Note: not yet active
|
|
|
|
|
|
|
| |
to avoid binary-mode result issues with certain versions of MySQL (including 4.1.14). This should address Issue #509.
- TableDocument now requests the server version string from MCPConnection, aiding caching
|
|
|
|
|
|
|
|
| |
- Updating BWToolkit to 1.2.2
- Changed BWToolkit from building it ourselves to just include the latest release of the framework
- Changed build settings to build 32 and 64 universal binaries
- Changed compiler to Clang
|
|
|
|
|
|
| |
- Fix a couple of memory leaks in the SPFieldEditor
- Fix a crash caused by attempted reselection of databases after disconnection if no database was selected
|
|
|
|
| |
MCPStreamingConnection for a ~10-15% speedup in CPU-bound loops (eg data sets with lots of rows but little data) by reducing lock contention. (To be tested against #463)
|
|
|
|
|
|
|
| |
an occasional crasher when getting table cells by adding a retain
- Alter MCPStreamingResult to use pthread mutexes in a further attempt to address Issue #463
|
|
|
|
|
|
|
|
| |
at the bottom. This addresses the last of Issue #49 and implements Issue #133; jump-to and two prefs affecting loading are available in a popup when clicking the pagination interface.
- Format row counts at the bottom of the content pane
- Increase the MCPStreamingResult buffer for a stronger workaround for #463
|
|
|
|
| |
processing rows - eg don't process the newly downloaded rows at once - as a workaround for Issue #463
|
|
|
|
| |
results. This improves partial content displays (using the new code as of r1530) and also improves custom query error reporting.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
functionality:
- MCPKit now supports cancelling the active query; for MySQL servers >= 5.0.0 a query kill is attempted from a new connection, and if that fails or for MySQL < 5 a reconnect is triggered.
- TableDocument now supports enabling a cancel task button on the task interface, including an optional callback
- Implement query cancellation for custom queries. This addresses Issue #86.
- Implement query cancellation for table content loads, filters, and sorts.
|
| |
|
|
|
|
|
|
|
| |
selected keys in Custom Query, preventing NSLock deadlocks
- Revery MCPConnection to locking on the *current* thread when running non-streaming queries, fixing deadlocks in some situations on background threads where the main thread is locked up via a modal loop - eg CSV import windows
|
| |
|
|
|
|
| |
window, regardless of key state, by passing in and looking for the table document instance
|
|
|
|
|
|
|
| |
custom queries
- Add error connection to query reselection to avoid exceptions when editing queries while running them
|