aboutsummaryrefslogtreecommitdiffstats
path: root/Frameworks
Commit message (Collapse)AuthorAgeFilesLines
* Swap two method calls to prevent a crash with the 10.12 SDK (#2609)Max2016-11-041-2/+5
| | | | | | | | | With this change we no longer KVObserve an object we aren’t interested in anymore and the -tabView:didCloseTabViewItem: method actually matches its name now (before it was more of a tabView:willCloseTabViewItem: method). Background: Normally the tab bar cell observes its delegate’s (SPDatabaseDocument) isProcessing property. Changes to this will trigger an async redraw of the tab view. The redrawing itself may involve a timer and a call to the tab view delegate (SPWindowController). Now, when the window is being closed this would cause the connection to close, which would affect the isProcessing property. However this time, when the timer is being fired the window controller would already be dealloc’d (since the tab bar delegate is unretained) causing a use-after-free crash. Previously -[PSMTabBarControl viewWillMoveToWindow:] stepped in at the right time and killed the timer before it could fire but on 10.12 the calls have shifted so the timer actually gets to fire and crash. This change solves the issue by not even letting the tab bar come to the point where it creates the problematic timer.
* Add possible socket locations for MariaDB via MacPorts.Sebastian Volland2016-08-301-3/+5
| | | | Also rename Darwinports to MacPorts in comments.
* Fix one erroneous method callMax2016-07-211-1/+1
| | | | Not sure if that may has been causing issues for some users...
* #2472 add tab button no longer moves when you hoverAbhi Beckert2016-06-201-3/+3
|
* fix various compile warningsAbhi Beckert2016-04-034-11/+14
|
* #346 Work on new tab bar designAbhi Beckert2016-03-1818-297/+136
|
* Restore bundled zlib (#1972)Abhi Beckert2016-03-052-0/+1605
|
* Remove bundled zlib #1927Abhi Beckert2016-03-042-1605/+0
|
* Failed postgres tests if cannot connect to host/dbMarius Ursache2016-03-011-0/+14
| | | | Otherwise the tests will just wait indefinitely
* Converted PostgresKit tests to XCTestMarius Ursache2016-03-0110-37/+53
|
* Added shared scheme for SPMySQL FrameworkMarius Ursache2016-02-291-0/+99
|
* Updated SPMySQL Framework SettingsMarius Ursache2016-02-293-3/+12
|
* Restored archs flag to build settingsMarius Ursache2016-02-291-0/+3
|
* Converted QueryKit tests from SenTestingKit to XCTestMarius Ursache2016-02-2914-81/+69
|
* Updated project specs, per Xcode 7 suggestionsMarius Ursache2016-02-294-8/+21
|
* Revert Xcode xcscheme shufflingMarius Ursache2016-02-291-4/+4
|
* Converted tests to XCTestMarius Ursache2016-02-261-4/+16
| | | | Converted the unit tests from SenTestingKit to XCTest as SenTestingKit was deprecated a couple of SDK versions ago.
* * Change a while() to do while; to help code analysisMax2016-02-182-4/+6
| | | | * Add log message (possibly related to #2258)
* Add another fallback for charset detection (which might improve ↵Max2016-02-061-1/+18
| | | | compatibility with Sphinx)
* Fix a rare crash due to calling a NULL method pointer (#2390)Max2016-02-011-4/+4
|
* Try to fix what could be the cause of #2353 ("Attempted to connect a ↵Max2016-01-154-1/+24
| | | | connection that is not disconnected")
* Add more debug info for "Attempted to connect a connection that is not ↵Max2016-01-132-3/+26
| | | | disconnected" crash (#2353)
* Another attempt at the 0x338 crash (#2258)Max2016-01-131-1/+1
|
* Fix wrong charset mapping for "latin1"Max2015-11-191-3/+3
|
* Add basic support for JSON type (part of #2199)Max2015-11-155-2/+12
|
* In order to enable even more people to shoot themselves in the foot, this ↵Max2015-11-122-0/+24
| | | | | | commit adds support for remote server shutdown 💣
* * Basic math is hard sometimes (fixes an issue introduced by me in ↵Max2015-10-311-1/+1
| | | | | | | b2d798ba9282d3acf1a2d65de30849e529d4d255) * Fix an exception that could occur when trying to view a damaged table * Fix a theoretical use-after-free issue by a wrongly structured retain/release in a setter
* * Add a wrapper method for 3 repeatetly used callsMax2015-10-305-12/+17
|
* * Lock connection during disconnect to prevent some race conditionsMax2015-10-304-59/+41
| | | | | * Always use the server version name provided by mysql_get_server_info() as that should me more reliable * Use mysql_get_server_version() for version comparisons. Less code, official API and closer to what mysql does
* * Remove some ivars that are only used as local varsMax2015-10-264-11/+9
| | | | * Also I take back what I said about 4d97cbd4df1ebb451d89d6c4e12dd7c622d00b84 and say it will happen now *duckundweg*
* This change will either reduce the amount of crashes or increase the amount ↵Max2015-10-171-0/+3
| | | | of beachballing. In the latter case please file an issue.
* Minor changeMax2015-10-173-17/+21
|
* Move a mysql_affected_rows() to see how the 0x338 crash behaves (#2258)Max2015-10-081-1/+7
|
* Add a few more unit tests to SPMySQLMax2015-10-043-5/+98
|
* Configure SPMySQL project to actually be able to run Unit TestsMax2015-10-043-6/+320
| | | | | | | | * Add a new configuration "Unit Tests" * Add a new Target for the Unit Test code * Assign Unit Test Target to the Test step of SPMySQL scheme * Also remove a compiler setting for PowerMac G5
* Remove a duplicate @interface and prepare some functions for unit testingMax2015-10-044-25/+19
|
* Add logging for a possible issue in Connection keepaliveMax2015-10-041-0/+4
|
* Add some debug code for another crash that has been happening latelyMax2015-10-021-1/+1
|
* Fix conversion of BIT fields (fixes #2254)Max2015-10-022-14/+84
|
* Remove a bit duplicate codeMax2015-09-301-5/+4
|
* Clarify thread namesMax2015-09-291-1/+3
|
* Added fallback code for server version identification.Max2015-08-074-17/+29
| | | | | Good news: Sequel Pro can now connect to sphinxql server. Bad news: It will treat it like a MySQL 2 server (or whatever version of Sphinx is running)
* * Expand the debugging code from prev. commitMax2015-08-061-0/+7
| | | | * Also Sequel Pro will now crash on the "Attempted to connect a connection that is not disconnected" issue. That is sadly necessary to get a stack trace of ALL threads as for exceptions Feedback Reporter only gives us the current thread.
* Add code to disable mysql protocol compression (no UI) to connect to Amazon ↵Max2015-07-304-5/+39
| | | | Aurora (see #2122)
* Fix an issue where Sequel Pro added a NUL byte to the end of every query ↵Max2015-07-292-9/+12
| | | | | | (fixes #2184) We tried to convert the query string into a c string that could contain NUL bytes - which by definition a c string cannot (making it a byte buffer with a terminating NUL byte) and then tried to pass that to mysql_real_query() which expects a byte buffer anyway.
* that also belongs to the previous commit...Max2015-07-141-0/+2
|
* Fix an exception caused by empty column names in query results (fixes #2173)Max2015-07-141-5/+10
| | | | Issue likely introduced in 2b52f76e.
* Fix an issue on 10.7+ introduced in ce33534Max2015-07-121-1/+1
| | | | This removes a IMHO useless makeFirstResponder: call. In all cases where [NSApp mainWindow] == usedSheet (< 10.7) the call right above it would already handle it. On the other hand if [NSApp mainWindow] != usedSheet (10.7+) the call would fail anyways because in that case editTextView is not even a subview of the main window.
* Replace some malloc(a*b) with the safer calloc(a,b) variantMax2015-06-301-1/+2
|
* There goes old Xcode again... 😩Max2015-06-251-1/+1
|