| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
- Fully lock the connection for background pings; this may slow down queries after connection disuse (when the keepalive is still active/blocked), but strengens thread safety to hopefully fix vio_delete crashes
- Fix pthread_cancel use; previously pthread_cancel after a keepalive may have resulted in cancelling unrelated threads where the thread ID was reused
This should increase stability and improve program consistency.
|
|
|
|
| |
mysql_real_escape_string (which require an active connection). This addresses http://spbug.com/l/54 .
|
|
|
|
|
|
|
| |
attempt to further address http://spbug.com/l/13
- Update localisable strings
|
|
|
|
| |
the application is in a modal state, the background thread waits. This improves interface behaviour on multiple SSH disconnections after sleep/wake (finishing Issue #798) and also disconnections while the interface is modally locked (eg editing text/blobs).
|
|
|
|
|
|
|
|
|
|
|
| |
with extended characters in MySQL identifiers (names of dbs/tables/cols):
- Move encoding queries and control into MCPKit, with newly cleaned-up methods, and switch a number of locations to using the new code.
- Use UTF8 connections for many identifier-based queries (selecting and listing databases, tables, stored procs, table information). This fixes selection and creation of table and database names containing extended characters, also fixing exceptions and errors.
- Improve UTF8 over Latin1 to correctly set the client character set encoding as well, fixing custom queries and edits; remove custom code in SPTableContent achieving the same thing in a single location.
- Fix database encoding detection routines
- Update localisable strings
|
|
|
|
| |
name encodings
|
|
|
|
| |
the Navigator
|
|
|
|
|
|
| |
- Fix toolbar issues when the last tab is dragged "out of" a window (eg a window is moved via the only tab left inside it)
- Fix window positioning flicker when dragging a tab out of its window
|
|
|
|
|
|
|
|
| |
syntax to \n. This addresses Issue #652.
- Clean up SPSQLParser, and use a few more CFString methods to avoid obj-c messaging in loops
- When importing SQL using autodetect, perform a manual SET NAMES if possible to cope with poorly-exported files.
|
|
|
|
|
| |
- Add controllable encoding support when importing CSV and SQL files, including a new default "Autodetect" option. Add UniversalDetector framework to support encoding autodetection. This should address Issue #720.
|
|
|
|
|
|
|
|
|
|
| |
BWToolkitFramework.framework
- Removed via builds scripts, so not included in the final product
- Allows loading .xibs using BWToolkit items without purposefully installing the .ibplugin beforehand
- Allows us to update the .ibplugin as we update the framework versions, to keep them in sync
Should allow people to load the Sequel Pro .xcodeproj and start building it more easily.
|
|
|
|
|
|
|
|
| |
- Sheets now appear positioned underneath the tab bar if visible
- Tweak bottom corner drawing for a clearer outline, without highlight overlay
- Frontmost tab no longer displays server name in the tab
Also fix exception when right-clicking on an index to reset auto-increment.
|
|
|
|
|
|
|
|
|
| |
methods
- Improve error handling when the connecting dies during import (previous the sheet would stay open)
- Fix localised strings for error messages (label and text the wrong way round)
- Improve comments
|
|
|
|
|
|
|
|
|
| |
- Exporting BIT fields properly in SQL dumps using b'x' notation.
- Properly handling editing of BIT fields in both the content and custom query results views.
- Correctly display BIT fields in the content view, where binary values are zero-padded to the specified length of the field.
(Note, that the new BIT handling logic has only been added to MCPKit's MCPStreamingResult and MCPResult as the latter does not keep a record of the field's length which the new functionality depends on. Needs to be discussed).
|
|
|
|
|
|
| |
- Allow keepalive pings to perform automatic reconnections after a few consecutive failures
- Fix a number of keepalive ping bugs, including compatibility with the new threaded connection methods and reconnection timing issues causing keepalive pings to not fire correctly
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attempt, as well as improved handling of networks not present. This addresses Issue #657.
In MCPKit:
- Disable MySQL automatic reconnection, and add our own reconnection code for greater consistency
- If no network is available, delay reconnects by a short period to allow the network to come back up
- Improved handling of proxy disconnects
In SPSSHTunnel:
- Improved handling of SSH tunnel disconnects, improving automatic reconnection via MCPKit and fixing potential memory/logic tramping.
Also remove the "Retry" button from the Disconnected dialog, leaving only the choices "Reconnect" or "Disconnect".
|
|
|
|
|
|
|
|
| |
- Add custom Safari-style tab close buttons
- Tweak margins, especially on the right when a progress indicator is active to avoid doubled margins
- Fix tab bar rendering when using font/help etc windows
Also update the .strings files to match latest changes
|
|
|
|
|
|
|
| |
socket search paths
- Reorder socket search paths to favour OS X locations
|
|
|
|
|
|
| |
- Improve hideForSingleTab: settings changes to only update the tab bar if only one tab exists; fixes tab sizing on drag start caused by placeholder cell/update tab bar display conflict
- Improve tab drag location detection, particularly when dragging tabs into a new tab bar; drags into new tab bars now respond quickly and correctly
|
|
|
|
|
|
|
| |
a tab past/through them, by using PSMTabBar notifications instead of our own notifications; also fix PSMTabBar notification ordering.
- When a tab drag starts, reorder all windows in front of other applications
|
| |
|
|
|
|
|
|
| |
- Fix a casting issue preventing release/dist builds
- Remove a line of old debug
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PSMTabBar general improvements:
- Fix a phantom tab appearing in windows a tab was just dragged out of
- Add support for a new control usersSafariStyleDragging property; this causes tabs being dragged inside a tab bar to snap to the tab bar, be drawn at full transparency (also no longer darkening the placeholder position), and alters tab ordering within the tab bar to be based on the tab position rather than the mouse position, for a more Mac-like reordering feel.
- Add support for dragging items onto the menubar to cancel the drag
- Alter the image of the dragged tab to use a tab drawn onto a transparent background instead of snapshotting a rectangle around the tab, improving drag appearance
- Allow tabs to be dragged partially off screen and keep their position instead of snapping back fully onto the screen
- Improve behaviour when dragging tabs out of and back into tab bars, or into new windows, resizing the tabs in the target tab bar to improve display and no longer intermittently showing close buttons while dragging
- Pull windows to the front as tabs are dragged onto their tab bars
- Abstract Custom Query Editor text snippet code, adding a delegate method so code could be moved to the SP window manager.
Sequel Pro tab styling improvements:
- Improve and clean up tab drawing code
- Draw background tabs with shadows as appropriate
- Improve logic for how background tab edges are drawn, handling edges cases better (active tab in overflow menu etc) and vastly improving drawing when a tab is being dragged (respect placeholder position when stacking tabs, draw edges on either side)
Sequel Pro tab behaviour improvements:
- Improve show/hide tab bar interaction
- Improve window positioning after creating new windows via a drag
- Alter tab dragging out of the tab bar to use an image based on the full window appearance - looks better, and fixes issues like the tab bar background not being drawn while dragging
|
|
|
|
|
|
|
| |
- added the CLIENT_MULTI_RESULTS flag to the connection flags
- automatically discard all remaining results when unlocking the connection
This is not a perfect solution, but will improve usability a lot for those who often call stored procedures. Sequel Pro still doesn't support multiple results -- it will show only the first and silently discard all the remaining ones.
|
|
|
|
| |
• setHideForSingleTab:YES after opening spfs session
|
|
|
|
| |
• added tooltips for tab's overflow menu
|
|
|
|
|
|
|
|
| |
- Fix display of the overflow menu
- Improve tab spacing and internal layout
- Improve tab names for documents to correctly show the database for background documents in additional cases
- Update strings files
|
| |
|
|
|
|
| |
corresponding db doc switches to Custom Query editor to be able eg to drag a query from one tab to another one
|
|
|
|
|
|
|
| |
drawing glitches, improved spacing, improved edge drawing
- Enable tab switch commands even when documents are working
|
|
|
|
| |
fixes a number of issues including http://spbug.com/l/13
|
|
|
|
| |
(still hidden)
|
|
|
|
| |
addresses crashes http://spbug.com/l/540 and http://spbug.com/l/106
|
|
|
|
|
| |
- Change line 373 of PSMTabBarControl to "SequelPro" to see new tabs.
- The drawing of the tab edges needs to be redone on the very edge of each tab instead of being inset by a number pixels to resolve a few issues.
|
|
|
|
| |
dependency, in preparation for future code and style changes
|
|
|
|
|
|
|
| |
the interface being updated from the wrong thread on listeners
- Add a "Support Files" folder to MCPKit, containing NSNotificationAdditions to support main thread notifications from within MCPKit
|
| |
|
|
|
|
|
|
|
|
| |
- Addition of PSMTabBar framework
- Rework away from a document-based TableDocument
- Support tabs throughout the application
- Add menu items for creating tabs, and add support for dragging tabs to different windows
|
|
|
|
|
|
|
|
| |
- Remove extra call when changing databases, avoiding double calls
- Fix an error if the document has had no encoding set yet (addresses http://spbug.com/l/200)
- Tweak db struture querying to work on MySQL 3 and 4.0
- Rework function to remove duplicated logic, and to address a number of valueForUndefinedKey: exceptions logged via the bug tracker
|
|
|
|
| |
addresses http://spbug.com/l/250
|
|
|
|
|
|
|
| |
- Change MCPConnection.m to no longer use a reference to tableWindow to attach sheets - instead use a delate error display method if available
- Rework TableSource and TableContent sheetDidEnd methods into per-task methods rather than overloading contextInfo
- Rework SPAlertSheets to perform actions on the main thread, with the loss of (unused) support for a didDismissSelector. This addresses a number of crashes logged by the crash reporter
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Details as follows:
* altered MCPConnection listTablesFromDB:like: to return NSArray
* altered MCPConnection listFieldsFromTable:like: to use backtick quoted
strings for table and fieldnames
* added MCPConnection listTablesFromDB for a complete table list
* added SPStringAdditions.h to various files to prevent warnings
* added sheets for duplicate/rename DB in DBView.xib
* added duplicate/rename menu items to MainMenu.xib
* added outlets in TableDocument: databaseNewSheet databaseRenameSheet
databaseCopyNameField databaseRenameNameField copyOnlyStructureButton
copyDatabaseButton renameDatabaseButton
* added methods in TableDocument: getConnection, copyDatabase, renameDatabase,
_copyDatabase, _renameDatabase
* added OCMock Framework for object mocking in tests
* added group Others/DatabaseActions
|
|
|
|
|
| |
- Alter build scripts to use --enable-local-infile as a configuration option; this addresses http://spbug.com/644
|
|
|
|
| |
process list. Fixes http://spbug.com/l/152.
|
|
|
|
| |
of them.
|
|
|
|
|
|
|
|
|
|
| |
- MCPKit's listProcesses (mysql_list_processes) method is now used, instead of running the query ourselves.
- The ability to set whether or not the list is auto refreshed.
- The ability to set the autorefresh interval, either via the presets or by entering a custom value (the interface for this might need updating).
- Get the process list is now performed on a background thread.
This completes the implementation of issue #607.
|
|
|
|
| |
connection as well as only displaying dialogs when there is a window visible. Fixes http://spbug.com/l/113.
|
|
|
|
|
|
|
|
| |
safe. From now on, always use [self lockConnection] rather than [queryLock lock], independent of what thread you are running on
- A warning is written to the console when the connection is unlocked multiple times (to identify potential race conditions)
- modified MCPStreamingResult to ensure it only closes the connection once
- added a check to prevent arrow key navigation past the last row
|
|
|
|
|
|
|
| |
- Add more calls to deregister watchers to fix crashes to closing threads or objects
- Fix a couple of memory leaks
- Alter a few calls to be performed on main thread (afterDelay: operates on the thread is is called on) - this fixed database reloading after import and field/index deletion error sheets
|