aboutsummaryrefslogtreecommitdiffstats
path: root/Frameworks
Commit message (Collapse)AuthorAgeFilesLines
* • navigatorBibiko2010-03-262-6/+7
| | | | | - fixed issue if different connection windows are connected to the same connection - prepared structure querying method to be able to add user info containing which table/db was changed if we know it to reduce the future parsing cost
* • Navigator and completion listBibiko2010-03-262-49/+57
| | | | | | - fixed issues for deletion of a db like remove all relevant items and refresh the navigator - simplified and minimized code and memory usage while querying the connection structure - whether a schema name is an unique db or table will be evaluated on run-time via allKeysofDbStructure
* • first steps to ease the structure querying for auto-completion and navigatorBibiko2010-03-262-35/+92
| | | | | | | - now it accumulates the data and caches them db by db, ie one has to select a db before using its structure for completion and navigator - next step is to avoid querying info_schema as much as possible - it will only query the structure if something was changed - next steps follows as soon as possible
* Revert a change made in r2005 by not waiting on the completion of calls to ↵stuconnolly2010-03-261-1/+1
| | | | unlockConnection on the main thread.
* Minor MCPKit tidy up, including the resolution of potential issues raised ↵stuconnolly2010-03-267-47/+128
| | | | during static analysis.
* - Simplify connection keepalives, moving to a single repeating timer on the ↵rowanbeentje2010-03-262-89/+37
| | | | | | | | main thread. This cleans up calls, results in small speed improvements when making lots of queries (no more stopping/starting of keepalives), and ensures only the main thread handles the initial keepalives. - Move connection unlocking to a blocking call to fix http://log.sequelpro.com/view/73 - Fix memory leaks caused by non-detached pthreads
* Suppress the connection structure query if there're more than 10000 items ↵Bibiko2010-03-251-2/+24
| | | | are listed in `information_schema`.`COLUMNS` for now which is a 'quick-fix' for i608. In the near future the gathering routine will do it db/table by db/table to minimize the traffic starting from the current selected db.
* • NavigatorBibiko2010-03-252-0/+24
| | | | | | | - first implementation of a search functionality, workable but tiny issues have to be improved - up to now the only search implemented is 'contains', regexp/fuzzy search will come soon - the search is only performed in the main outline view, the upper one is static - for the new search store all available schema paths uniquely in an array which will be set during queryDbStructure (this avoids re-parsing of a dict structure)
* • NavigatorBibiko2010-03-252-8/+6
| | | | | | - make usage of a notification sent by the [MCPConnection queryDbStructure] to update the navigator, and this decouples a doc window and MCPConnection from the navigator - minimized the tree update - now connectionID-based - any tree update will be now performed on main thread and waits until done to avoid 'overlapping' updates triggered by different notifications which normally ended up in an inchoate tree display
* - Make [MCPConnection getLastErrorMessage] more consistent by always ↵rowanbeentje2010-03-252-1/+10
| | | | | | | returning nil if no error occurred (previously a blank string was returned most of the time) - Add a new (BOOL)[MCPConnection queryErrored] method, changing all error message checks to use it for clarity
* • NavigatorBibiko2010-03-231-9/+14
| | | | | | | | - gather more information - show infos for proc/func - improved error handling - reduced jittering while closing a connection window - still hidden - if navigator is not visible no navigator code will be executed
* - Fix a crash when connecting to a non-existant database by cleaning up ↵rowanbeentje2010-03-231-4/+3
| | | | dealloc/unlock procedure. Addresses http://log.sequelpro.com/view/73
* - Simplify table source table setup and make thread safe. This should ↵rowanbeentje2010-03-221-0/+6
| | | | | | | | address http://log.sequelpro.com/view/43 , http://log.sequelpro.com/view/46 - Improve keepalive timer interaction - this should address http://log.sequelpro.com/view/74 and http://log.sequelpro.com/view/71 - Further thread safety improvements to Custom Query, Table Document, and the history controller
* - Tweak keepalive process, ensuring keepalives have a minimum time ↵rowanbeentje2010-03-221-2/+12
| | | | separation and fixing thread compatibility (not mentioned in docs but it seems NSTimers from terminated threads also terminate!)
* (no commit message)Bibiko2010-03-201-1/+4
|
* • further work on Navigator (not yet active but workable -> unHide menu item)Bibiko2010-03-192-8/+28
|
* - Clean up connection unlocking to prevent race conditions causing logged ↵rowanbeentje2010-03-191-5/+7
| | | | warnings
* - Improve thread locking in certain thread conditionsrowanbeentje2010-03-191-1/+1
|
* - Move streaming query result connection unlocking to the download thread ↵rowanbeentje2010-03-181-3/+4
| | | | rather than the data processing thread. This ensures the connection unlock is walys called - even when no data is present - thus addressing Issue #594. (Prior to r1931 manual memory management caught this case anyway)
* • changed NSDictionary structure for [MCPConnection queryDbStructure]Bibiko2010-03-171-6/+10
| | | | | | - added key, extra, privileges information to it - changed object type for 'field_name' to an array containing the values type, charset, key, extra, priv - completion for fields now also shows PRI, MUL, etc. keys
* - Make a number of changes to attempt to improve disconnection/quit ↵rowanbeentje2010-03-164-8/+22
| | | | | | | | | crashes: prevent multiple disconnects, add more checks, cancel current queries, and add a tiny delay to allow mysql cleanup. - Alter MCPStreamingResult to no longer return a retained instance, setting up correct result disposal on autorelease but changing callers to retain as soon as they receive. - Review and change a number of local variables shadowing/shielding other local or global variables.
* Following a manual code review, fix some local variables overriding global ↵rowanbeentje2010-03-153-7/+8
| | | | variables, a few leaks, and additional nil setting/checking to prevent overreleases or releases of random areas of memory.
* - Update feedback reporting framework to no longer submit crash logs on ↵rowanbeentje2010-03-131-0/+0
| | | | first launch of a version containing the framework. This will make the first-launch 0.9.8 experience much nicer, and avoid submitting lots of out of date reports.
* - Fix some leaks and autoreleases after checking static analysisrowanbeentje2010-03-131-0/+3
|
* Complete the Sparkle update, re-adding the updated nibsrowanbeentje2010-03-1325-0/+0
|
* Apply a number of updates to the Sparkle autoupdate framework from the ↵rowanbeentje2010-03-1381-1916/+4
| | | | | | | | | | | | | | | | github master: - Fix crashes in NSURLConnection (9d260f9b0e330adae01ca3255af194f46c7809b7) - Fix bad NSStrings caused by non-terminated [cleanedAgent bytes] (d1c54608f77146e9b3a4c2ade5bbd5f5addfdf45) - Fix for Sparkle Bug #393388: Leaking NSFileManager errors (afe8afc41f414af3234426a7406fe486f75e8485) - Fix dictionary leak in system version fetch (f259b5e825098e8695713e16a39cf9d9b4d90edc) - Fix NSMethodSignature leak (2d47989616547cde6cccb36ff4a33370b1b1f01c) - Fix scheduleNextUpdateCheck crasher (9b5b541c8266cd009ee6fc779156c1a1207e8661) - Fix appcast download crash on 10.5 if download fails (bd80144c7b67b7a66c215e40174dfb9310843573) - Fix additional permission prompt autorelease crash (96ea09e44f018c9e10f9a1911b2104e164301876) - Fix fr_CA.lproj symlink and generation (10bcc69c80cf58c831a411a7abf5012f3614fb10 and 0904ec151c242bc9a7a9976ed56a32e5a3b93951) To be followed by a second part, restoring deleted nibs to be replaced by flattened 10.5+ nibs
* - Use a modified connection timeout for the keepalive ping timeout, topping ↵rowanbeentje2010-03-111-5/+13
| | | | | | | out at 30 seconds to prevent sleeping threads - Improve keepalive timer interaction
* Update FeedbackReporter framework:rowanbeentje2010-03-101-0/+0
| | | | | | - Catch certain exception edge cases causing crashes (these exceptions are currently still not logged, but better than a crash) - Capture and submit the last 10k of console log rather than the first 10k
* - Update feedbackreporter framework to better cope with exception backtrace ↵rowanbeentje2010-03-091-0/+0
| | | | generation errors. This should address http://log.sequelpro.com/view/35
* - Update MySQL client libraries to 5.1.44, incorporating all changes since ↵rowanbeentje2010-03-093-2/+2
| | | | | | | previous 5.1.36 - Update MySQL client build script for snow leopard compatibility, and to build the client libraries as a three-way binary (x86/ppc/x86_64) in keeping with the rest of Sequel Pro
* Rework MCPConnection for greater thread safety:rowanbeentje2010-03-082-61/+87
| | | | | | | | - The delegate is now triggered for connectionLost: on the main thread, as this action will probably trigger a GUI update; this addresses http://log.sequelpro.com/view/10 . - Connection proxy disconnects are now triggered on the main thread - Connection checks are now made via a pthread'd ping in a loop, removing the reliance on SIGALRM which may hop thread execution back to the main thread when called on another thread. The new approach is cleaner but does rely on a loop with a sleep. This will hopefully improve the disconnect/retry/reconnect crashes.
* Improve Feedback reporter privacy and functionality:rowanbeentje2010-03-0614-0/+90
| | | | | | | | - Update to a development version of the feedback reporter, which improves logging and allows functionality like exception reporting from non-main threads (together with many other improvements). - Use the new preference privacy delegate methods to remove query history and favorite settings, together with other hostname/user path type settings, to anonymise the preferences submitted - Limit the console log submitted to 10k - Move the framework into the Frameworks folder
* Fix a number of memory leaks, and over-releases, as both a result of manual ↵rowanbeentje2010-02-103-23/+25
| | | | inspection of leaks and Clang static analysis.
* - Rework SPSQLParser, extending DELIMITER support into all the original ↵rowanbeentje2010-02-051-1/+1
| | | | | | | | | | | functions (off by default). Remove the forked "...Sql..." functions, as they're now duplicates, and switch CustomQuery to using the original methods. - TableDump imports can now process DELIMITERs correctly as a result. - Alter the TableDump display of tables etc to use TablesList as the source of information, and used cached lists where appropriate for a small speedup. Also means we gain consistent sorting. - Display procedures and functions in the toggleable list when exporting as SQL - Tweak the procedure and function export to only export selected items, and also to respect the "export drop syntax" and "export create syntax" checkboxes - Fix a crash when removing items from the TablesList resulted in an errorneous selection by deselecting all rows before deleting (and preemptively applying the same fix to TableContent)
* Update to BWToolkit 1.2.5avenjamin2010-01-3012-275/+28
| | | | - Fixes issue where Database selector wasn't resizing to match Table list width.
* - Fix SSH threads (and connections) which were never cleaned up or closed, ↵rowanbeentje2010-01-271-11/+18
| | | | | | | probably as a result of r1709 - Improve SSH and object cleanup, especially for cases where the connection drops, to ensure the connection proxy is cleaned up and all memory released
* Improve Disconnection on connection loss:rowanbeentje2010-01-241-1/+6
| | | | | | | | | - Set error strings on MCPConnection on user disconnect to allow existing error chcking to catch the state - Improve close behaviour from threads - Improve window close behaviour and appearance - Add new checks for disconnection in one or two crash-prone locations This addresses Issue #531, one of Issue #532, one of Issue #539, and probable reported crashes on Issue #541.
* • added method to get an info about unique database/tables names for ↵Bibiko2010-01-142-1/+42
| | | | completion
* Replace COUNT(*) with COUNT(1) which is usually faster, and much faster in ↵bamse162010-01-141-2/+2
| | | | certain conditions
* - Move the query for the database structure to a background processing ↵rowanbeentje2010-01-121-2/+4
| | | | thread, as well as the existing background database connection, for a smoother experience
* • further developments for the F5 completionBibiko2010-01-111-2/+1
| | | | Note: not yet finished!
* • further preparations to F5 completionBibiko2010-01-111-5/+17
| | | | Note: not yet active - only querying the data in background will be performed for testing
* • first preparations to improve the Custom Query database names/table ↵Bibiko2010-01-102-0/+150
| | | | | | | | | names/field names + type and encoding completion - after connecting and updating the table list a background task executed on a different connection will be performed to query the information_schema db (MySQL >= 5 only so far) - the MCPConnection object holds a NSDictionary with all structural data Note: not yet active
* - Ensure all results for server variable requests are returned as strings, ↵rowanbeentje2010-01-035-20/+56
| | | | | | | to avoid binary-mode result issues with certain versions of MySQL (including 4.1.14). This should address Issue #509. - TableDocument now requests the server version string from MCPConnection, aiding caching
* - Updating Growl to 1.2avenjamin2009-12-20340-30230/+47
| | | | | | | | - Updating BWToolkit to 1.2.2 - Changed BWToolkit from building it ourselves to just include the latest release of the framework - Changed build settings to build 32 and 64 universal binaries - Changed compiler to Clang
* - Fix saving of files or images added to the SPFieldEditorrowanbeentje2009-12-041-1/+1
| | | | | | - Fix a couple of memory leaks in the SPFieldEditor - Fix a crash caused by attempted reselection of databases after disconnection if no database was selected
* - Make a change to the area covered by threading locks in ↵rowanbeentje2009-11-281-4/+2
| | | | MCPStreamingConnection for a ~10-15% speedup in CPU-bound loops (eg data sets with lots of rows but little data) by reducing lock contention. (To be tested against #463)
* - Fix a couple of thread safety issues in TableContent, and attempt to fix ↵rowanbeentje2009-11-242-4/+45
| | | | | | | an occasional crasher when getting table cells by adding a retain - Alter MCPStreamingResult to use pthread mutexes in a further attempt to address Issue #463
* - Replace the LIMIT interface on the content view with a pagination control ↵rowanbeentje2009-11-231-2/+2
| | | | | | | | at the bottom. This addresses the last of Issue #49 and implements Issue #133; jump-to and two prefs affecting loading are available in a popup when clicking the pagination interface. - Format row counts at the bottom of the content pane - Increase the MCPStreamingResult buffer for a stronger workaround for #463
* - Keep a buffer of at least one full row between the downloading and ↵rowanbeentje2009-11-201-3/+6
| | | | processing rows - eg don't process the newly downloaded rows at once - as a workaround for Issue #463