| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Backport of 2b52f76ed2103bc6d458767906753814ee8ba9e1 & 2b52f76ed2103bc6d458767906753814ee8ba9e1
|
| |
|
|
|
|
| |
of beachballing. In the latter case please file an issue.
|
|
|
|
| |
Backport of 3aadea1be33212ca50e7faffcd0620ea976f9d59
|
|
|
|
| |
compatibility with Sphinx)
|
|
|
|
| |
backport from c7b5e880003153e599a452151ee1f3a3e40aff4c and b2d798ba9282d3acf1a2d65de30849e529d4d255
|
| |
|
| |
|
|
|
|
|
|
| |
(fixes #2184)
We tried to convert the query string into a c string that could contain NUL bytes - which by definition a c string cannot (making it a byte buffer with a terminating NUL byte) and then tried to pass that to mysql_real_query() which expects a byte buffer anyway.
|
|
|
|
| |
This removes a IMHO useless makeFirstResponder: call. In all cases where [NSApp mainWindow] == usedSheet (< 10.7) the call right above it would already handle it. On the other hand if [NSApp mainWindow] != usedSheet (10.7+) the call would fail anyways because in that case editTextView is not even a subview of the main window.
|
| |
|
|
|
|
| |
Hey, I was against this, but if you want it... - just don't blame me for what might happen :shipit:
|
|
|
|
| |
Replaced some (range.location + range.length) with NSMaxRange(range)
|
| |
|
| |
|
|
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
|
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
|
|
|
| |
arguments
|
|
|
|
| |
This commit adds the backend code to get the mysql SQLSTATE error code (to be used when displaying errors).
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
increases and lower memory usage:
- Add a new SPMySQLStreamingResultStore class to SPMySQL.framework. This class acts as both a result set and a data store for the accompanying data, storing the row information in a custom format in a custom malloc zone.
- Amend SPDataStorage to wrap the new class, so original result information is stored in the one location in the custom format. Any edited information is handled by SPDataStorage for clean separation
- Rework table content and custom query data data stores to use the new class. This significantly speeds up data loading, resulting in faster data loads if they weren't previously network constrained, or lower CPU usage otherwise. The memory usage is also lowered, with the memory overhead for many small cells being enormously reduced.
|
| |
|
|
|
|
| |
enable some more
|
|
|
|
| |
Issue #1708
|
|
|
|
| |
instead of nil if a query produces no result set. This allows per-result-set properties to be preserved, fixing issues where information like query execution time was lost - addressing Issue #1577
|
| |
|
| |
|
|
|
|
|
|
|
| |
result of r3894, attempting to improve some exceptions during aborted connections
- Name threads created in SPMySQL.framework
|
|
|
|
|
|
|
|
|
| |
disconnections from external actions, and use that separation to perform safer disconnects
- When closing a database document, add a new notification, and use that to resolve retain cycles affecting connection processes
- Improve connection controller disconnection when the document is closed, fixing crashes, by building on those two features (addresses Issue #1396)
- Use some of the new functionality to improve SSH and MySQL connection cancellation, making both cancelable in the interface and making both respond much more quickly
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
address Issue #877:
- On servers with very short timeouts set the wait_timeout for the session as well as the interactive_timeout to prevent the connection from dropping frequently
- Improve recovery from connection errors, correctly restoring the connection if appropriate and possible
- Allow reconnections to occur recursively by altering the internal tracking mechanism
- Fix some edge cases where the connection would remain locked incorrectly
- Improve error messaging for the "MySQL Server has gone away" network case
|
|
|
|
|
|
|
|
|
|
|
| |
reviewing crash logs and testing a number of situations:
- Improve stability of closing connections after a connection loss
- Minimise prompting a user for connection state restore if closing windows/tabs
- Allow cancellation of keepalive ping threads to prevent crashes after deallocation of parent
- Manually handle ping thread state struct memory to avoid cross-thread deallocation issues
- Improve disconnection speed and resilience
|
|
|
|
| |
of a reference to the retained error string to avoid any overrelease errors later affecting the framework
|
|
|
|
| |
paths, improving general connection robustness in recent builds
|
|
|
|
|
| |
- Improve debug to catch a structure connection issue
|
|
|
|
|
|
|
|
|
|
|
|
| |
background loss of connections:
- Attempt to fix a condition causing a reconnection loop by fixing the order of connection state check and a query variable
- If a connection is lost in the background, only attempt a single reconnect instead of requiring user intervention at once
- Add a new connection state to handle background disconnects
- If the connection has been lost in the background but is about to be used, reconnect it automatically (informing the user of loss if appropriate)
- Don't attempt background reconnections if the connection has not been used for some time
(Also update localisable strings, and tweak navigator controller connection usage)
|
|
|
|
| |
mysql_thread_init() and mysql_thread_end() on each thread as appropriate. This will improve observed MySQL stability, especially in certain circumstances such as LOAD DATA INFILE.
|
|
|
|
|
|
|
| |
improve memory usage during large exports, particularly improving memory which appeared to never be reclaimed
- Fix some minor memory leaks throughout the application
|
|
|
|
|
|
|
|
| |
up-to-date codebase.
- Update the build-mysql-client.sh MySQL build script within SPMySQL.framework to allow it to easily build 5.5 client libraries
- Fix reconnection within SPMySQL.framework after a connection is lost for MySQL servers < 5 when a query is cancelled by killing the connection
|
|
|
|
|
|
|
| |
getters and manually overridden setters
- Fix autoincrement ID retrieval in SPMySQL, addressing issues previewing rows when the setting for "Reload Table After: Adding a row" is not being used
|
|
|
|
| |
mySQLTickQuotedString declarations
|
|
|
|
| |
settings in SPMySQL when connections time out, addressing Issue #1309
|