aboutsummaryrefslogtreecommitdiffstats
path: root/Frameworks/SPMySQLFramework/Source/SPMySQLConnection.m
Commit message (Collapse)AuthorAgeFilesLines
* - Clean up some connection cancellation/close-during-connect edges as a ↵rowanbeentje2012-10-141-2/+2
| | | | | | | result of r3894, attempting to improve some exceptions during aborted connections - Name threads created in SPMySQL.framework
* - In the SPMySQL.framework, separate framework-triggered connections and ↵rowanbeentje2012-10-141-104/+134
| | | | | | | | | disconnections from external actions, and use that separation to perform safer disconnects - When closing a database document, add a new notification, and use that to resolve retain cycles affecting connection processes - Improve connection controller disconnection when the document is closed, fixing crashes, by building on those two features (addresses Issue #1396) - Use some of the new functionality to improve SSH and MySQL connection cancellation, making both cancelable in the interface and making both respond much more quickly
* Improve connection handling and recovery in general, and specifically to ↵rowanbeentje2012-08-181-8/+12
| | | | | | | | | | | address Issue #877: - On servers with very short timeouts set the wait_timeout for the session as well as the interactive_timeout to prevent the connection from dropping frequently - Improve recovery from connection errors, correctly restoring the connection if appropriate and possible - Allow reconnections to occur recursively by altering the internal tracking mechanism - Fix some edge cases where the connection would remain locked incorrectly - Improve error messaging for the "MySQL Server has gone away" network case
* Improve connection keepalive, disconnect, and connection loss after ↵rowanbeentje2012-05-151-7/+31
| | | | | | | | | | | reviewing crash logs and testing a number of situations: - Improve stability of closing connections after a connection loss - Minimise prompting a user for connection state restore if closing windows/tabs - Allow cancellation of keepalive ping threads to prevent crashes after deallocation of parent - Manually handle ping thread state struct memory to avoid cross-thread deallocation issues - Improve disconnection speed and resilience
* - Fix incorrect reconnection detection in the new SPMySQL reconnection code ↵rowanbeentje2012-05-121-0/+1
| | | | paths, improving general connection robustness in recent builds
* - Fix a build warning caused by r3649 changesrowanbeentje2012-05-101-1/+1
| | | | | - Improve debug to catch a structure connection issue
* Rework connection loss handling in SPMySQL, particularly to improve ↵rowanbeentje2012-05-081-172/+231
| | | | | | | | | | | | background loss of connections: - Attempt to fix a condition causing a reconnection loop by fixing the order of connection state check and a query variable - If a connection is lost in the background, only attempt a single reconnect instead of requiring user intervention at once - Add a new connection state to handle background disconnects - If the connection has been lost in the background but is about to be used, reconnect it automatically (informing the user of loss if appropriate) - Don't attempt background reconnections if the connection has not been used for some time (Also update localisable strings, and tweak navigator controller connection usage)
* - Correctly call mysql_library_init() on application start, and ↵rowanbeentje2012-04-181-0/+61
| | | | mysql_thread_init() and mysql_thread_end() on each thread as appropriate. This will improve observed MySQL stability, especially in certain circumstances such as LOAD DATA INFILE.
* - Fix SPMySQL warnings about delegate and proxy methods mixing synthesized ↵rowanbeentje2012-03-291-2/+1
| | | | | | | getters and manually overridden setters - Fix autoincrement ID retrieval in SPMySQL, addressing issues previewing rows when the setting for "Reload Table After: Adding a row" is not being used
* - Correctly nest reconnection attempts to preserve previous connection ↵rowanbeentje2012-03-281-2/+7
| | | | settings in SPMySQL when connections time out, addressing Issue #1309
* SPMySQL integration bugfixes:rowanbeentje2012-03-141-1/+1
| | | | | | | - Fix a bug where the socket path would not be autodetected if an empty string was supplied - Fix a bug fetching primary key column names for tables - Fix a bug building database structures on MySQL 3.x servers
* Final feature work on the SPMySQL branch before merging:rowanbeentje2012-03-141-8/+8
| | | | | | | | - Add a ping keepalive managing object to prevent retain cycles from the NSTimer - Add -[SPMySQLConnection copy] support - Refactor Hans-Jörg Bibiko's database structure retrieval, moving it out of the MySQL framework and building it around a copy of the connection. This reduces the amount of connections-over-time used by Sequel Pro to two constant connections (addressing Issue #1097) and improves robustness. - Use the database structure retrieval connection for faster query cancellation without an extra connection required, if possible
* Initial commit of the new SPMySQL Framework, which is added to the project ↵rowanbeentje2012-02-201-0/+834
and ready for use but not yet integrated. This new framework should provide much of the functionality required from MCPKit and is based around its interface for relatively easy integration. The largest missing component is Hans' structure code which I believe is better placed outside the framework. From the Readme file: The SPMySQL Framework is intended to provide a stable MySQL connection framework, with the ability to run text-based queries and rapidly retrieve result sets with conversion from MySQL data types to Cocoa objects. SPMySQL.framework has an interface loosely based around that provided by MCPKit by Serge Cohen and Bertrand Mansion (http://mysql-cocoa.sourceforge.net/), and in particular the heavily modified Sequel Pro version (http://www.sequelpro.com/). It is a full rewrite of the original framework, although it includes code from patches implementing the following Sequel Pro functionality, largely contributed by Hans-Jörg Bibiko, Stuart Connolly, Jakob Egger, and Rowan Beentje: - Connection locking (Jakob et al) - Ping & keepalive (Rowan et al) - Query cancellation (Rowan et al) - Delegate setup (Stuart et al) - SSL support (Rowan et al) - Connection checking (Rowan et al) - Version state (Stuart et al) - Maximum packet size control (Hans et al) - Result multithreading and streaming (Rowan et al) - Improved encoding support & switching (Rowan et al) - Database structure; moved to inside the app (Hans et al) - Query reattempts and error-handling approach (Rowan et al) - Geometry result class (Hans et al) - Connection proxy (Stuart et al)