| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Take this commit as a proposal to formalize our existing "[x release], x = nil;" convention by introducing a macro for it.
Feel free to revert this commit if you see issues with the approch or implementation.
|
| |
|
|
| |
When cancelling a connection, because SSH is asking for a password, the "SSH connecting…" message in the upper right window corner would not be reset.
|
| |
|
|
| |
(Also deduplicated some code)
|
| |
|
|
|
| |
(Import would not work on a new installation where a certain preference key has not yet been set)
* Also attached the gear menu in table structure view to the table header view, so the columns to show can now be selected by right-clicking on the table header (like in Activity Monitor)
|
| |
|
|
| |
The current status of Growl/Notification center will now be shown as a label beneath the "Enable notifications" checkbox.
|
| |
|
|
|
| |
As per https://code.google.com/p/growl/wiki/SystemRequirements this should not break compatibility with Sequel Pro and the API stays the same.
This change gives us Notification Center support for free, though.
|
| | |
|
| | |
|
| |
|
|
|
| |
The method never did the one extra thing it should do, because… see comment in the code.
Let's see how this works out :)
|
| |
|
|
|
| |
* Tooltips were somewhat broken for non-imported fields (issue exists in 1.0.2)
* Newly added expressions would cause the field to switch to "do not import" instead of the added expression
|
| |
|
|
|
|
|
|
|
| |
This change should fix the "slow CSV import dialog" issue on 10.10 (details below). To accomplish that, some major changes had to be made to the CSV import code. PLEASE VERIFY THE CORRECTNESS OF THE NEXT FEW CSV IMPORTS YOU DO!
* Renamed some variables for better search visibility
* Changed some instances where NSNumbers were being compared using "==" instead of "isEqual…" (does not work with object literals!)
* The CSV import dialog would recreate the popup menus on *every* call to "tableView:objectValueFor…". However Instruments suggests that [NSMenu removeAllItems] and [NSMenu addItemsWithTitles:] are **really** expensive, esp. when called multiple times per second (e.g. when scrolling in the table view). This commit moves the popup menu setup into its own method and only calls it when the data actually changes.
* The 'destination table column' was for some reason a NSPopupButtonCell which only ever had one item and sometimes got changed to a NSTextFieldCell in code. I didn't see any need to keep the popup cell and replaced it with a simple text cell.
|
| |
|
|
| |
(as the nib loader on 10.10 is even whinier)
|
| |
|
|
|
| |
* A call of setString: from background thread which could cause a "deleted thread with uncommitted CATransaction" warning
* SPFieldMapperController was allocated from a background thread with an own autoreleasepool, while it contains UI objects. This could cause a crash when the autoreleasepool was drained and the field mapper forcefully released, while other UI objects still had it retained.
|
| |
|
|
| |
(Purely guessing here…)
|
| | |
|
| |
|
|
|
| |
No"real" changes were made.
NOTE: There is actually a chance for this change to break stuff.
|
| | |
|
| |
|
|
| |
(so the compiler can unroll it again)
|
| |
|
|
| |
Caused by an earlier commit of mine.
|
| |
|
|
| |
This should fix #2010. A required object was not retained long enough.
|
| | |
|
| | |
|
| |
|
|
| |
Changing the query favorties/history would cause an UI inconsitency when the list was filtered before.
|
| |
|
|
|
|
| |
* [NSDictionary dictionary] → @{}
* [NSDictionary dictionaryWithObject:forKey:] can safely be replaced. object==nil would have already thrown a NPE in the past.
* Also replaced some (hopefully safe) NSArray initializers (ie. their objects should always exist).
|
| |
|
|
| |
Note: [NSArray arrayWithObjects:...,nil] is left unchanged as that could possibly cause a NPE if converted to @[]
|
| |
|
|
|
| |
* (Also changed some outdated URLs)
* Replaced [NSApplication sharedApplication] with NSApp
|
| | |
|
| |
|
|
|
| |
Replaced all [NSNumber numberWithBool:YES/NO] with the @YES/@NO literals.
Also replaced some TRUE/FALSE with their YES/NO counterparts.
|
| | |
|
| | |
|
| |
|
|
| |
And with that we are back to a build that should not spam your Console upon launch. (Sorry for the future merge conflict) :)
|
| |
|
|
| |
At some point Xcode decided to introduce a new variant of black named "labelColor" (which is 10.10 only). This commit changes the DBView xib back to controlTextColor instead.
|
| |
|
|
|
| |
Switchting the IB files to Xcode 5 introduced some kind of image reference for some of our popup buttons, which was kept when we switched back to 4.6 format.
However as this wasn't used in the 4.6 files before switchting to 5 either, I just removed that stuff.
|
| |\
| |
| | |
Remove a private API in PSMTabBarCell
|
| | | |
|
| |/
|
|
|
|
| |
Directly assigning to _controlView of a NSActionCell is private and not allowed by Mac App Store.
An _customControlView is used to replace _controlView in PSMTabBarCell to avoid direct assigning to _controlView.
This should be the last private API to remove before going to Mac App Store.
|
| | |
|
| |
|
|
| |
Fixes #2029
|
| |
|
|
|
|
| |
(Actually I only enabled CALayer for the container.)
Also deleted a NSView that was thinking it was a NSButton, invisible, and not connected to anything. Hopefully no one will miss that thing.
|
| |
|
|
|
|
| |
* Attempt to fix the "<SPSplitView: ...>: the delegate <SPSplitView: ...> was sent -splitView:resizeSubviewsWithOldSize: and left the subview frames in an inconsistent state:" message that has been plaguing my console for some time.
* This commit also adds a minimum width on the main area to prevent some strange UI bugs.
|
| |
|
|
|
|
| |
This commit switches our pagination popover to use native NSPopover on 10.7+ making it look more polished and modern.
On 10.6 the old style will be used, *however* that one might still suffer from a bug caused by undefined overlapping view drawing behaviour.
|
| |
|
|
| |
This is implemented as an alternate menu item, ie. it will appear when holding down the Option (alt) key instead of the normal "Open Table in new Tab" item. Fixes #2015
|
| |
|
|
|
|
|
| |
Previously our cog menus have been Round Rect (borderless) NSPopupButtons with text aligned to the left of the image as that combination would allow us to make the box of the button exactly as big as the image.
However in 10.10 Apple changed the layout so that a padding is always added on the right border of a popup button (except if the menu is attached to the left).
From playing around I found the only setting to be compatible between 10.9 and 10.10 to be the button type Bevel (borderless).
This commit changes all cog buttons to Bevel type in hopes those will also look the same on 10.8, 10.7, 10.6.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Namely this commit changes two things:
1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491):
[NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release
[[self window] orderOut:self];
This call order has now been swapped.
2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority.
Requesting QA on this commit.
|
| |\
| |
| |
| |
| | |
Conflicts:
Source/SPGotoDatabaseController.m
|
| | | |
|
