aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* - Improve SPSSHTunnel question/password dialogs to no longer eat 100% CPU ↵rowanbeentje2010-03-314-31/+40
| | | | | | | | by switching from NSCondition blocking to NSLock blocking - Improve behaviour of SSH tunnels with no password in keychain - prompt appropriately - Set MXPConnection to check the proxy state when attempting to reconnect a dropped connection, extending the timer when an auth UI is up. This prevents a multiple-dialogs misbehaviour (or sometimes deadlock), addressing the last part of http://log.sequelpro.com/view/86 .
* • ensure that the global schema structure data for completion are updated ↵Bibiko2010-03-313-11/+10
| | | | even if SP is not active
* • removed unnecessary retains, ergo fixed some memory leaksBibiko2010-03-311-11/+9
|
* More tidy up. Constants and functions.stuconnolly2010-03-317-33/+43
|
* • fixed issue for refreshing the completion list after finishing the ↵Bibiko2010-03-311-2/+2
| | | | | | structure querying - set variable directly and call [self close] explicitly
* Tidy up imports and fix 'Reverse Sort Order' when sorting connection ↵stuconnolly2010-03-3144-52/+40
| | | | favorites (Thanks Hans).
* • fixed issue for completion window if animated sync icon is shownBibiko2010-03-311-6/+25
| | | | | - init all column' data cells according to their settings to avoid jittering and font size change - this fix also removed one issue for 'overlapping' completion windows
* Manually set the connection favorites button bar delegate to ensure the ↵stuconnolly2010-03-314-5/+29
| | | | split view delegate methods are called.
* check for the attributed string length >= 3 while truncating it to avoid ↵Bibiko2010-03-311-2/+2
| | | | exceptions
* Add a new gear drop down menu to the connection favorites table view ↵stuconnolly2010-03-313-626/+490
| | | | containing the remove, duplicate and sort favorites menu items. Also, fix the selection of newly added and duplicated favorites because of sorting options being applied.
* • if document window will close sent a ↵Bibiko2010-03-313-4/+16
| | | | | | 'cancelPreviousPerformRequestsWithTarget' to the custom query editor to stop auto-completion and auto-help timer to avoid crashes after closing • improved some minor stuff for completion's re-invocation
* If the user is viewing the triggers table and then switches to either a proc ↵stuconnolly2010-03-311-0/+9
| | | | or function disable all interface controls.
* • querying for db structure is queued for the same connection to avoid ↵Bibiko2010-03-318-377/+558
| | | | | | | | | | | 'overlapping' access to global variables • after querying db structure write back data on main thread • completion list displays animated sync images if connection is just querying db structure data • fixed some minor issue for completion list • make sure that if last window of a connection is closed all relevant data will be removed from global variables Note: please test!
* Minor tidy up. Remove uneccessary import and rename pre-compiled header.stuconnolly2010-03-313-8/+8
|
* - Update FeedbackReporter with latest changes from master (minor tweaks ↵rowanbeentje2010-03-312-0/+0
| | | | resulting from merge of our updates, increased stack depth, fix problems logging exceptions on a large number of machines)
* - Improve error checking for various actions, particularly permissions ↵rowanbeentje2010-03-314-16/+92
| | | | errors (NULL data returned) for views and stored procedures. This should fix http://log.sequelpro.com/view/27 , http://log.sequelpro.com/view/57 , and the last of http://log.sequelpro.com/view/53
* When adding a new table with a CSV storage engine, the initial field cannot ↵stuconnolly2010-03-302-11/+26
| | | | be NULL as nullable fields are not supported. Fixes issue #614. Although resolved, this will ultimately be fixed in a better approach upon the implementation of issue #297 that should allow the user to customize many of the properties of the initial field of a new table.
* • next trial to make getAllKeysOfDbStructure thread safeBibiko2010-03-303-65/+135
| | | | | | | | • some speed improvements for navigator - pre-calculate display string for type info to avoid doing it all the time while refreshing the outline view • suppress double-clicking at a not yet queried db structure if the same connection is querying another structure to avoid accessing the same storage objects from different threads (test) • reload outline view after filtering in navigator runs in its own thread to avoid blocking SP • fixed memory leaks while returning [obj copy]
* • some further code optimizations for navigator Bibiko2010-03-302-23/+53
|
* • some speed improvements and code simplifications for navigatorBibiko2010-03-306-53/+53
| | | | | | • avoid making the completion key list unique since it's possible to insert unique items only • added trigger to query db structure after SQL import • some work to avoid http://log.sequelpro.com/view/90 (not yet ideally - WIP)
* - Ensure Copy [with Column Names]/Copy As SQL are disabled on the trigger ↵rowanbeentje2010-03-293-18/+37
| | | | and relations views. This fixes the copy parts of http://log.sequelpro.com/view/53
* • fixed several threading issues due to threadingBibiko2010-03-293-18/+19
| | | | | - collection classes as NSMutableSet are NOT thread safe! • further tiny speed improvements for navigator
* • added some more sanity checks to avoid exceptions due to threadingBibiko2010-03-292-13/+28
|
* • improved completion suggestion for db schemataBibiko2010-03-294-45/+53
| | | | | | | | - if user typed "foo." and there's an unique schema path regardless cases (like there's an item Foo) show the content of the path Foo - now getUniqueDbIdentifierFor:term returns an array of found type (db or table) and the found string to handle case better for completion • tried to speed up the search in the navigator by using a NSPredicate • [MCPConennection allKeysofDbStructure] - fixed issue while returning if allKeysofDbStructure == nil
* • fixed several issue for completion listsBibiko2010-03-297-101/+162
| | | | | | | • improved gathering and caching of structure data coming from connection windows with the same connection • made the structure querying more stable against threading issues • moved getUniqueDbIdentifierFor from MCPConnection to SPNavigatorController to be up-to-date in all connection windows • improved detection if db structure querying should be performed or not (not yet finished)
* - db structure for tables and views will now be queried by using SHOW… ↵Bibiko2010-03-286-161/+276
| | | | | | | | | | | statements - completion now works for server versions < 5 as well - proc/func info will be queried by using information_schema for mysql >= 5 - changed completion logic to handle new format - completion will get the info from SPNavigator since this controller caches all information about db structure - optimization and fine-tuning will follow very soon
* - Improve MCPConnection behaviour with respect to run loops and proxies, ↵rowanbeentje2010-03-272-11/+31
| | | | | | | improving both proxy disconnection and reconnection after dropped connections - Slightly tweak SPSSHTunnel to improve proxy behaviour
* Add 'Edit Favorite...' context menu item to favorites table view in the ↵stuconnolly2010-03-271-7/+85
| | | | connection view.
* Add the ability to sort the connection favorites table view in the ↵stuconnolly2010-03-277-13/+422
| | | | preferences. Sort options are by name, host or type as well as the option to be sorted in reverse order. This implements issue #490.
* - When switching tables, correctly catch disconnections and suppress error ↵rowanbeentje2010-03-275-29/+29
| | | | | | | | | dialogs and related crashes - Move connection error sheet close method to the connection delegate - Tweak the information_schema db schema building query to be much faster on busy servers by amending the VIEW part - Set the connection lock to nil after releasing, coping with connection unlocks deferred on the main thread until after dealloc
* Revent menu item change that shouldn't have been committed.stuconnolly2010-03-271-196/+90
|
* Fix an exception caused when selecting the default favorite popup button. ↵stuconnolly2010-03-272-247/+218
| | | | Caused by the addition of validateMenuItem: in r2015.
* Error messages output from the build script need to be prefixed with ↵stuconnolly2010-03-271-3/+3
| | | | lowercase 'error:' in order to be treated as build errors by Xcode.
* Add a contextual menu to the favorites table view in the preferences.stuconnolly2010-03-273-79/+145
|
* changed the invoking point of db structure query at the very end of ↵Bibiko2010-03-261-3/+5
| | | | updateTables: to be able to collect all available tables while querying the structure
* fixed issue while selecting a db name in navigator which wasn't queried yetBibiko2010-03-261-1/+3
|
* • navigatorBibiko2010-03-266-20/+18
| | | | | - fixed issue if different connection windows are connected to the same connection - prepared structure querying method to be able to add user info containing which table/db was changed if we know it to reduce the future parsing cost
* • Navigator and completion listBibiko2010-03-263-50/+64
| | | | | | - fixed issues for deletion of a db like remove all relevant items and refresh the navigator - simplified and minimized code and memory usage while querying the connection structure - whether a schema name is an unique db or table will be evaluated on run-time via allKeysofDbStructure
* Before attempting to parse the create syntax of a table or view, check that ↵stuconnolly2010-03-261-0/+4
| | | | it's not nil. This accommodates cases where the SHOW CREATE SYNTAX query caused the connection reconnect dialog to appear and the user chose the close the connection.
* • first steps to ease the structure querying for auto-completion and navigatorBibiko2010-03-269-85/+201
| | | | | | | - now it accumulates the data and caches them db by db, ie one has to select a db before using its structure for completion and navigator - next step is to avoid querying info_schema as much as possible - it will only query the structure if something was changed - next steps follows as soon as possible
* Revert a change made in r2005 by not waiting on the completion of calls to ↵stuconnolly2010-03-261-1/+1
| | | | unlockConnection on the main thread.
* Until it can be moved to it's own connection don't allow refreshing of the ↵stuconnolly2010-03-261-10/+5
| | | | processes list whilst the document is performing a task to prevent connection lock errors. Related to issue #607.
* Minor MCPKit tidy up, including the resolution of potential issues raised ↵stuconnolly2010-03-268-48/+133
| | | | during static analysis.
* - Simplify connection keepalives, moving to a single repeating timer on the ↵rowanbeentje2010-03-262-89/+37
| | | | | | | | main thread. This cleans up calls, results in small speed improvements when making lots of queries (no more stopping/starting of keepalives), and ensures only the main thread handles the initial keepalives. - Move connection unlocking to a blocking call to fix http://log.sequelpro.com/view/73 - Fix memory leaks caused by non-detached pthreads
* Localize 'Save As...' button titles on console and process list windows.stuconnolly2010-03-253-4/+4
|
* Bunch of improvements to the server process list viewer, including:stuconnolly2010-03-256-295/+575
| | | | | | | | | | - It is now a separate window like the console to enable monitoring. - It now uses the same window style as the console. - The ability to show or hide the process ID, column. This could possibly be enabled for some of the other columns as well, suggestions? - The ability to enable or disable the use of SHOW FULL PROCESSLIST or just SHOW PROCESSLIST. This implements most of the enhancements requested in issue #607, with the exception of the option to enable auto-refresh, which is still being worked on.
* Add support for selecting the triggers view as the default in the general ↵stuconnolly2010-03-255-23/+95
| | | | preferences pane.
* • changed behaviour of ^⌥⌘F "Filter Table" or "Change Focus to Table ↵Bibiko2010-03-253-10/+24
| | | | | | | | List" - if > 20 tables are listed it sets the focus on the search field - if <= 20 it sets the focus on the table list, and - if no selection - it selects the first table item - this fixes i597
* Add support for the triggers view in the history controller.stuconnolly2010-03-252-2/+11
|
* Suppress the connection structure query if there're more than 10000 items ↵Bibiko2010-03-251-2/+24
| | | | are listed in `information_schema`.`COLUMNS` for now which is a 'quick-fix' for i608. In the near future the gathering routine will do it db/table by db/table to minimize the traffic starting from the current selected db.